ARM: dts: imx53-qsrb: Pulldown PMIC IRQ pin
Subsystems (2)
Fabio Estevam
reviewerPATCH v2 1/1 ARM: dts: imx53-qsrb: Pulldown PMIC IRQ pin
From: Fabio Estevam <[email protected]>
Currently the following errors are seen:
[ 14.015056] mc13xxx 0-0008: Failed to read IRQ status: -6 [ 27.321093] mc13xxx 0-0008: Failed to read IRQ status: -6 [ 27.411681] mc13xxx 0-0008: Failed to read IRQ status: -6 [ 27.456281] mc13xxx 0-0008: Failed to read IRQ status: -6 [ 30.527106] mc13xxx 0-0008: Failed to read IRQ status: -6 [ 36.596900] mc13xxx 0-0008: Failed to read IRQ status: -6
Also when reading the interrupts via 'cat /proc/interrupts' the PMIC GPIO interrupt counter does not stop increasing.
The reason for the storm of interrupts is that the PUS field of register IOMUXC_SW_PAD_CTL_PAD_CSI0_DAT5 is currently configured as:
10 : 100k pullup
and the PMIC interrupt is being registered as IRQ_TYPE_LEVEL_HIGH type, which is the correct type as per the MC34708 datasheet.
Use the default power on value for the IOMUX, which sets PUS field as:
00: 360k pull down
This prevents the spurious PMIC interrupts from happening.
Commit e1ffceb078c6 ("ARM: imx53: qsrb: fix PMIC interrupt level") correctly described the irq type as IRQ_TYPE_LEVEL_HIGH, but missed to update the IOMUX of the PMIC GPIO as pull down.
---
Changes since v1:
- Fix typo: s/seeing/seen in the commit log
arch/arm/boot/dts/imx53-qsrb.dts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/boot/dts/imx53-qsrb.dts +1 -1
@@ -23,7 +23,7 @@ imx53-qsrb { pinctrl_pmic: pmicgrp { fsl,pins = < - MX53_PAD_CSI0_DAT5__GPIO5_23 0x1e4 /* IRQ */ + MX53_PAD_CSI0_DAT5__GPIO5_23 0x1c4 /* IRQ */ >; }; };
Signature · 1 line
2.7.4
PATCH v2 1/1 ARM: dts: imx53-qsrb: Pulldown PMIC IRQ pin
Quoted 30 lines · Fabio Estevam
From: Fabio Estevam <[email protected]>
Currently the following errors are seen:
[ 14.015056] mc13xxx 0-0008: Failed to read IRQ status: -6 [ 27.321093] mc13xxx 0-0008: Failed to read IRQ status: -6 [ 27.411681] mc13xxx 0-0008: Failed to read IRQ status: -6 [ 27.456281] mc13xxx 0-0008: Failed to read IRQ status: -6 [ 30.527106] mc13xxx 0-0008: Failed to read IRQ status: -6 [ 36.596900] mc13xxx 0-0008: Failed to read IRQ status: -6Also when reading the interrupts via 'cat
/proc/interrupts' the PMIC GPIO interrupt counter does not stop increasing.The reason for the storm of interrupts is that the PUS field of register
IOMUXC_SW_PAD_CTL_PAD_CSI0_DAT5is currently configured as:
10 : 100k pullupand the PMIC interrupt is being registered as
IRQ_TYPE_LEVEL_HIGHtype, which is the correct type as per the MC34708 datasheet.Use the default power on value for the IOMUX, which sets PUS field as:
00: 360k pull downThis prevents the spurious PMIC interrupts from happening.
Commit
e1ffceb078c6("ARM: imx53: qsrb: fix PMIC interrupt level") correctly described the irq type asIRQ_TYPE_LEVEL_HIGH, but missed to update the IOMUX of the PMIC GPIO as pull down.
Quoted 5 lines
Fixes e1ffceb078c6 ("ARM: imx53: qsrb: fix PMIC interrupt level")Signed-off-by Fabio Estevam <[email protected]>---
Changes since v1:
- Fix typo: s/seeing/seen in the commit log
Okay, replaced with this one.