net: phy: test the right variable in phy_write_mmd()

PATCH Applied Dan Carpenter 3 participants 3 messages Apr 14, 2017 – Apr 17, 2017

Subsystems (4)

Networking Network drivers Kernel janitors Ethernet PHY

lore

Share & tools

lore

Dan Carpenter

author

2017-04-14 19:10 UTC #0 lore raw

PATCH 1/1 net: phy: test the right variable in phy_write_mmd()

This is a copy and paste buglet. We meant to test for ->write_mmd but we test for ->read_mmd.

Fixes 1ee6b9bc6206 ("net: phy: make phy_(read|write)_mmd() generic MMD accessors")

Signed-off-by Dan Carpenter <[email protected]>

drivers/net/phy/phy-core.c +1 -1

index 357a4d0d7641..6739b738bbaf 100644
@@ -76,7 +76,7 @@ int phy_write_mmd(struct phy_device *phydev, int devad, u32 regnum, u16 val)
 	if (regnum > (u16)~0 || devad > 32)
 		return -EINVAL;
 
-	if (phydev->drv->read_mmd) {
+	if (phydev->drv->write_mmd) {
 		ret = phydev->drv->write_mmd(phydev, devad, regnum, val);
 	} else if (phydev->is_c45) {
 		u32 addr = MII_ADDR_C45 | (devad << 16) | (regnum & 0xffff);

Andrew Lunn

maintainer Reviewed-by on v1 1/1

2017-04-14 19:14 UTC #1 lore raw

Quoted 5 lines · Dan Carpenter

This is a copy and paste buglet. We meant to test for ->write_mmd but we test for ->read_mmd.
Fixes 1ee6b9bc6206 ("net: phy: make phy_(read|write)_mmd() generic MMD accessors")
Signed-off-by Dan Carpenter <[email protected]>

Reviewed-by Andrew Lunn <[email protected]>

Andrew

David Miller

maintainer Applied

2017-04-17 19:11 UTC #2 lore raw

In reply to Dan Carpenter

From: Dan Carpenter <[email protected]>
Date: Fri, 14 Apr 2017 22:10:41 +0300

Quoted 5 lines

This is a copy and paste buglet. We meant to test for ->write_mmd but we test for ->read_mmd.
Fixes 1ee6b9bc6206 ("net: phy: make phy_(read|write)_mmd() generic MMD accessors")
Signed-off-by Dan Carpenter <[email protected]>

Applied, thanks Dan.