Skip to contentSkip to conversation

can: use namespace aware procfs function

PATCH New Oliver Hartkopp 2 participants 6 messages Apr 15, 2017 – Apr 25, 2017

Subsystems (2)
lore
Share & tools
lore

Oliver Hartkopp

author maintainer
#0 lore raw

PATCH 1/1 can: use namespace aware procfs function

Fixes 'can: complete initial namespace support'

---
 net/can/proc.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
net/can/proc.c +3 -3
index 1a7d95e2335b..83045f00c63c 100644
@@ -272,7 +272,7 @@ static int can_stats_proc_show(struct seq_file *m, void *v)
 
 static int can_stats_proc_open(struct inode *inode, struct file *file)
 {
-	return single_open(file, can_stats_proc_show, NULL);
+	return single_open_net(inode, file, can_stats_proc_show);
 }
 
 static const struct file_operations can_stats_proc_fops = {
@@ -306,7 +306,7 @@ static int can_reset_stats_proc_show(struct seq_file *m, void *v)
 
 static int can_reset_stats_proc_open(struct inode *inode, struct file *file)
 {
-	return single_open(file, can_reset_stats_proc_show, NULL);
+	return single_open_net(inode, file, can_reset_stats_proc_show);
 }
 
 static const struct file_operations can_reset_stats_proc_fops = {
@@ -325,7 +325,7 @@ static int can_version_proc_show(struct seq_file *m, void *v)
 
 static int can_version_proc_open(struct inode *inode, struct file *file)
 {
-	return single_open(file, can_version_proc_show, NULL);
+	return single_open_net(inode, file, can_version_proc_show);
 }
 
 static const struct file_operations can_version_proc_fops = {
Signature · 1 line
2.11.0
author maintainer
#1 lore raw

PATCH 1/1 can: use namespace aware procfs function

Hey Marc,

can you squash this fix into my original RFC v2 patch?

I missed this change which then leads to a segfault.

Alternatively I can send a v3.

Regards,
Oliver

-------- Forwarded Message --------
Subject: [PATCH] can: use namespace aware procfs function
Date: Sat, 15 Apr 2017 20:06:29 +0200
From: Oliver Hartkopp <[email protected]>
To: [email protected]
CC: Oliver Hartkopp <[email protected]>

Fixes 'can: complete initial namespace support'

---
 net/can/proc.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
net/can/proc.c +1 -1
index 1a7d95e2335b..83045f00c63c 100644
@@ -272,7 +272,7 @@ static int can_stats_proc_show(struct seq_file *m, void *v)
  static int can_stats_proc_open(struct inode *inode, struct file *file)
 {
-	return single_open(file, can_stats_proc_show, NULL);
+	return single_open_net(inode, file, can_stats_proc_show);
 }
  static const struct file_operations can_stats_proc_fops = {
@@ -306,7 +306,7 @@ static int can_reset_stats_proc_show(struct seq_file *m, void *v)
  static int can_reset_stats_proc_open(struct inode *inode, struct file 

*file)
{
- return single_open(file, can_reset_stats_proc_show, NULL);
+ return single_open_net(inode, file, can_reset_stats_proc_show);
}
static const struct file_operations can_reset_stats_proc_fops = {
@@ -325,7 +325,7 @@ static int can_version_proc_show(struct seq_file *m, void *v)
static int can_version_proc_open(struct inode *inode, struct file *file)
{
- return single_open(file, can_version_proc_show, NULL);
+ return single_open_net(inode, file, can_version_proc_show);
}
static const struct file_operations can_version_proc_fops = {

Signature · 6 lines
2.11.0

--
To unsubscribe from this list: send the line "unsubscribe linux-can" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
#2 lore raw
Quoted 3 lines · Oliver Hartkopp

Hey Marc,

can you squash this fix into my original RFC v2 patch?

will do.

Marc

Signature · 4 lines
Pengutronix e.K.                  | Marc Kleine-Budde           |
Industrial Linux Solutions        | Phone: +49-231-2826-924     |
Vertretung West/Dortmund          | Fax:   +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686  | http://www.pengutronix.de   |
author maintainer
#3 lore raw
Quoted 7 lines · Marc Kleine-Budde
Quoted 3 lines · Oliver Hartkopp

Hey Marc,

can you squash this fix into my original RFC v2 patch?

will do.

Great!

I finalized a namespace patch for CAN BCM some minutes ago.

I'll do some more testing tomorrow and post it then.

Best regards,
Oliver

author maintainer
#4 lore raw
Quoted 4 lines · Oliver Hartkopp
Quoted 3 lines · Marc Kleine-Budde
Quoted 1 line · Oliver Hartkopp

can you squash this fix into my original RFC v2 patch?

Quoted 8 lines
Quoted 2 lines

will do.

Great!

I finalized a namespace patch for CAN BCM some minutes ago.

I'll do some more testing tomorrow and post it then.

Done :-)

Will you push these patches to can-next?

Regards,
Oliver

#5 lore raw
Quoted 10 lines · Oliver Hartkopp
Quoted 9 lines · Oliver Hartkopp
Quoted 5 lines · Marc Kleine-Budde
Quoted 1 line · Oliver Hartkopp

can you squash this fix into my original RFC v2 patch?

will do.

Great!

Quoted 7 lines
Quoted 3 lines

I finalized a namespace patch for CAN BCM some minutes ago.

I'll do some more testing tomorrow and post it then.

Done :-)

Will you push these patches to can-next?

done.

Marc

Signature · 4 lines
Pengutronix e.K.                  | Marc Kleine-Budde           |
Industrial Linux Solutions        | Phone: +49-231-2826-924     |
Vertretung West/Dortmund          | Fax:   +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686  | http://www.pengutronix.de   |