Skip to contentSkip to conversation

MPTCP upstreaming introduction

MPTCP Mat Martineau 2 participants 4 messages Apr 11, 2017 – Apr 19, 2017 1 message not in the archive Networking MPTCP

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

Mat Martineau

author
#1 lore raw

Hi Christoph,

Rao and I talked with David Miller and Eric Dumazet. They aren't enthusiastic about MPTCP from a protocol perpective, and pointed to the example of kcm as something that builds on top of multiple TCP connections rather than modifying TCP itself. I think they're a little skeptical that there's a committment to put in the necessary effort to upstream.

A few specific points of our discussions:

* Intrusive changes to TCP are not acceptable, the code is already complex and they don't want to introduce bugs or create additional maintenance burden. Given the need to tie in to TCP for option parsing (and other changed behaviors), they're willing to look at adding hooks - but of course reserved judgment until there are actual patches to look at.

* Related to that, skb size cannot increase.

* Regular TCP connections should remain the default and should work like they do now.

* Expect the review process to take a while.

These points are what drives the goals I listed below. Identifying the right (limited) set of hooks in to the TCP code is going to be an important early step.

Best regards,
Mat

Quoted 47 lines · Christoph Paasch

Hi Mat,

what was the feedback/info you got from netdev 2.1 ?

Christoph

Quoted 38 lines · Mat Martineau

Welcome to the MPTCP upstreaming mailing list!

This list (mptcp(a)lists.01.org) is focused on integrating MPTCP (RFC 6824 / RFC 6824bis) as part of the standard Linux kernel. In speaking with the Linux networking / TCP maintainers, it is important that MPTCP does not interfere with the performance or reliability of the TCP stack, or complicate the existing TCP code.

Given the Linux netdev maintainer's needs, we have the following high-level design goals in mind:

* Minimize changes to core TCP.

* Favor atomic operations and RCU synchronization over more expensive options like mutexes or spinlocks.

* Implement features in userspace where latency isn't important and data flow is not affected

* TCP operates as "normal TCP" by default. Individual sockets may opt-in, or systemwide configuration can be used to broadly enable MPTCP.

The role of this list is to coordinate upstreaming efforts and share code prior to upstream submission on netdev(a)lists.01.org . This list is separate from the mptcp-dev list associated with the multipath-tcp.org kernel in order to avoid confusion between netdev-focused efforts and work related to multipath-tcp.org . Anyone interested in MPTCP for the upstream kernel is welcome on mptcp(a)lists.01.org, we appreciate your expertise and contributions!

You can manage your subscription or view list archives at
https://lists.01.org/mailman/listinfo/mptcp

Best regards,

--
Mat Martineau
Intel OTC

--
Mat Martineau
Intel OTC

#2 lore raw

Hello Mat,

Quoted 17 lines · Mat Martineau

Hi Christoph,

Rao and I talked with David Miller and Eric Dumazet. They aren't enthusiastic about MPTCP from a protocol perpective, and pointed to the example of kcm as something that builds on top of multiple TCP connections rather than modifying TCP itself. I think they're a little skeptical that there's a committment to put in the necessary effort to upstream.

A few specific points of our discussions:

* Intrusive changes to TCP are not acceptable, the code is already complex and they don't want to introduce bugs or create additional maintenance burden. Given the need to tie in to TCP for option parsing (and other changed behaviors), they're willing to look at adding hooks - but of course reserved judgment until there are actual patches to look at.

Quoted 4 lines

* Related to that, skb size cannot increase.

* Regular TCP connections should remain the default and should work like they do now.

That's good info. So we will have to make it opt-in through a socket-option or even create a new socket-type.

Quoted 6 lines

* Expect the review process to take a while.

These points are what drives the goals I listed below. Identifying the right (limited) set of hooks in to the TCP code is going to be an important early step.

sounds great! Do you have a public git repo where the development happens? Might be good to set this up.

Cheers,
Christoph

Quoted 58 lines

Best regards,
Mat

Quoted 47 lines · Christoph Paasch

Hi Mat,

what was the feedback/info you got from netdev 2.1 ?

Christoph

Quoted 38 lines · Mat Martineau

Welcome to the MPTCP upstreaming mailing list!

This list (mptcp(a)lists.01.org) is focused on integrating MPTCP (RFC 6824 / RFC 6824bis) as part of the standard Linux kernel. In speaking with the Linux networking / TCP maintainers, it is important that MPTCP does not interfere with the performance or reliability of the TCP stack, or complicate the existing TCP code.

Given the Linux netdev maintainer's needs, we have the following high-level design goals in mind:

* Minimize changes to core TCP.

* Favor atomic operations and RCU synchronization over more expensive options like mutexes or spinlocks.

* Implement features in userspace where latency isn't important and data flow is not affected

* TCP operates as "normal TCP" by default. Individual sockets may opt-in, or systemwide configuration can be used to broadly enable MPTCP.

The role of this list is to coordinate upstreaming efforts and share code prior to upstream submission on netdev(a)lists.01.org . This list is separate from the mptcp-dev list associated with the multipath-tcp.org kernel in order to avoid confusion between netdev-focused efforts and work related to multipath-tcp.org . Anyone interested in MPTCP for the upstream kernel is welcome on mptcp(a)lists.01.org, we appreciate your expertise and contributions!

You can manage your subscription or view list archives at
https://lists.01.org/mailman/listinfo/mptcp

Best regards,

--
Mat Martineau
Intel OTC

--
Mat Martineau
Intel OTC

author
#3 lore raw

Hi Christoph,

Quoted 20 lines · Christoph Paasch

Hello Mat,

Quoted 17 lines · Mat Martineau

Hi Christoph,

Rao and I talked with David Miller and Eric Dumazet. They aren't enthusiastic about MPTCP from a protocol perpective, and pointed to the example of kcm as something that builds on top of multiple TCP connections rather than modifying TCP itself. I think they're a little skeptical that there's a committment to put in the necessary effort to upstream.

A few specific points of our discussions:

* Intrusive changes to TCP are not acceptable, the code is already complex and they don't want to introduce bugs or create additional maintenance burden. Given the need to tie in to TCP for option parsing (and other changed behaviors), they're willing to look at adding hooks - but of course reserved judgment until there are actual patches to look at.

Quoted 7 lines
Quoted 4 lines

* Related to that, skb size cannot increase.

* Regular TCP connections should remain the default and should work like they do now.

That's good info. So we will have to make it opt-in through a socket-option or even create a new socket-type.

I experimented with two approaches: AF_MPTCP and IPPROTO_MPTCP (the latter using either AF_INET or AF_INET6). IPPROTO_MPTCP worked a lot better with existing code (especially Python's socket module!). I'll tidy up the patch set and post it.

Quoted 9 lines
Quoted 6 lines

* Expect the review process to take a while.

These points are what drives the goals I listed below. Identifying the right (limited) set of hooks in to the TCP code is going to be an important early step.

sounds great! Do you have a public git repo where the development happens? Might be good to set this up.

My plan is to share patches on this list, and I will publish a mptcp branch on my git.kernel.org repo:

https://git.kernel.org/pub/scm/linux/kernel/git/martineau/linux.git/

Since we'll be posting patches to netdev, I think it will work well to use the typical kernel mailing list 'git send-email' workflow.

--
Mat Martineau
Intel OTC

#4 lore raw

Hello,

Quoted 30 lines · Mat Martineau

Hi Christoph,

Quoted 25 lines · Christoph Paasch

Hello Mat,

Quoted 21 lines · Mat Martineau

Hi Christoph,

Rao and I talked with David Miller and Eric Dumazet. They aren't enthusiastic about MPTCP from a protocol perpective, and pointed to the example of kcm as something that builds on top of multiple TCP connections rather than modifying TCP itself. I think they're a little skeptical that there's a committment to put in the necessary effort to upstream.

A few specific points of our discussions:

* Intrusive changes to TCP are not acceptable, the code is already complex and they don't want to introduce bugs or create additional maintenance burden. Given the need to tie in to TCP for option parsing (and other changed behaviors), they're willing to look at adding hooks - but of course reserved judgment until there are actual patches to look at.

* Related to that, skb size cannot increase.

* Regular TCP connections should remain the default and should work like they do now.

Quoted 7 lines
Quoted 2 lines

That's good info. So we will have to make it opt-in through a socket-option or even create a new socket-type.

I experimented with two approaches: AF_MPTCP and IPPROTO_MPTCP (the latter using either AF_INET or AF_INET6). IPPROTO_MPTCP worked a lot better with existing code (especially Python's socket module!). I'll tidy up the patch set and post it.

great! Looking forward to it.

Quoted 11 lines
Quoted 10 lines
Quoted 7 lines

* Expect the review process to take a while.

These points are what drives the goals I listed below. Identifying the right (limited) set of hooks in to the TCP code is going to be an important early step.

sounds great! Do you have a public git repo where the development happens? Might be good to set this up.

Quoted 7 lines

My plan is to share patches on this list, and I will publish a mptcp branch on my git.kernel.org repo:

https://git.kernel.org/pub/scm/linux/kernel/git/martineau/linux.git/

Since we'll be posting patches to netdev, I think it will work well to use the typical kernel mailing list 'git send-email' workflow.

Sounds good!

Christoph