Lenovo Thinkpad quirks
Subsystems (4)
cover Lenovo Thinkpad quirks
Minor update to support new skews and need to manage quirks in codec driver for jack detection to work.
Nicole Faerber (1):
ASoC: codecs: rt5670: add Thinkpad Tablet 10 quirk
Pierre-Louis Bossart (1):
ASoC: Intel: Atom: update Thinkpad 10 quirk
sound/soc/codecs/rt5670.c | 21 +++++++++++++++++++++ sound/soc/intel/atom/sst/sst_acpi.c | 16 +++++++++++++++- 2 files changed, 36 insertions(+), 1 deletion(-)
Signature · 1 line
2.9.3
PATCH 1/2 ASoC: Intel: Atom: update Thinkpad 10 quirk
There are multiple skews of the same Lenovo audio hardware based on the Realtek RT5670 codec.
Manufacturer: LENOVO
Product Name: 20C1CTO1WW
Version: ThinkPad 10
Manufacturer: LENOVO
Product Name: 20C3001VHH Version: ThinkPad 10
Manufacturer: LENOVO
Product Name: 20C10024GE Version: ThinkPad Tablet B
Manufacturer: LENOVO
Product Name: 20359 Version: Lenovo Miix 2 10
For all these devices, the same quirk is used to force the machine driver to be based on RT5670 instead of RT5640 as indicated by the BIOS.
Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=96691
--- sound/soc/intel/atom/sst/sst_acpi.c | 16 +++++++++++++++- 1 file changed, 15 insertions(+), 1 deletion(-)
sound/soc/intel/atom/sst/sst_acpi.c +15 -1
@@ -420,7 +420,21 @@ static const struct dmi_system_id byt_table[] = { .callback = byt_thinkpad10_quirk_cb, .matches = {DMI_MATCH (DMI_SYS_VENDOR ,"LENOVO" ), - DMI_MATCH(DMI_PRODUCT_NAME, "20C3001VHH"), + DMI_MATCH(DMI_PRODUCT_VERSION, "ThinkPad 10"), + }, + }, + { + .callback = byt_thinkpad10_quirk_cb, + .matches = { +DMI_MATCH (DMI_SYS_VENDOR ,"LENOVO" ), + DMI_MATCH(DMI_PRODUCT_VERSION, "ThinkPad Tablet B"), + }, + }, + { + .callback = byt_thinkpad10_quirk_cb, + .matches = { +DMI_MATCH (DMI_SYS_VENDOR ,"LENOVO" ), + DMI_MATCH(DMI_PRODUCT_VERSION, "Lenovo Miix 2 10"), }, }, { }
Signature · 1 line
2.9.3
Re: [PATCH 1/2] ASoC: Intel: Atom: update Thinkpad 10 quirk
L'octidi 28 germinal, an CCXXV, Pierre-Louis Bossart a écrit :
Quoted 6 lines
There are multiple skews of the same Lenovo audio hardware based on the Realtek RT5670 codec.
Manufacturer: LENOVO
Product Name: 20359 Version: Lenovo Miix 2 10
Interesting. Any chance that applies to the Miix 3-1030 too?
sound/soc/intel/atom/sst/sst_acpi.c static const struct dmi_system_id byt_table[] = { · line 437
Quoted 5 lines
sound/soc/intel/atom/sst/sst_acpi.c +5
-0+ { + .callback = byt_thinkpad10_quirk_cb, + .matches = { +DMI_MATCH (DMI_SYS_VENDOR ,"LENOVO" ), + DMI_MATCH(DMI_PRODUCT_VERSION, "Lenovo Miix 2 10"),
I guess I should run dmidecode, get the kernel sources, make a similar change and test. Unfortunately, I will probably not have time to do that until at least the week-end.
Thanks.
Signature · 1 line
Nicolas George
Re: [PATCH 1/2] ASoC: Intel: Atom: update Thinkpad 10 quirk
Quoted 7 lines · Nicolas George
Quoted 5 lines · Pierre-Louis Bossart
There are multiple skews of the same Lenovo audio hardware based on the Realtek RT5670 codec.
Manufacturer: LENOVOProduct Name: 20359 Version: Lenovo Miix 2 10Interesting. Any chance that applies to the Miix 3-1030 too?
no idea, you'd have to look at dmesg/DSDT and check if the same rt5640/rt5670 BIOS confusion applies.
Quoted 9 lines
sound/soc/intel/atom/sst/sst_acpi.c static const struct dmi_system_id byt_table[] = { · line 437
Quoted 6 lines
sound/soc/intel/atom/sst/sst_acpi.c +5
-0+ { + .callback = byt_thinkpad10_quirk_cb, + .matches = { +DMI_MATCH (DMI_SYS_VENDOR ,"LENOVO" ), + DMI_MATCH(DMI_PRODUCT_VERSION, "Lenovo Miix 2 10"),I guess I should run dmidecode, get the kernel sources, make a similar change and test. Unfortunately, I will probably not have time to do that until at least the week-end.
DMI decode is only needed once you've confirmed the device can't work with the normal ACPI handling. Please provide your findings on bugzilla (dmesg, DSDT, alsa-info.sh)
https://bugzilla.kernel.org/show_bug.cgi?id=96691
Quoted 9 lines
Thanks.
_______________________________________________
Alsa-devel mailing list
[email protected]
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
Mark Brown
maintainerApplied "ASoC: Intel: Atom: update Thinkpad 10 quirk" to the asoc tree
In reply to Pierre-Louis BossartThe patch
ASoC: Intel: Atom: update Thinkpad 10 quirk
has been applied to the asoc tree at
git://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git
All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying to this mail.
Thanks,
Mark
Quoted 1 line
From
beb5989a8c6c6867b4e873cca2a66d31f977368fMon Sep 17 00:00:00 2001
From: Pierre-Louis Bossart <[email protected]>
Date: Mon, 17 Apr 2017 10:04:07 -0500
Subject: [PATCH] ASoC: Intel: Atom: update Thinkpad 10 quirk
There are multiple skews of the same Lenovo audio hardware based on the Realtek RT5670 codec.
Manufacturer: LENOVO
Product Name: 20C1CTO1WW
Version: ThinkPad 10
Manufacturer: LENOVO
Product Name: 20C3001VHH Version: ThinkPad 10
Manufacturer: LENOVO
Product Name: 20C10024GE Version: ThinkPad Tablet B
Manufacturer: LENOVO
Product Name: 20359 Version: Lenovo Miix 2 10
For all these devices, the same quirk is used to force the machine driver to be based on RT5670 instead of RT5640 as indicated by the BIOS.
Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=96691
--- sound/soc/intel/atom/sst/sst_acpi.c | 16 +++++++++++++++- 1 file changed, 15 insertions(+), 1 deletion(-)
sound/soc/intel/atom/sst/sst_acpi.c +15 -1
@@ -420,7 +420,21 @@ static const struct dmi_system_id byt_table[] = { .callback = byt_thinkpad10_quirk_cb, .matches = {DMI_MATCH (DMI_SYS_VENDOR ,"LENOVO" ), - DMI_MATCH(DMI_PRODUCT_NAME, "20C3001VHH"), + DMI_MATCH(DMI_PRODUCT_VERSION, "ThinkPad 10"), + }, + }, + { + .callback = byt_thinkpad10_quirk_cb, + .matches = { +DMI_MATCH (DMI_SYS_VENDOR ,"LENOVO" ), + DMI_MATCH(DMI_PRODUCT_VERSION, "ThinkPad Tablet B"), + }, + }, + { + .callback = byt_thinkpad10_quirk_cb, + .matches = { +DMI_MATCH (DMI_SYS_VENDOR ,"LENOVO" ), + DMI_MATCH(DMI_PRODUCT_VERSION, "Lenovo Miix 2 10"), }, }, { }
Signature · 1 line
2.11.0
PATCH 2/2 ASoC: codecs: rt5670: add Thinkpad Tablet 10 quirk
In reply to Pierre-Louis BossartFrom: Nicole Faerber <[email protected]>
The Thinkpad Tablet tablet has a similar audio setup as the Intel Braswell platform.
A quirk is needed to detect the platform and setup the platform data properly:
Manufacturer: LENOVO
Product Name: 20C1CTO1WW
Version: ThinkPad 10
Manufacturer: LENOVO
Product Name: 20C3001VHH Version: ThinkPad 10
Manufacturer: LENOVO
Product Name: 20C10024GE Version: ThinkPad Tablet B
Manufacturer: LENOVO
Product Name: 20359
Version: Lenovo Miix 2 10
--- sound/soc/codecs/rt5670.c | 21 +++++++++++++++++++++ 1 file changed, 21 insertions(+)
sound/soc/codecs/rt5670.c +21 -0
@@ -2835,6 +2835,27 @@ static const struct dmi_system_id dmi_platform_intel_braswell[] = { DMI_MATCH(DMI_PRODUCT_NAME, "Wyse 3040"), }, }, + { + .ident = "Lenovo Thinkpad Tablet 10", + .matches = { + DMI_MATCH(DMI_SYS_VENDOR, "LENOVO"), + DMI_MATCH(DMI_PRODUCT_VERSION, "ThinkPad 10"), + }, + }, + { + .ident = "Lenovo Thinkpad Tablet 10", + .matches = { + DMI_MATCH(DMI_SYS_VENDOR, "LENOVO"), + DMI_MATCH(DMI_PRODUCT_VERSION, "ThinkPad Tablet B"), + }, + }, + { + .ident = "Lenovo Thinkpad Tablet 10", + .matches = { + DMI_MATCH(DMI_SYS_VENDOR, "LENOVO"), + DMI_MATCH(DMI_PRODUCT_VERSION, "Lenovo Miix 2 10"), + }, + }, {} };
Signature · 1 line
2.9.3
Mark Brown
maintainerApplied "ASoC: codecs: rt5670: add Thinkpad Tablet 10 quirk" to the asoc tree
The patch
ASoC: codecs: rt5670: add Thinkpad Tablet 10 quirk
has been applied to the asoc tree at
git://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git
All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying to this mail.
Thanks,
Mark
Quoted 1 line
From
67e03ff3f32ffeb8f425d80627f3054b60bac0b7Mon Sep 17 00:00:00 2001
From: Nicole Faerber <[email protected]>
Date: Mon, 17 Apr 2017 10:04:08 -0500
Subject: [PATCH] ASoC: codecs: rt5670: add Thinkpad Tablet 10 quirk
The Thinkpad Tablet tablet has a similar audio setup as the Intel Braswell platform.
A quirk is needed to detect the platform and setup the platform data properly:
Manufacturer: LENOVO
Product Name: 20C1CTO1WW
Version: ThinkPad 10
Manufacturer: LENOVO
Product Name: 20C3001VHH Version: ThinkPad 10
Manufacturer: LENOVO
Product Name: 20C10024GE Version: ThinkPad Tablet B
Manufacturer: LENOVO
Product Name: 20359
Version: Lenovo Miix 2 10
--- sound/soc/codecs/rt5670.c | 21 +++++++++++++++++++++ 1 file changed, 21 insertions(+)
sound/soc/codecs/rt5670.c +21 -0
@@ -2835,6 +2835,27 @@ static const struct dmi_system_id dmi_platform_intel_braswell[] = { DMI_MATCH(DMI_PRODUCT_NAME, "Wyse 3040"), }, }, + { + .ident = "Lenovo Thinkpad Tablet 10", + .matches = { + DMI_MATCH(DMI_SYS_VENDOR, "LENOVO"), + DMI_MATCH(DMI_PRODUCT_VERSION, "ThinkPad 10"), + }, + }, + { + .ident = "Lenovo Thinkpad Tablet 10", + .matches = { + DMI_MATCH(DMI_SYS_VENDOR, "LENOVO"), + DMI_MATCH(DMI_PRODUCT_VERSION, "ThinkPad Tablet B"), + }, + }, + { + .ident = "Lenovo Thinkpad Tablet 10", + .matches = { + DMI_MATCH(DMI_SYS_VENDOR, "LENOVO"), + DMI_MATCH(DMI_PRODUCT_VERSION, "Lenovo Miix 2 10"), + }, + }, {} };
Signature · 1 line
2.11.0