net/mlx5e: IPoIB, Fix error handling in mlx5_rdma_netdev_alloc()

PATCH Applied Dan Carpenter 3 participants 3 messages Apr 19, 2017 – Apr 20, 2017

Subsystems (5)

Networking Network drivers Kernel janitors InfiniBand +1 more subsystems

lore

Share & tools

lore

Dan Carpenter

author

2017-04-19 09:59 UTC #0 lore raw

PATCH 1/1 net/mlx5e: IPoIB, Fix error handling in mlx5_rdma_netdev_alloc()

The labels were out of order, so it either could result in an Oops or a leak.

Fixes 48935bbb7ae8 ("net/mlx5e: IPoIB, Add netdevice profile skeleton")

Signed-off-by Dan Carpenter <[email protected]>

drivers/net/ethernet/mellanox/mlx5/core/ipoib.c +3 -2

index 001d2953cb6d..ec78e637840f 100644
@@ -471,10 +471,11 @@ struct net_device *mlx5_rdma_netdev_alloc(struct mlx5_core_dev *mdev,
 	 */
 	return netdev;
 
-free_mdev_resources:
-	mlx5e_destroy_mdev_resources(mdev);
 err_free_netdev:
 	free_netdev(netdev);
+free_mdev_resources:
+	mlx5e_destroy_mdev_resources(mdev);
+
 	return NULL;
 }
 EXPORT_SYMBOL(mlx5_rdma_netdev_alloc);

Leon Romanovsky

Acked-by on v1 1/1

2017-04-19 10:11 UTC #1 lore raw

Quoted 6 lines · Dan Carpenter

The labels were out of order, so it either could result in an Oops or a leak.
Fixes 48935bbb7ae8 ("net/mlx5e: IPoIB, Add netdevice profile skeleton")
Signed-off-by Dan Carpenter <[email protected]>

Thanks,

Acked-by Leon Romanovsky <[email protected]>

David Miller

Applied

2017-04-20 20:28 UTC #2 lore raw

In reply to Dan Carpenter

From: Dan Carpenter <[email protected]>
Date: Wed, 19 Apr 2017 12:59:15 +0300

Quoted 5 lines

The labels were out of order, so it either could result in an Oops or a leak.
Fixes 48935bbb7ae8 ("net/mlx5e: IPoIB, Add netdevice profile skeleton")
Signed-off-by Dan Carpenter <[email protected]>

Applied.