Skip to contentSkip to conversation

drm/amd/amdgpu: Change comp GFXv6 ring name to remove space

PATCH In review Tom St Denis 3 participants 4 messages Apr 19, 2017 2 messages not in the archive

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/2 drm/amd/amdgpu: Change comp GFXv6 ring name to remove space

umr expects the ring name to be a complete word. This also makes it consistent with GFXv7/8.

---
 drivers/gpu/drm/amd/amdgpu/gfx_v6_0.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/amd/amdgpu/gfx_v6_0.c +1 -1
index 625dbfc4f826..f7579dedc577 100644
@@ -3292,7 +3292,7 @@ static int gfx_v6_0_sw_init(void *handle)
 		ring->me = 1;
 		ring->pipe = i;
 		ring->queue = i;
-		sprintf(ring->name, "comp %d.%d.%d", ring->me, ring->pipe, ring->queue);
+		sprintf(ring->name, "comp_%d.%d.%d", ring->me, ring->pipe, ring->queue);
 		irq_type = AMDGPU_CP_IRQ_COMPUTE_MEC1_PIPE0_EOP + ring->pipe;
 		r = amdgpu_ring_init(adev, ring, 1024,
 				     &adev->gfx.eop_irq, irq_type);
Signature · 6 lines
2.12.0

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

A message that is not in the archive (sent off-list or not yet received): [email protected]

#2 lore raw

PATCH 2/2 drm/amd/amdgpu: Change comp GFXv9 ring name to remove space

umr expects the ring name to be a complete word. This also makes it consistent with GFXv7/8.

---
 drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c +1 -1
index 898bc5c3a42b..42cfd3b45390 100644
@@ -1094,7 +1094,7 @@ static int gfx_v9_0_sw_init(void *handle)
 		ring->pipe = i / 8;
 		ring->queue = i % 8;
 		ring->eop_gpu_addr = adev->gfx.mec.hpd_eop_gpu_addr + (i * MEC_HPD_SIZE);
-		sprintf(ring->name, "comp %d.%d.%d", ring->me, ring->pipe, ring->queue);
+		sprintf(ring->name, "comp_%d.%d.%d", ring->me, ring->pipe, ring->queue);
 		irq_type = AMDGPU_CP_IRQ_COMPUTE_MEC1_PIPE0_EOP + ring->pipe;
 		/* type-2 packets are deprecated on MEC, use type-3 instead */
 		r = amdgpu_ring_init(adev, ring, 1024,
Signature · 6 lines
2.12.0

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

A message that is not in the archive (sent off-list or not yet received): [email protected]

Reviewed-by Alex Deucher
#4 lore raw

RE: [PATCH 2/2] drm/amd/amdgpu: Change comp GFXv9 ring name to remove space

Quoted 9 lines

-----Original Message-----
From: amd-gfx [mailto:[email protected]] On Behalf Of Tom St Denis
Sent: Wednesday, April 19, 2017 9:11 AM
To: [email protected]
Cc: StDenis, Tom
Subject: [PATCH 2/2] drm/amd/amdgpu: Change comp GFXv9 ring name to remove space

Quoted 4 lines

umr expects the ring name to be a complete word. This also makes it consistent with GFXv7/8.

Series is:

Quoted 26 lines
---
 drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c +1 -1
index 898bc5c3a42b..42cfd3b45390 100644
@@ -1094,7 +1094,7 @@ static int gfx_v9_0_sw_init(void *handle)
 		ring->pipe = i / 8;
 		ring->queue = i % 8;
 		ring->eop_gpu_addr = adev->gfx.mec.hpd_eop_gpu_addr +
 (i * MEC_HPD_SIZE);
-		sprintf(ring->name, "comp %d.%d.%d", ring->me, ring->pipe,
 ring->queue);
+		sprintf(ring->name, "comp_%d.%d.%d", ring->me, ring-
 >pipe, ring->queue);
drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c +1 -0
 		irq_type = AMDGPU_CP_IRQ_COMPUTE_MEC1_PIPE0_EOP
+ ring->pipe;
 		/* type-2 packets are deprecated on MEC, use type-3 instead

*/
r = amdgpu_ring_init(adev, ring, 1024,
--
2.12.0

Quoted 4 lines

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

Reviewed-by
#5 lore raw
In reply to a message not in the archive

Am 19.04.2017 um 15:10 schrieb Tom St Denis:

Quoted 4 lines

umr expects the ring name to be a complete word. This also makes it consistent with GFXv7/8.

Quoted 9 lines
---
  drivers/gpu/drm/amd/amdgpu/gfx_v6_0.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/amd/amdgpu/gfx_v6_0.c +0 -0
index 625dbfc4f826..f7579dedc577 100644

drivers/gpu/drm/amd/amdgpu/gfx_v6_0.c static int gfx_v6_0_sw_init(void *handle) · line 3298

Quoted 8 lines
drivers/gpu/drm/amd/amdgpu/gfx_v6_0.c +1 -1
@@ -3292,7 +3292,7 @@ static int gfx_v6_0_sw_init(void *handle)
  		ring->me = 1;
  		ring->pipe = i;
  		ring->queue = i;
-		sprintf(ring->name, "comp %d.%d.%d", ring->me, ring->pipe, ring->queue);
+		sprintf(ring->name, "comp_%d.%d.%d", ring->me, ring->pipe, ring->queue);
  		irq_type = AMDGPU_CP_IRQ_COMPUTE_MEC1_PIPE0_EOP + ring->pipe;
  		r = amdgpu_ring_init(adev, ring, 1024,
  				     &adev->gfx.eop_irq, irq_type);

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx