Skip to contentSkip to conversation

drm/amd/amdgpu: Print out ring name in dev_info

PATCH In review Tom St Denis 2 participants 3 messages Apr 19, 2017 2 messages not in the archive

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drm/amd/amdgpu: Print out ring name in dev_info

So it's more obvious which rings are using which INV engines.

---
 drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c +3 -2
index a71521e10763..edf43769ae70 100644
@@ -394,8 +394,9 @@ static int gmc_v9_0_late_init(void *handle)
 		unsigned vmhub = ring->funcs->vmhub;
 
 		ring->vm_inv_eng = vm_inv_eng[vmhub]++;
-		dev_info(adev->dev, "ring %u uses VM inv eng %u on hub %u\n",
-			 ring->idx, ring->vm_inv_eng, ring->funcs->vmhub);
+		dev_info(adev->dev, "ring %u(%s) uses VM inv eng %u on hub %u\n",
+			 ring->idx, ring->name, ring->vm_inv_eng,
+			 ring->funcs->vmhub);
 	}
 
 	/* Engine 17 is used for GART flushes */
Signature · 6 lines
2.12.0

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

A message that is not in the archive (sent off-list or not yet received): [email protected]

#2 lore raw

Am 19.04.2017 um 17:03 schrieb Tom St Denis:

Quoted 3 lines

So it's more obvious which rings are using which INV engines.

I wonder if we shouldn't stop printing the ring numbers completely in the ring and IB tests as well and always use the ring name.

But anyway for now the patch is Reviewed-by: Christian König <[email protected]>.

Regards,
Christian.

Quoted 10 lines
---
  drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c | 5 +++--
  1 file changed, 3 insertions(+), 2 deletions(-)
drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c +0 -0
index a71521e10763..edf43769ae70 100644
@@ -394,8 +394,9 @@ static int gmc_v9_0_late_init(void *handle)
  		unsigned vmhub = ring->funcs->vmhub;

drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c static int gmc_v9_0_late_init(void *handle) · line 402

Quoted 10 lines
drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c +3 -2
 
  		ring->vm_inv_eng = vm_inv_eng[vmhub]++;
-		dev_info(adev->dev, "ring %u uses VM inv eng %u on hub %u\n",
-			 ring->idx, ring->vm_inv_eng, ring->funcs->vmhub);
+		dev_info(adev->dev, "ring %u(%s) uses VM inv eng %u on hub %u\n",
+			 ring->idx, ring->name, ring->vm_inv_eng,
+			 ring->funcs->vmhub);
  	}
 
  	/* Engine 17 is used for GART flushes */

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

A message that is not in the archive (sent off-list or not yet received): 3ed4efbc-09e3-005e-613c-5baa8a5471c1-ANTagKRnAhcb1SvskN2V4Q@public.gmane.org

#4 lore raw
Quoted 8 lines · Christian König

Am 19.04.2017 um 17:03 schrieb Tom St Denis:

Quoted 3 lines

So it's more obvious which rings are using which INV engines.

I wonder if we shouldn't stop printing the ring numbers completely in the ring and IB tests as well and always use the ring name.

But anyway for now the patch is Reviewed-by: Christian König <[email protected]>.

Thanks. I'm not sure if others have built scripts/etc on the ring numbers so for now I was trying not to deviate too far.

umr always refers to rings by their name (e.g. in debugfs) but like having the name in the ip_funcs tables it's just easier to debug if the info has human readable names.

Cheers,
Tom

Quoted 8 lines

Regards,
Christian.

Quoted 4 lines
---
  drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c | 5 +++--
  1 file changed, 3 insertions(+), 2 deletions(-)
Quoted 17 lines
Quoted 5 lines
drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c +0 -0
index a71521e10763..edf43769ae70 100644

drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c static int gmc_v9_0_late_init(void *handle) · line 401

Quoted 10 lines
drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c +3 -2
@@ -394,8 +394,9 @@ static int gmc_v9_0_late_init(void *handle)
          unsigned vmhub = ring->funcs->vmhub;
          ring->vm_inv_eng = vm_inv_eng[vmhub]++;
-        dev_info(adev->dev, "ring %u uses VM inv eng %u on hub %u\n",
-             ring->idx, ring->vm_inv_eng, ring->funcs->vmhub);
+        dev_info(adev->dev, "ring %u(%s) uses VM inv eng %u on hub 
 %u\n",
+             ring->idx, ring->name, ring->vm_inv_eng,
+             ring->funcs->vmhub);
      }
      /* Engine 17 is used for GART flushes */

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx