perf, tools: Fix display of data source snoop indication
PATCH 1/1 perf, tools: Fix display of data source snoop indication
From: Andi Kleen <[email protected]>
perf mem report doesn't display the data source snoop indication correctly.
In the kernel API the definition is
but the table used by the perf tools exchanged Hit and Miss
"None",
"Miss",
"Hit",Fix the table in perf.
--- tools/perf/util/mem-events.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
tools/perf/util/mem-events.c +1 -1
@@ -205,8 +205,8 @@ int perf_mem__lvl_scnprintf(char *out, size_t sz, struct mem_info *mem_info)static const char *const snoop_access[] = {"N/A" ,"None" , -"Miss" ,"Hit" , +"Miss" ,"HitM" , };
Signature · 1 line
2.9.3
Arnaldo Carvalho de Melo
maintainerEm Wed, Apr 19, 2017 at 10:49:40AM -0700, Andi Kleen escreveu:
Quoted 5 lines
From: Andi Kleen <[email protected]>
perf mem report doesn't display the data source snoop indication correctly.
In the kernel API the definition is
missing something?
Quoted 30 lines
but the table used by the perf tools exchanged Hit and Miss
"None", "Miss", "Hit",Fix the table in perf.
Signed-off-by Andi Kleen <[email protected]>--- tools/perf/util/mem-events.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)tools/perf/util/mem-events.c +1
-1@@ -205,8 +205,8 @@ int perf_mem__lvl_scnprintf(char *out, size_t sz, struct mem_info *mem_info)static const char *const snoop_access[] = {"N/A" ,"None" , -"Miss" ,"Hit" , +"Miss" ,"HitM" , };Signature · 1 line
2.9.3
Quoted 8 lines · Arnaldo Carvalho de Melo
Em Wed, Apr 19, 2017 at 10:49:40AM -0700, Andi Kleen escreveu:
Quoted 5 lines
From: Andi Kleen <[email protected]>
perf mem report doesn't display the data source snoop indication correctly.
In the kernel API the definition is
missing something?
#define PERF_MEM_SNOOP_NONE 0x02 /* no snoop */ #define PERF_MEM_SNOOP_HIT 0x04 /* snoop hit */ #define PERF_MEM_SNOOP_MISS 0x08 /* snoop miss */
Quoted 31 lines
Quoted 31 lines
but the table used by the perf tools exchanged Hit and Miss
"None", "Miss", "Hit",Fix the table in perf.
Signed-off-by Andi Kleen <[email protected]>--- tools/perf/util/mem-events.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)tools/perf/util/mem-events.c +1
-1@@ -205,8 +205,8 @@ int perf_mem__lvl_scnprintf(char *out, size_t sz, struct mem_info *mem_info)static const char *const snoop_access[] = {"N/A" ,"None" , -"Miss" ,"Hit" , +"Miss" ,"HitM" , };Signature · 1 line
2.9.3
tip-bot for Andi Kleen
merge bot[tip:perf/core] perf mem: Fix display of data source snoop indication
In reply to Andi Kleenperf mem: Fix display of data source snoop indication
Commit-ID: 166ebdd2442660e7f942d657fc5e629000e58ec3 Gitweb: http://git.kernel.org/tip/166ebdd2442660e7f942d657fc5e629000e58ec3 Author: Andi Kleen <[email protected]> AuthorDate: Wed, 19 Apr 2017 10:49:40 -0700 Committer: Arnaldo Carvalho de Melo <[email protected]> CommitDate: Mon, 24 Apr 2017 12:33:32 -0300
perf mem: Fix display of data source snoop indication
'perf mem report' doesn't display the data source snoop indication correctly.
In the kernel API the definition is:
#define PERF_MEM_SNOOP_NONE 0x02 /* no snoop */ #define PERF_MEM_SNOOP_HIT 0x04 /* snoop hit */ #define PERF_MEM_SNOOP_MISS 0x08 /* snoop miss */
but the table used by the perf tools exchanged "Hit" and "Miss":
"None",
"Miss",
"Hit",Fix the table in perf.
--- tools/perf/util/mem-events.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
tools/perf/util/mem-events.c +1 -1
@@ -206,8 +206,8 @@ int perf_mem__lvl_scnprintf(char *out, size_t sz, struct mem_info *mem_info)static const char *const snoop_access[] = {"N/A" ,"None" , -"Miss" ,"Hit" , +"Miss" ,"HitM" , };