Skip to contentSkip to conversation

perf, tools: Fix display of data source snoop indication

PATCH In review Andi Kleen 2 participants 2 messages Apr 19, 2017 perf events

lore
Share & tools
lore

Andi Kleen

author
#0 lore raw

PATCH 1/1 perf, tools: Fix display of data source snoop indication

From: Andi Kleen <[email protected]>

perf mem report doesn't display the data source snoop indication correctly.

In the kernel API the definition is

but the table used by the perf tools exchanged Hit and Miss

        "None",
        "Miss",
        "Hit",

Fix the table in perf.

---
 tools/perf/util/mem-events.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
tools/perf/util/mem-events.c +1 -1
index 1d4ab53c60ca..865ba3c39284 100644
@@ -205,8 +205,8 @@ int perf_mem__lvl_scnprintf(char *out, size_t sz, struct mem_info *mem_info)
 static const char * const snoop_access[] = {
 	"N/A",
 	"None",
-	"Miss",
 	"Hit",
+	"Miss",
 	"HitM",
 };
 
Signature · 1 line
2.9.3
#1 lore raw

Em Wed, Apr 19, 2017 at 12:53:37PM -0700, Andi Kleen escreveu:

Quoted 5 lines

From: Andi Kleen <[email protected]>

perf mem report doesn't display the data source snoop indication correctly.

In the kernel API the definition is

I fixed this already, prepending the lines starting with # with two spaces, so that it doesn't vanishes one 3rd time 8-)

- Arnaldo

Quoted 30 lines

but the table used by the perf tools exchanged Hit and Miss

        "None",
        "Miss",
        "Hit",

Fix the table in perf.

---
 tools/perf/util/mem-events.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
tools/perf/util/mem-events.c +1 -1
index 1d4ab53c60ca..865ba3c39284 100644
@@ -205,8 +205,8 @@ int perf_mem__lvl_scnprintf(char *out, size_t sz, struct mem_info *mem_info)
 static const char * const snoop_access[] = {
 	"N/A",
 	"None",
-	"Miss",
 	"Hit",
+	"Miss",
 	"HitM",
 };
 
Signature · 1 line
2.9.3