Skip to contentSkip to conversation

rcuperf: refix rcuperf sched_ops definition

PATCH In review Arnd Bergmann 2 participants 2 messages Apr 20, 2017 RCU

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 rcuperf: refix rcuperf sched_ops definition

It looks like my fixup was incorrectly folded into the original patch, and still leaves a duplicated initializer but drops the .sync callback pointer.

This should rectify it, please fold it as well.

Fixes df29028c2a9c ("rcuperf: Add ability to performance-test call_rcu() and friends")
---
 kernel/rcu/rcuperf.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
kernel/rcu/rcuperf.c +1 -1
index 1e2a1424d1f5..5158ddba6716 100644
@@ -308,7 +308,7 @@ static struct rcu_perf_ops sched_ops = {
 	.exp_completed	= rcu_exp_batches_completed_sched,
 	.async		= call_rcu_sched,
 	.gp_barrier	= rcu_barrier_sched,
-	.async		= srcu_call_rcu,
+	.sync		= synchronize_sched,
 	.exp_sync	= synchronize_sched_expedited,
 	.name		= "sched"
 };
Signature · 1 line
2.9.0
#1 lore raw
Quoted 8 lines · Arnd Bergmann

It looks like my fixup was incorrectly folded into the original patch, and still leaves a duplicated initializer but drops the .sync callback pointer.

This should rectify it, please fold it as well.

Fixes df29028c2a9c ("rcuperf: Add ability to performance-test call_rcu() and friends")

I really am not doing well on this commit, am I? :-/

Thank you very much for your attention to detail and for the fixes!!!

Thanx, Paul

Quoted 20 lines
---
 kernel/rcu/rcuperf.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
kernel/rcu/rcuperf.c +1 -1
index 1e2a1424d1f5..5158ddba6716 100644
@@ -308,7 +308,7 @@ static struct rcu_perf_ops sched_ops = {
 	.exp_completed	= rcu_exp_batches_completed_sched,
 	.async		= call_rcu_sched,
 	.gp_barrier	= rcu_barrier_sched,
-	.async		= srcu_call_rcu,
+	.sync		= synchronize_sched,
 	.exp_sync	= synchronize_sched_expedited,
 	.name		= "sched"
 };
Signature · 1 line
2.9.0