Added paranthesis around complex define statements
PATCH 1/1 Added paranthesis around complex define statements
This is a patch to the ks_wlan_ioctl.h file that fixes paranthesis error found by the checkpatch.pl tool
Signed-off-by Andriy Gelman <[email protected]>
--- drivers/staging/ks7010/ks_wlan_ioctl.h | 53 +++++++++++++++++----------------- 1 file changed, 26 insertions(+), 27 deletions(-)
drivers/staging/ks7010/ks_wlan_ioctl.h +26 -27
@@ -1,6 +1,6 @@/* * Driver for KeyStream 11b/g wireless LAN -* +* * Copyright (c) 2005-2008 KeyStream Corp. * Copyright (C) 2009 Renesas Technology Corp. *
@@ -18,38 +18,38 @@/* SIOCIWFIRSTPRIV + 0 */ /* former KS_WLAN_GET_DRIVER_VERSION SIOCIWFIRSTPRIV + 1 */ /* SIOCIWFIRSTPRIV + 2 */ -#define KS_WLAN_GET_FIRM_VERSION SIOCIWFIRSTPRIV + 3 +#define KS_WLAN_GET_FIRM_VERSION (SIOCIWFIRSTPRIV + 3)#ifdef WPS -#define KS_WLAN_SET_WPS_ENABLE SIOCIWFIRSTPRIV + 4 -#define KS_WLAN_GET_WPS_ENABLE SIOCIWFIRSTPRIV + 5 -#define KS_WLAN_SET_WPS_PROBE_REQ SIOCIWFIRSTPRIV + 6 +#define KS_WLAN_SET_WPS_ENABLE (SIOCIWFIRSTPRIV + 4) +#define KS_WLAN_GET_WPS_ENABLE (SIOCIWFIRSTPRIV + 5) +#define KS_WLAN_SET_WPS_PROBE_REQ (SIOCIWFIRSTPRIV + 6)#endif -#define KS_WLAN_GET_EEPROM_CKSUM SIOCIWFIRSTPRIV + 7 -#define KS_WLAN_SET_PREAMBLE SIOCIWFIRSTPRIV + 8 -#define KS_WLAN_GET_PREAMBLE SIOCIWFIRSTPRIV + 9 -#define KS_WLAN_SET_POWER_SAVE SIOCIWFIRSTPRIV + 10 -#define KS_WLAN_GET_POWER_SAVE SIOCIWFIRSTPRIV + 11 -#define KS_WLAN_SET_SCAN_TYPE SIOCIWFIRSTPRIV + 12 -#define KS_WLAN_GET_SCAN_TYPE SIOCIWFIRSTPRIV + 13 -#define KS_WLAN_SET_RX_GAIN SIOCIWFIRSTPRIV + 14 -#define KS_WLAN_GET_RX_GAIN SIOCIWFIRSTPRIV + 15 -#define KS_WLAN_HOSTT SIOCIWFIRSTPRIV + 16/* unused */ +#define KS_WLAN_GET_EEPROM_CKSUM (SIOCIWFIRSTPRIV + 7) +#define KS_WLAN_SET_PREAMBLE (SIOCIWFIRSTPRIV + 8) +#define KS_WLAN_GET_PREAMBLE (SIOCIWFIRSTPRIV + 9) +#define KS_WLAN_SET_POWER_SAVE (SIOCIWFIRSTPRIV + 10) +#define KS_WLAN_GET_POWER_SAVE (SIOCIWFIRSTPRIV + 11) +#define KS_WLAN_SET_SCAN_TYPE (SIOCIWFIRSTPRIV + 12) +#define KS_WLAN_GET_SCAN_TYPE (SIOCIWFIRSTPRIV + 13) +#define KS_WLAN_SET_RX_GAIN (SIOCIWFIRSTPRIV + 14) +#define KS_WLAN_GET_RX_GAIN (SIOCIWFIRSTPRIV + 15) +#define KS_WLAN_HOSTT (SIOCIWFIRSTPRIV + 16)/* unused */ //#define KS_WLAN_SET_REGION SIOCIWFIRSTPRIV + 17 -#define KS_WLAN_SET_BEACON_LOST SIOCIWFIRSTPRIV + 18 -#define KS_WLAN_GET_BEACON_LOST SIOCIWFIRSTPRIV + 19 +#define KS_WLAN_SET_BEACON_LOST (SIOCIWFIRSTPRIV + 18) +#define KS_WLAN_GET_BEACON_LOST (SIOCIWFIRSTPRIV + 19) -#define KS_WLAN_SET_TX_GAIN SIOCIWFIRSTPRIV + 20 -#define KS_WLAN_GET_TX_GAIN SIOCIWFIRSTPRIV + 21 +#define KS_WLAN_SET_TX_GAIN (SIOCIWFIRSTPRIV + 20) +#define KS_WLAN_GET_TX_GAIN (SIOCIWFIRSTPRIV + 21)/* for KS7010 */ -#define KS_WLAN_SET_PHY_TYPE SIOCIWFIRSTPRIV + 22 -#define KS_WLAN_GET_PHY_TYPE SIOCIWFIRSTPRIV + 23 -#define KS_WLAN_SET_CTS_MODE SIOCIWFIRSTPRIV + 24 -#define KS_WLAN_GET_CTS_MODE SIOCIWFIRSTPRIV + 25 +#define KS_WLAN_SET_PHY_TYPE (SIOCIWFIRSTPRIV + 22) +#define KS_WLAN_GET_PHY_TYPE (SIOCIWFIRSTPRIV + 23) +#define KS_WLAN_SET_CTS_MODE (SIOCIWFIRSTPRIV + 24) +#define KS_WLAN_GET_CTS_MODE (SIOCIWFIRSTPRIV + 25)/* SIOCIWFIRSTPRIV + 26 */ /* SIOCIWFIRSTPRIV + 27 */ -#define KS_WLAN_SET_SLEEP_MODE SIOCIWFIRSTPRIV + 28/* sleep mode */ -#define KS_WLAN_GET_SLEEP_MODE SIOCIWFIRSTPRIV + 29/* sleep mode */ +#define KS_WLAN_SET_SLEEP_MODE (SIOCIWFIRSTPRIV + 28)/* sleep mode */ +#define KS_WLAN_GET_SLEEP_MODE (SIOCIWFIRSTPRIV + 29)/* sleep mode */ /* SIOCIWFIRSTPRIV + 30 */ /* SIOCIWFIRSTPRIV + 31 */
@@ -59,8 +59,7 @@#include <linux/netdevice.h> int ks_wlan_read_config_file (struct ks_wlan_private *priv); -int ks_wlan_setup_parameter (struct ks_wlan_private *priv, -unsigned int commit_flag); +int ks_wlan_setup_parameter (struct ks_wlan_private *priv,int commit_flag);#endif /* __KERNEL__ */
Signature · 1 line
2.7.4
Greg KH
maintainerQuoted 2 lines · Andriy Gelman
This is a patch to the
ks_wlan_ioctl.hfile that fixes paranthesis error found by the checkpatch.pl tool
No, it also does other things :(
Also, please fix up the subject to look like other patches done for this file/driver.
And fix the spelling mistake :)
Quoted 11 lines
Signed-off-by Andriy Gelman <[email protected]>--- drivers/staging/ks7010/ks_wlan_ioctl.h | 53 +++++++++++++++++----------------- 1 file changed, 26 insertions(+), 27 deletions(-)drivers/staging/ks7010/ks_wlan_ioctl.h +0
-0
drivers/staging/ks7010/ks_wlan_ioctl.h line 3
Quoted 4 lines
drivers/staging/ks7010/ks_wlan_ioctl.h +1
-1@@ -1,6 +1,6 @@/* * Driver for KeyStream 11b/g wireless LAN -* +*
This is not a () change :(
Please only do one type of thing in each patch.
thanks,
greg k-h