Skip to contentSkip to conversation

platform/x86: INT33FE: add I2C dependency

PATCH In review Arnd Bergmann 2 participants 2 messages Apr 21, 2017 x86 platform drivers

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 platform/x86: INT33FE: add I2C dependency

When I2C is disabled, we get a link error:

drivers/platform/built-in.o: In function `cht_int33fe_remove':
intel_cht_int33fe.c:(.text+0x8ba): undefined reference to i2c_unregister_device' drivers/platform/built-in.o: In function cht_int33fe_probe':
intel_cht_int33fe.c:(.text+0x9ec): undefined reference to i2c_acpi_new_device' intel_cht_int33fe.c:(.text+0xa7a): undefined reference to i2c_unregister_device'

This adds a Kconfig dependency to ensure I2C is available to this driver.

Fixes 1cd706df8a9c ("platform/x86: Add Intel Cherry Trail ACPI INT33FE device driver")
---
 drivers/platform/x86/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/platform/x86/Kconfig +1 -1
index 76ced87efde5..4c7db1fbac26 100644
@@ -782,7 +782,7 @@ config ACPI_CMPC
 
 config INTEL_CHT_INT33FE
 	tristate "Intel Cherry Trail ACPI INT33FE Driver"
-	depends on X86 && ACPI
+	depends on X86 && ACPI && I2C
 	---help---
 	  This driver add support for the INT33FE ACPI device found on
 	  some Intel Cherry Trail devices.
Signature · 1 line
2.9.0
#1 lore raw
Quoted 8 lines · Arnd Bergmann

When I2C is disabled, we get a link error:

drivers/platform/built-in.o: In function `cht_int33fe_remove':
intel_cht_int33fe.c:(.text+0x8ba): undefined reference to i2c_unregister_device' drivers/platform/built-in.o: In function cht_int33fe_probe':
intel_cht_int33fe.c:(.text+0x9ec): undefined reference to i2c_acpi_new_device' intel_cht_int33fe.c:(.text+0xa7a): undefined reference to i2c_unregister_device'

Quoted 5 lines

This adds a Kconfig dependency to ensure I2C is available to this driver.

Fixes 1cd706df8a9c ("platform/x86: Add Intel Cherry Trail ACPI INT33FE device driver")

Thanks Arnd, Tobias submitted a fix a short time ago, it'll be in next tomorrow. Thanks!

Signature · 2 lines
Darren Hart
VMware Open Source Technology Center