Skip to contentSkip to conversation

security: hooks : Prevent security to persist in memory (PR #31)

PATCH In review Pirabarlen-Cheenaramen 2 participants 2 messages Apr 23, 2017 – Apr 25, 2017 SELinux security module

lore
Share & tools
lore

Pirabarlen-Cheenaramen

author
#0 lore raw

PATCH 1/1 security: hooks : Prevent security to persist in memory (PR #31)

Signed-off-by Pirabarlen-Cheenaramen <[email protected]>
---
 security/selinux/hooks.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
security/selinux/hooks.c +1 -1
index d98550a..9f82908 100644
@@ -4944,7 +4944,7 @@ static int selinux_tun_dev_alloc_security(void **security)
 
 static void selinux_tun_dev_free_security(void *security)
 {
-	kfree(security);
+	kzfree(security);
 }
 
 static int selinux_tun_dev_create(void)
Signature · 1 line
1.9.1
maintainer
#1 lore raw
Quoted 10 lines · Pirabarlen-Cheenaramen
Signed-off-by Pirabarlen-Cheenaramen <[email protected]>
---
 security/selinux/hooks.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
security/selinux/hooks.c +0 -0
index d98550a..9f82908 100644

security/selinux/hooks.c static int selinux_tun_dev_alloc_security(void **security) · line 4947

Quoted 5 lines
security/selinux/hooks.c +1 -1
@@ -4944,7 +4944,7 @@ static int selinux_tun_dev_alloc_security(void **security)
 
 static void selinux_tun_dev_free_security(void *security)
 {
-       kfree(security);
+       kzfree(security);

As a general rule we don't zero out memory before free'ing it, you need to provide some additional information as to why this is required here.

Quoted 5 lines
security/selinux/hooks.c +0 -1
 }
 
 static int selinux_tun_dev_create(void)
--

1.9.1

Signature · 2 lines
paul moore
www.paul-moore.com