package/kodi: fix path to binary
PATCH v2 1/1 package/kodi: fix path to binary
Since XBMC was renamed to Kodi, upstream is progressively propagating the rename to directories and files, and in some cases kept a legacy symlink xbmc->kodi, like /usr/lib/xbmc pointing to /usr/lib/kodi.
In 62165ae (package/kodi: Fix path to binary in service), the path was changed to use the new canonical path, but the init script was left out. This was not seen previously, because of the legacy symlink.
But with the advent of Kodi 17 (Krypton), that legacy symlink is no more, and the init script no longer works.
Do for the init script what was done two years ago for the service file.
---
Changes v1 -> v2:
- typoes (Marcus)
--- package/kodi/S50kodi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
package/kodi/S50kodi +1 -1
@@ -4,7 +4,7 @@ # BIN=/usr/bin/br-kodi -KODI=/usr/lib/xbmc/kodi.bin +KODI=/usr/lib/kodi/kodi.bin KODI_ARGS="--standalone -fs -n" PIDFILE=/var/run/kodi.pid
Signature · 1 line
2.11.0
PATCH v2 1/1 package/kodi: fix path to binary
Am Sun, 23 Apr 2017 08:47:08 +0200 schrieb Yann E. MORIN:
Quoted 1 line
Do for the init script what was done two years ago for the service file.
PATCH v2 1/1 package/kodi: fix path to binary
Bernd, All,
On 2017-04-23 09:03 +0200, Bernd Kuhls spake thusly:
Quoted 3 lines
Am Sun, 23 Apr 2017 08:47:08 +0200 schrieb Yann E. MORIN:
Quoted 1 line
Do for the init script what was done two years ago for the service file.
Reviewed-by Bernd Kuhls <[email protected]>
Thanks!
I just saw that you had already reviewed the previous iteration. But because you do not Cc the author when replying, I missed it.
Could you, please, follow the usual practice that we follow on this mailing list (and the usual practice followed about everywhere on every mailing lists) to reply by mail with the author and the list as recipient, please?
Regards,
Yann E. MORIN.
Signature · 6 lines
.-----------------.--------------------.------------------.--------------------. | Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: | | +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ | | +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no | | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. | '------------------------------^-------^------------------^--------------------'
Thomas Petazzoni
AppliedPATCH v2 1/1 package/kodi: fix path to binary
In reply to Yann E. MORINHello,
Quoted 18 lines · Yann E. MORIN
Since XBMC was renamed to Kodi, upstream is progressively propagating the rename to directories and files, and in some cases kept a legacy symlink
xbmc->kodi, like/usr/lib/xbmcpointing to/usr/lib/kodi.In 62165ae (package/kodi: Fix path to binary in service), the path was changed to use the new canonical path, but the init script was left out. This was not seen previously, because of the legacy symlink.
But with the advent of Kodi 17 (Krypton), that legacy symlink is no more, and the init script no longer works.
Do for the init script what was done two years ago for the service file.
Signed-off-by "Yann E. MORIN" <[email protected]>Cc Maxime Hadjinlian <[email protected]>Cc Bernd Kuhls <[email protected]>Cc Marcus Hoffmann <[email protected]>
Quoted 6 lines
---
Changes v1 -> v2:
- typoes (Marcus)--- package/kodi/S50kodi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Applied to master, thanks.
Thomas
Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com