Skip to contentSkip to conversation

arm: dts: imx: add aliases for usbotg nodes

PATCH In review Alexey Ignatov 4 participants 7 messages Apr 24, 2017 – May 18, 2017

Subsystems (2)
Arm (32-bit) Arm i.MX and Layerscape
lore
Share & tools
lore

Alexey Ignatov

author
#0 lore raw

PATCH 1/1 arm: dts: imx: add aliases for usbotg nodes

Aliases must be present for USB gadget with DM_USB. Without this, usb_setup_ehci_gadget() fails because it can't find required devices in UCLASS_USB.

Signed-off-by Alexey Ignatov <[email protected]>
---
 arch/arm/dts/imx6qdl.dtsi | 1 +
 arch/arm/dts/imx6sll.dtsi | 2 ++
 arch/arm/dts/imx6sx.dtsi  | 2 ++
 arch/arm/dts/imx6ul.dtsi  | 2 ++
 arch/arm/dts/imx6ull.dtsi | 2 ++
 5 files changed, 9 insertions(+)
arch/arm/dts/imx6qdl.dtsi +1 -0
index b13b0b2db8..1253d14b18 100644
@@ -46,6 +46,7 @@
 		spi3 = &ecspi4;
 		usbphy0 = &usbphy1;
 		usbphy1 = &usbphy2;
+		usb0 = &usbotg1;
 	};
 
 	clocks {
arch/arm/dts/imx6sll.dtsi +2 -0
index 349c47a03a..95c04edfb7 100644
@@ -37,6 +37,8 @@
 		spi4 = &ecspi4;
 		usbphy0 = &usbphy1;
 		usbphy1 = &usbphy2;
+		usb0 = &usbotg1;
+		usb1 = &usbotg2;
 	};
 
 	cpus {
arch/arm/dts/imx6sx.dtsi +2 -0
index 1a473e83ef..99e8f0a4df 100644
@@ -47,6 +47,8 @@
 		spi4 = &ecspi5;
 		usbphy0 = &usbphy1;
 		usbphy1 = &usbphy2;
+		usb0 = &usbotg1;
+		usb1 = &usbotg2;
 	};
 
 	cpus {
arch/arm/dts/imx6ul.dtsi +2 -0
index c5c05fdccc..0b27ba85a0 100644
@@ -45,6 +45,8 @@
 		spi3 = &ecspi4;
 		usbphy0 = &usbphy1;
 		usbphy1 = &usbphy2;
+		usb0 = &usbotg1;
+		usb1 = &usbotg2;
 	};
 
 	cpus {
arch/arm/dts/imx6ull.dtsi +2 -0
index 65950e8019..61ce305428 100644
@@ -44,6 +44,8 @@
 		spi3 = &ecspi4;
 		usbphy0 = &usbphy1;
 		usbphy1 = &usbphy2;
+		usb0 = &usbotg1;
+		usb1 = &usbotg2;
 	};
 
 	cpus {
Signature · 1 line
2.12.2
#1 lore raw
Quoted 69 lines · Alexey Ignatov

Aliases must be present for USB gadget with DM_USB. Without this, usb_setup_ehci_gadget() fails because it can't find required devices in UCLASS_USB.

Signed-off-by Alexey Ignatov <[email protected]>
---
 arch/arm/dts/imx6qdl.dtsi | 1 +
 arch/arm/dts/imx6sll.dtsi | 2 ++
 arch/arm/dts/imx6sx.dtsi  | 2 ++
 arch/arm/dts/imx6ul.dtsi  | 2 ++
 arch/arm/dts/imx6ull.dtsi | 2 ++
 5 files changed, 9 insertions(+)
arch/arm/dts/imx6qdl.dtsi +1 -0
index b13b0b2db8..1253d14b18 100644
@@ -46,6 +46,7 @@
 		spi3 = &ecspi4;
 		usbphy0 = &usbphy1;
 		usbphy1 = &usbphy2;
+		usb0 = &usbotg1;
 	};
 
 	clocks {
arch/arm/dts/imx6sll.dtsi +2 -0
index 349c47a03a..95c04edfb7 100644
@@ -37,6 +37,8 @@
 		spi4 = &ecspi4;
 		usbphy0 = &usbphy1;
 		usbphy1 = &usbphy2;
+		usb0 = &usbotg1;
+		usb1 = &usbotg2;
 	};
 
 	cpus {
arch/arm/dts/imx6sx.dtsi +2 -0
index 1a473e83ef..99e8f0a4df 100644
@@ -47,6 +47,8 @@
 		spi4 = &ecspi5;
 		usbphy0 = &usbphy1;
 		usbphy1 = &usbphy2;
+		usb0 = &usbotg1;
+		usb1 = &usbotg2;
 	};
 
 	cpus {
arch/arm/dts/imx6ul.dtsi +2 -0
index c5c05fdccc..0b27ba85a0 100644
@@ -45,6 +45,8 @@
 		spi3 = &ecspi4;
 		usbphy0 = &usbphy1;
 		usbphy1 = &usbphy2;
+		usb0 = &usbotg1;
+		usb1 = &usbotg2;
 	};
 
 	cpus {
arch/arm/dts/imx6ull.dtsi +0 -0
index 65950e8019..61ce305428 100644

arch/arm/dts/imx6ull.dtsi line 51

Quoted 8 lines
arch/arm/dts/imx6ull.dtsi +2 -0
@@ -44,6 +44,8 @@
 		spi3 = &ecspi4;
 		usbphy0 = &usbphy1;
 		usbphy1 = &usbphy2;
+		usb0 = &usbotg1;
+		usb1 = &usbotg2;
 	};
 
 	cpus {

Do these come from the Linux dtsi file or are being pushed there? If not, you need to put it in the -u-boot.dtsi file (but really see about pushing it upstream). Thanks!

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20170426/d84847c3/attachment.sig>
#2 lore raw

PATCH 1/1 arm: dts: imx: add aliases for usbotg nodes

In reply to Alexey Ignatov

Hi,

Quoted 10 lines · Alexey Ignatov

Aliases must be present for USB gadget with DM_USB. Without this, usb_setup_ehci_gadget() fails because it can't find required devices in UCLASS_USB.

Signed-off-by Alexey Ignatov <[email protected]>
---
 arch/arm/dts/imx6qdl.dtsi | 1 +
 arch/arm/dts/imx6sll.dtsi | 2 ++
 arch/arm/dts/imx6sx.dtsi  | 2 ++
 arch/arm/dts/imx6ul.dtsi  | 2 ++

...

Quoted 7 lines
(quoted diff) +0 -0
 	cpus {
arch/arm/dts/imx6ul.dtsi +0 -0
index c5c05fdccc..0b27ba85a0 100644

arch/arm/dts/imx6ul.dtsi line 52

Quoted 8 lines
arch/arm/dts/imx6ul.dtsi +2 -0
@@ -45,6 +45,8 @@
 		spi3 = &ecspi4;
 		usbphy0 = &usbphy1;
 		usbphy1 = &usbphy2;
+		usb0 = &usbotg1;
+		usb1 = &usbotg2;
 	};
 
 	cpus {

The imx6ul.dtsi file already has usbotg{0,1} aliases.

http://git.denx.de/?p=u-boot.git;a=commit;h=b3cab814232d3b5e165c09ffad4af5b71bde15f3

Regards,

Signature · 5 lines
Sébastien Szymanski
Software Engineer, Armadeus Systems
sebastien.szymanski at armadeus.com
Tel: +33 (0)9 72 29 41 44
Fax: +33 (0)9 72 28 79 26
#3 lore raw

PATCH 1/1 arm: dts: imx: add aliases for usbotg nodes

In reply to Alexey Ignatov
Quoted 6 lines · Alexey Ignatov

Aliases must be present for USB gadget with DM_USB. Without this, usb_setup_ehci_gadget() fails because it can't find required devices in UCLASS_USB.

Signed-off-by Alexey Ignatov <[email protected]>

---

Applied to u-boot-imx, thanks !

Best regards,
Stefano Babic

Signature · 5 lines
=====================================================================
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================
#4 lore raw

PATCH 1/1 arm: dts: imx: add aliases for usbotg nodes

Quoted 11 lines · Stefano Babic
Quoted 6 lines · Alexey Ignatov

Aliases must be present for USB gadget with DM_USB. Without this, usb_setup_ehci_gadget() fails because it can't find required devices in UCLASS_USB.

Signed-off-by Alexey Ignatov <[email protected]>

---

Applied to u-boot-imx, thanks !

Sorry, I cannot. This patch is breaking several boards with "Reference to non-existent node or label "usbotg1"" when DTS is compiled:

opos6uldev
mx6sllevk_plugin
mx6slevk_spinor
imx6qdl_icore_rqs_mmc
...

Can you check this, please ?

Best regards,
Stefano Babic

Signature · 5 lines
=====================================================================
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================
#5 lore raw

PATCH 1/1 arm: dts: imx: add aliases for usbotg nodes

Hi,

Quoted 13 lines · Stefano Babic
Quoted 11 lines · Stefano Babic
Quoted 6 lines · Alexey Ignatov

Aliases must be present for USB gadget with DM_USB. Without this, usb_setup_ehci_gadget() fails because it can't find required devices in UCLASS_USB.

Signed-off-by Alexey Ignatov <[email protected]>

---

Applied to u-boot-imx, thanks !

Quoted 9 lines

Sorry, I cannot. This patch is breaking several boards with "Reference to non-existent node or label "usbotg1"" when DTS is compiled:

opos6uldev
mx6sllevk_plugin
mx6slevk_spinor
imx6qdl_icore_rqs_mmc
...

It looks like my comment has been missed.
The imx6ul.dtsi file already has usbotg{0,1} aliases.

Regards,

Quoted 7 lines

Can you check this, please ?

Best regards,
Stefano Babic

Signature · 5 lines
Sébastien Szymanski
Software Engineer, Armadeus Systems
sebastien.szymanski at armadeus.com
Tel: +33 (0)9 72 29 41 44
Fax: +33 (0)9 72 28 79 26
#6 lore raw

PATCH 1/1 arm: dts: imx: add aliases for usbotg nodes

Quoted 26 lines · Sébastien Szymanski

Hi,

Quoted 13 lines · Stefano Babic
Quoted 11 lines · Stefano Babic
Quoted 6 lines · Alexey Ignatov

Aliases must be present for USB gadget with DM_USB. Without this, usb_setup_ehci_gadget() fails because it can't find required devices in UCLASS_USB.

Signed-off-by Alexey Ignatov <[email protected]>

---

Applied to u-boot-imx, thanks !

Quoted 9 lines

Sorry, I cannot. This patch is breaking several boards with "Reference to non-existent node or label "usbotg1"" when DTS is compiled:

opos6uldev
mx6sllevk_plugin
mx6slevk_spinor
imx6qdl_icore_rqs_mmc
...

Quoted 2 lines

It looks like my comment has been missed.
The imx6ul.dtsi file already has usbotg{0,1} aliases.

Yes, sorry, I have missed them. Thanks for pointing me in the right direction.

Regards,
Stefano

Signature · 5 lines
=====================================================================
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================