Skip to contentSkip to conversation

selftests/net: Fix broken test case in psock_fanout

PATCH Applied Mike Maloney 2 participants 2 messages Apr 25, 2017

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 selftests/net: Fix broken test case in psock_fanout

From: Mike Maloney <[email protected]>

The error return falue form sock_fanout_open is -1, not zero. One test case was checking for 0 instead of -1.

Tested: Built and tested in clean client.

---
 tools/testing/selftests/net/psock_fanout.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
tools/testing/selftests/net/psock_fanout.c +1 -1
index b4b1d91fcea5..989f917068d1 100644
@@ -305,7 +305,7 @@ static void test_unique_fanout_group_ids(void)
 		exit(1);
 	}
 
-	if (sock_fanout_open(PACKET_FANOUT_CPU, first_group_id)) {
+	if (sock_fanout_open(PACKET_FANOUT_CPU, first_group_id) != -1) {
 		fprintf(stderr, "ERROR: joined group with wrong type.\n");
 		exit(1);
 	}
Signature · 1 line
2.13.0.rc0.306.g87b477812d-goog