Skip to contentSkip to conversation

firmware: google memconsole: Fix return value check in platform_memconsole_init()

PATCH New Wei Yongjun 1 participant 1 message Apr 25, 2017

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 firmware: google memconsole: Fix return value check in platform_memconsole_init()

From: Wei Yongjun <[email protected]>

In case of error, the function platform_device_register_simple() returns ERR_PTR() and never returns NULL. The NULL test in the return value check should be replaced with IS_ERR().

Fixes d384d6f43d1e ("firmware: google memconsole: Add coreboot support")
---
 drivers/firmware/google/memconsole-coreboot.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/firmware/google/memconsole-coreboot.c +2 -2
index 2121014..0271111 100644
@@ -95,8 +95,8 @@ static int __init platform_memconsole_init(void)
 	struct platform_device *pdev;
 
 	pdev = platform_device_register_simple("memconsole", -1, NULL, 0);
-	if (pdev == NULL)
-		return -ENODEV;
+	if (IS_ERR(pdev))
+		return PTR_ERR(pdev);
 
 	platform_driver_register(&memconsole_driver);