Skip to contentSkip to conversation

staging: gdm724x: gdm_mux: fix use-after-free on module unload

PATCH New Johan Hovold 1 participant 1 message Apr 26, 2017

Subsystems (2)
Stable branch Staging
lore
Share & tools
lore

Johan Hovold

author
#0 lore raw

PATCH 1/1 staging: gdm724x: gdm_mux: fix use-after-free on module unload

Make sure to deregister the USB driver before releasing the tty driver to avoid use-after-free in the USB disconnect callback where the tty devices are deregistered.

Fixes 61e121047645 ("staging: gdm7240: adding LTE USB driver")
Cc stable <[email protected]> # 3.12
Cc Won Kang <[email protected]>
Signed-off-by Johan Hovold <[email protected]>
---
 drivers/staging/gdm724x/gdm_mux.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
drivers/staging/gdm724x/gdm_mux.c +1 -2
index 400969170d1c..f03e43b1b5f6 100644
@@ -664,9 +664,8 @@ static int __init gdm_usb_mux_init(void)
 
 static void __exit gdm_usb_mux_exit(void)
 {
-	unregister_lte_tty_driver();
-
 	usb_deregister(&gdm_mux_driver);
+	unregister_lte_tty_driver();
 }
 
 module_init(gdm_usb_mux_init);
Signature · 1 line
2.12.2