Skip to contentSkip to conversation

serial: ifx6x60: fix use-after-free on module unload

PATCH New Johan Hovold 1 participant 1 message Apr 26, 2017

Subsystems (2)
Stable branch TTY layer and serial drivers
lore
Share & tools
lore

Johan Hovold

author
#0 lore raw

PATCH 1/1 serial: ifx6x60: fix use-after-free on module unload

Make sure to deregister the SPI driver before releasing the tty driver to avoid use-after-free in the SPI remove callback where the tty devices are deregistered.

Fixes 72d4724ea54c ("serial: ifx6x60: Add modem power off function in the platform reboot process")
Cc stable <[email protected]> # 3.8
Cc Jun Chen <[email protected]>
Signed-off-by Johan Hovold <[email protected]>
---
 drivers/tty/serial/ifx6x60.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/tty/serial/ifx6x60.c +1 -1
index 157883653256..f190a84a0246 100644
@@ -1382,9 +1382,9 @@ static struct spi_driver ifx_spi_driver = {
 static void __exit ifx_spi_exit(void)
 {
 	/* unregister */
+	spi_unregister_driver(&ifx_spi_driver);
 	tty_unregister_driver(tty_drv);
 	put_tty_driver(tty_drv);
-	spi_unregister_driver(&ifx_spi_driver);
 	unregister_reboot_notifier(&ifx_modem_reboot_notifier_block);
 }
Signature · 1 line
2.12.2