Skip to contentSkip to conversation

Staging: most: use __func__ instead of the function name

PATCH Superseded Chandra Annamaneni 2 participants 3 messages Apr 26, 2017

Subsystems (2)

v4 of 5 Superseded Latest is v5 →

lore
Share & tools
lore
#0 lore raw

PATCH v4 1/1 Staging: most: use __func__ instead of the function name

Change video.c to use %s, __func__ instead of function names. Warnings flagged by checkpatch.pl

drivers/staging/most/aim-v4l2/video.c +6 -6
index 59e861e..e074841 100644
@@ -79,7 +79,7 @@ static int aim_vdev_open(struct file *filp)
 	struct most_video_dev *mdev = video_drvdata(filp);
 	struct aim_fh *fh;
 
-	v4l2_info(&mdev->v4l2_dev, "%s()\n", __func__);
+	v4l2_info(&mdev->v4l2_dev, "aim_vdev_open()\n");
 
 	switch (vdev->vfl_type) {
 	case VFL_TYPE_GRABBER:
@@ -128,7 +128,7 @@ static int aim_vdev_close(struct file *filp)
 	struct most_video_dev *mdev = fh->mdev;
 	struct mbo *mbo, *tmp;
 
-	v4l2_info(&mdev->v4l2_dev, "%s()\n", __func__);
+	v4l2_info(&mdev->v4l2_dev, "aim_vdev_close()\n");
 
 	/*
 	 * We need to put MBOs back before we call most_stop_channel()
@@ -324,7 +324,7 @@ static int vidioc_g_std(struct file *file, void *priv, v4l2_std_id *norm)
 	struct aim_fh *fh = priv;
 	struct most_video_dev *mdev = fh->mdev;
 
-	v4l2_info(&mdev->v4l2_dev, "%s()\n", __func__);
+	v4l2_info(&mdev->v4l2_dev, "vidioc_g_std()\n");
 
 	*norm = V4L2_STD_UNKNOWN;
 	return 0;
@@ -361,7 +361,7 @@ static int vidioc_s_input(struct file *file, void *priv, unsigned int index)
 	struct aim_fh *fh = priv;
 	struct most_video_dev *mdev = fh->mdev;
 
-	v4l2_info(&mdev->v4l2_dev, "%s(%d)\n", __func__, index);
+	v4l2_info(&mdev->v4l2_dev, "vidioc_s_input(%d)\n", index);
 
 	if (index >= V4L2_AIM_MAX_INPUT)
 		return -EINVAL;
@@ -441,7 +441,7 @@ static int aim_register_videodev(struct most_video_dev *mdev)
 {
 	int ret;
 
-	v4l2_info(&mdev->v4l2_dev, "%s()\n", __func__);
+	v4l2_info(&mdev->v4l2_dev, "aim_register_videodev()\n");
 
 	init_waitqueue_head(&mdev->wait_data);
 
@@ -471,7 +471,7 @@ static int aim_register_videodev(struct most_video_dev *mdev)
 
 static void aim_unregister_videodev(struct most_video_dev *mdev)
 {
-	v4l2_info(&mdev->v4l2_dev, "%s()\n", __func__);
+	v4l2_info(&mdev->v4l2_dev, "aim_unregister_videodev()\n");
 
 	video_unregister_device(mdev->vdev);
 }
#1 lore raw
Quoted 11 lines · Chandra Annamaneni

Change video.c to use %s, __func__ instead of function names. Warnings flagged by checkpatch.pl

drivers/staging/most/aim-v4l2/video.c +0 -0
index 59e861e..e074841 100644

drivers/staging/most/aim-v4l2/video.c static int aim_vdev_open(struct file *filp) · line 82

Quoted 5 lines
drivers/staging/most/aim-v4l2/video.c +1 -1
@@ -79,7 +79,7 @@ static int aim_vdev_open(struct file *filp)
 	struct most_video_dev *mdev = video_drvdata(filp);
 	struct aim_fh *fh;
 
-	v4l2_info(&mdev->v4l2_dev, "%s()\n", __func__);
+	v4l2_info(&mdev->v4l2_dev, "aim_vdev_open()\n");

You sent the reversed patch.

regards,
dan carpenter

#2 lore raw

Sorry!
And thanks for pointing it out.

regards
Chandra

Quoted 24 lines · Dan Carpenter
Quoted 11 lines · Chandra Annamaneni

Change video.c to use %s, __func__ instead of function names. Warnings flagged by checkpatch.pl

drivers/staging/most/aim-v4l2/video.c +0 -0
index 59e861e..e074841 100644

drivers/staging/most/aim-v4l2/video.c static int aim_vdev_open(struct file *filp) · line 82

Quoted 5 lines
drivers/staging/most/aim-v4l2/video.c +1 -1
@@ -79,7 +79,7 @@ static int aim_vdev_open(struct file *filp)
 	struct most_video_dev *mdev = video_drvdata(filp);
 	struct aim_fh *fh;
 
-	v4l2_info(&mdev->v4l2_dev, "%s()\n", __func__);
+	v4l2_info(&mdev->v4l2_dev, "aim_vdev_open()\n");

You sent the reversed patch.

regards,
dan carpenter