gpio: f7188x: Add a missing break

PATCH In review Dan Carpenter 3 participants 3 messages Apr 26, 2017 – Apr 30, 2017

Subsystems (2)

Kernel janitors GPIO

lore

Share & tools

lore

Dan Carpenter

author

2017-04-26 19:08 UTC #0 lore raw

PATCH 1/1 gpio: f7188x: Add a missing break

A break statement was obviously intended here.

Fixes d69843e416d3 ("gpio: f7188x: Add F71889A GPIO support.")

Signed-off-by Dan Carpenter <[email protected]>

drivers/gpio/gpio-f7188x.c +1 -0

index c013ff5deb70..13350c9d7f5e 100644
@@ -398,6 +398,7 @@ static int f7188x_gpio_probe(struct platform_device *pdev)
 	case f71889a:
 		data->nr_bank = ARRAY_SIZE(f71889a_gpio_bank);
 		data->bank = f71889a_gpio_bank;
+		break;
 	case f71889f:
 		data->nr_bank = ARRAY_SIZE(f71889_gpio_bank);
 		data->bank = f71889_gpio_bank;

Linus Walleij

2017-04-28 08:09 UTC #1 lore raw

Quoted 4 lines · Dan Carpenter

A break statement was obviously intended here.
Fixes d69843e416d3 ("gpio: f7188x: Add F71889A GPIO support.")
Signed-off-by Dan Carpenter <[email protected]>

Patch applied.

Yours,
Linus Walleij

Marty Plummer

2017-04-30 23:42 UTC #2 lore raw

Quoted 11 lines · Linus Walleij

Quoted 4 lines · Dan Carpenter
A break statement was obviously intended here.
Fixes d69843e416d3 ("gpio: f7188x: Add F71889A GPIO support.")
Signed-off-by Dan Carpenter <[email protected]>
Patch applied.
Yours,
Linus Walleij

How embarrassing, I completely missed that. Good catch.

Marty.