Skip to contentSkip to conversation

drm/vmwgfx: Handle vmalloc() failure in vmw_local_fifo_reserve()

PATCH In review Dan Carpenter 2 participants 2 messages Apr 27, 2017 – May 1, 2017

Subsystems (4)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drm/vmwgfx: Handle vmalloc() failure in vmw_local_fifo_reserve()

If vmalloc() fails then we need to a bit of cleanup before returning.

Fixes fb1d9738ca05 ("drm/vmwgfx: Add DRM driver for VMware Virtual GPU")
drivers/gpu/drm/vmwgfx/vmwgfx_fifo.c +2 -0
index b6a0806b06bf..a1c68e6a689e 100644
@@ -368,6 +368,8 @@ static void *vmw_local_fifo_reserve(struct vmw_private *dev_priv,
 				return fifo_state->static_buffer;
 			else {
 				fifo_state->dynamic_buffer = vmalloc(bytes);
+				if (!fifo_state->dynamic_buffer)
+					goto out_err;
 				return fifo_state->dynamic_buffer;
 			}
 		}
Reviewed-by on v1 1/1
#1 lore raw

Thanks Dan!

Quoted 18 lines · Dan Carpenter

If vmalloc() fails then we need to a bit of cleanup before returning.

Fixes fb1d9738ca05 ("drm/vmwgfx: Add DRM driver for VMware Virtual GPU")
drivers/gpu/drm/vmwgfx/vmwgfx_fifo.c +2 -0
index b6a0806b06bf..a1c68e6a689e 100644
@@ -368,6 +368,8 @@ static void *vmw_local_fifo_reserve(struct vmw_private *dev_priv,
 				return fifo_state->static_buffer;
 			else {
 				fifo_state->dynamic_buffer = vmalloc(bytes);
+				if (!fifo_state->dynamic_buffer)
+					goto out_err;
 				return fifo_state->dynamic_buffer;
 			}
 		}