watchdog: bcm281xx: Fix use of uninitialized spinlock.
PATCH 1/1 watchdog: bcm281xx: Fix use of uninitialized spinlock.
The bcm_kona_wdt_set_resolution_reg() call takes the spinlock, so initialize it earlier. Fixes a warning at boot with lock debugging enabled.
Signed-off-by Eric Anholt <[email protected]>
--- drivers/watchdog/bcm_kona_wdt.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/watchdog/bcm_kona_wdt.c +2 -1
@@ -304,6 +304,8 @@ static int bcm_kona_wdt_probe(struct platform_device *pdev)if (!wdt)return -ENOMEM ; +spin_lock_init (&wdt->lock); + res =platform_get_resource (pdev,IORESOURCE_MEM ,0 ); wdt->base =devm_ioremap_resource (dev, res);if (IS_ERR (wdt->base))
@@ -316,7 +318,6 @@ static int bcm_kona_wdt_probe(struct platform_device *pdev)return ret; } -spin_lock_init (&wdt->lock);platform_set_drvdata (pdev, wdt);watchdog_set_drvdata (&bcm_kona_wdt_wdd, wdt); bcm_kona_wdt_wdd.parent = &pdev->dev;
Signature · 1 line
2.11.0
Quoted 5 lines · Eric Anholt
The
bcm_kona_wdt_set_resolution_reg()call takes the spinlock, so initialize it earlier. Fixes a warning at boot with lock debugging enabled.Signed-off-by Eric Anholt <[email protected]>
Fixes 6adb730dc208 ("watchdog: bcm281xx: Watchdog Driver")
Reviewed-by Florian Fainelli <[email protected]>
Quoted 26 lines
--- drivers/watchdog/bcm_kona_wdt.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)drivers/watchdog/bcm_kona_wdt.c +2
-1@@ -304,6 +304,8 @@ static int bcm_kona_wdt_probe(struct platform_device *pdev)if (!wdt)return -ENOMEM ; +spin_lock_init (&wdt->lock); + res =platform_get_resource (pdev,IORESOURCE_MEM ,0 ); wdt->base =devm_ioremap_resource (dev, res);if (IS_ERR (wdt->base))@@ -316,7 +318,6 @@ static int bcm_kona_wdt_probe(struct platform_device *pdev)return ret; } -spin_lock_init (&wdt->lock);platform_set_drvdata (pdev, wdt);watchdog_set_drvdata (&bcm_kona_wdt_wdd, wdt); bcm_kona_wdt_wdd.parent = &pdev->dev;
Signature · 1 line
Florian
Quoted 5 lines · Eric Anholt
The
bcm_kona_wdt_set_resolution_reg()call takes the spinlock, so initialize it earlier. Fixes a warning at boot with lock debugging enabled.Signed-off-by Eric Anholt <[email protected]>
Reviewed-by Guenter Roeck <[email protected]>
Quoted 26 lines
--- drivers/watchdog/bcm_kona_wdt.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)drivers/watchdog/bcm_kona_wdt.c +2
-1@@ -304,6 +304,8 @@ static int bcm_kona_wdt_probe(struct platform_device *pdev)if (!wdt)return -ENOMEM ; +spin_lock_init (&wdt->lock); + res =platform_get_resource (pdev,IORESOURCE_MEM ,0 ); wdt->base =devm_ioremap_resource (dev, res);if (IS_ERR (wdt->base))@@ -316,7 +318,6 @@ static int bcm_kona_wdt_probe(struct platform_device *pdev)return ret; } -spin_lock_init (&wdt->lock);platform_set_drvdata (pdev, wdt);watchdog_set_drvdata (&bcm_kona_wdt_wdd, wdt); bcm_kona_wdt_wdd.parent = &pdev->dev;