Skip to contentSkip to conversation

staging: fbtft: fbtft-core.c: EXPORT_SYMBOL should immediately follow its function

PATCH In review Shiva Kerdel 2 participants 2 messages Apr 29, 2017

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 staging: fbtft: fbtft-core.c: EXPORT_SYMBOL should immediately follow its function

This patch fixes the following checkpatch.pl warning
- EXPORT_SYMBOL(foo); should immediately follow its function/variable

---
 drivers/staging/fbtft/fbtft-core.c | 25 +++++++++++++++----------
 1 file changed, 15 insertions(+), 10 deletions(-)
drivers/staging/fbtft/fbtft-core.c +15 -10
index b742ee7..b004a4d 100644
@@ -275,23 +275,31 @@ static int fbtft_backlight_get_brightness(struct backlight_device *bd)
 	return bd->props.brightness;
 }
 
+static const struct backlight_ops fbtft_bl_ops = {
+	.get_brightness	= fbtft_backlight_get_brightness,
+	.update_status	= fbtft_backlight_update_status,
+};
+#endif
+
 void fbtft_unregister_backlight(struct fbtft_par *par)
 {
+	#ifdef CONFIG_FB_BACKLIGHT
+
 	if (par->info->bl_dev) {
 		par->info->bl_dev->props.power = FB_BLANK_POWERDOWN;
 		backlight_update_status(par->info->bl_dev);
 		backlight_device_unregister(par->info->bl_dev);
 		par->info->bl_dev = NULL;
 	}
-}
 
-static const struct backlight_ops fbtft_bl_ops = {
-	.get_brightness	= fbtft_backlight_get_brightness,
-	.update_status	= fbtft_backlight_update_status,
-};
+	#endif
+}
+EXPORT_SYMBOL(fbtft_unregister_backlight);
 
 void fbtft_register_backlight(struct fbtft_par *par)
 {
+	#ifdef CONFIG_FB_BACKLIGHT
+
 	struct backlight_device *bd;
 	struct backlight_properties bl_props = { 0, };
 
@@ -320,13 +328,10 @@ void fbtft_register_backlight(struct fbtft_par *par)
 
 	if (!par->fbtftops.unregister_backlight)
 		par->fbtftops.unregister_backlight = fbtft_unregister_backlight;
+
+	#endif
 }
-#else
-void fbtft_register_backlight(struct fbtft_par *par) { };
-void fbtft_unregister_backlight(struct fbtft_par *par) { };
-#endif
 EXPORT_SYMBOL(fbtft_register_backlight);
-EXPORT_SYMBOL(fbtft_unregister_backlight);
 
 static void fbtft_set_addr_win(struct fbtft_par *par, int xs, int ys, int xe,
 			       int ye)
Signature · 1 line
2.10.2
maintainer
#1 lore raw
Quoted 15 lines · Shiva Kerdel

This patch fixes the following checkpatch.pl warning
- EXPORT_SYMBOL(foo); should immediately follow its function/variable

---
 drivers/staging/fbtft/fbtft-core.c | 25 +++++++++++++++----------
 1 file changed, 15 insertions(+), 10 deletions(-)
drivers/staging/fbtft/fbtft-core.c +0 -0
index b742ee7..b004a4d 100644
@@ -275,23 +275,31 @@ static int fbtft_backlight_get_brightness(struct backlight_device *bd)
 	return bd->props.brightness;
 }

drivers/staging/fbtft/fbtft-core.c static int fbtft_backlight_get_brightness(struct backlight_device *bd) · line 286

Quoted 10 lines
drivers/staging/fbtft/fbtft-core.c +7 -0
 
+static const struct backlight_ops fbtft_bl_ops = {
+	.get_brightness	= fbtft_backlight_get_brightness,
+	.update_status	= fbtft_backlight_update_status,
+};
+#endif
+
 void fbtft_unregister_backlight(struct fbtft_par *par)
 {
+	#ifdef CONFIG_FB_BACKLIGHT

Ick, no, does this really look like good style?

Quoted 27 lines
drivers/staging/fbtft/fbtft-core.c +6 -5
+
 	if (par->info->bl_dev) {
 		par->info->bl_dev->props.power = FB_BLANK_POWERDOWN;
 		backlight_update_status(par->info->bl_dev);
 		backlight_device_unregister(par->info->bl_dev);
 		par->info->bl_dev = NULL;
 	}
-}
 
-static const struct backlight_ops fbtft_bl_ops = {
-	.get_brightness	= fbtft_backlight_get_brightness,
-	.update_status	= fbtft_backlight_update_status,
-};
+	#endif
+}
+EXPORT_SYMBOL(fbtft_unregister_backlight);
 
 void fbtft_register_backlight(struct fbtft_par *par)
 {
+	#ifdef CONFIG_FB_BACKLIGHT
+
 	struct backlight_device *bd;
 	struct backlight_properties bl_props = { 0, };
 
@@ -320,13 +328,10 @@ void fbtft_register_backlight(struct fbtft_par *par)
 
 	if (!par->fbtftops.unregister_backlight)

drivers/staging/fbtft/fbtft-core.c void fbtft_register_backlight(struct fbtft_par *par) · line 329

Quoted 10 lines
drivers/staging/fbtft/fbtft-core.c +2 -5
 		par->fbtftops.unregister_backlight = fbtft_unregister_backlight;
+
+	#endif
 }
-#else
-void fbtft_register_backlight(struct fbtft_par *par) { };
-void fbtft_unregister_backlight(struct fbtft_par *par) { };
-#endif
 EXPORT_SYMBOL(fbtft_register_backlight);
-EXPORT_SYMBOL(fbtft_unregister_backlight);

The original code here is fine, please leave it as-is.

thanks,

greg k-h