Skip to contentSkip to conversation

ext2.mk: ensure -b option is always set for mke2img and genext2fs

PATCH New J Evans 3 participants 4 messages Apr 30, 2017 ext2 file system

lore
Share & tools
lore

J Evans

author
#0 lore raw

PATCH 1/1 ext2.mk: ensure -b option is always set for mke2img and genext2fs

Signed-off-by J Evans <[email protected]>
---
 fs/ext2/ext2.mk | 2 --
 1 file changed, 2 deletions(-)
fs/ext2/ext2.mk +0 -2
index 30f1d17..9d3e8fd 100644
@@ -6,9 +6,7 @@
 
 EXT2_OPTS = -G $(BR2_TARGET_ROOTFS_EXT2_GEN) -R $(BR2_TARGET_ROOTFS_EXT2_REV)
 
-ifneq ($(strip $(BR2_TARGET_ROOTFS_EXT2_BLOCKS)),0)
 EXT2_OPTS += -b $(BR2_TARGET_ROOTFS_EXT2_BLOCKS)
-endif
 
 ifneq ($(strip $(BR2_TARGET_ROOTFS_EXT2_INODES)),0)
 EXT2_OPTS += -i $(BR2_TARGET_ROOTFS_EXT2_INODES)
Signature · 1 line
2.7.4
#1 lore raw

PATCH 1/1 ext2.mk: ensure -b option is always set for mke2img and genext2fs

J, All,

On 2017-04-30 13:35 +0100, J Evans spake thusly:

Quoted 1 line
Signed-off-by J Evans <[email protected]>
Acked-by "Yann E. MORIN" <[email protected]>

Thanks! :-)

Regards,
Yann E. MORIN.

Quoted 25 lines
---
 fs/ext2/ext2.mk | 2 --
 1 file changed, 2 deletions(-)
fs/ext2/ext2.mk +0 -2
index 30f1d17..9d3e8fd 100644
@@ -6,9 +6,7 @@
 
 EXT2_OPTS = -G $(BR2_TARGET_ROOTFS_EXT2_GEN) -R $(BR2_TARGET_ROOTFS_EXT2_REV)
 
-ifneq ($(strip $(BR2_TARGET_ROOTFS_EXT2_BLOCKS)),0)
 EXT2_OPTS += -b $(BR2_TARGET_ROOTFS_EXT2_BLOCKS)
-endif
 
 ifneq ($(strip $(BR2_TARGET_ROOTFS_EXT2_INODES)),0)
 EXT2_OPTS += -i $(BR2_TARGET_ROOTFS_EXT2_INODES)
Signature · 6 lines
2.7.4

_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot
Signature · 6 lines
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
Applied
#2 lore raw

PATCH 1/1 ext2.mk: ensure -b option is always set for mke2img and genext2fs

In reply to J Evans

Hello,

Quoted 4 lines · J Evans
Signed-off-by J Evans <[email protected]>
---
 fs/ext2/ext2.mk | 2 --
 1 file changed, 2 deletions(-)

Applied to master, thanks.

However, I believe we should do the same for the number of inodes:

ifneq ($(strip $(BR2_TARGET_ROOTFS_EXT2_INODES)),0) EXT2_OPTS += -i $(BR2_TARGET_ROOTFS_EXT2_INODES) endif

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
#3 lore raw

PATCH 1/1 ext2.mk: ensure -b option is always set for mke2img and genext2fs

Thomas, All,

On 2017-04-30 19:33 +0200, Thomas Petazzoni spake thusly:

Quoted 6 lines · J Evans
Quoted 4 lines
Signed-off-by J Evans <[email protected]>
---
 fs/ext2/ext2.mk | 2 --
 1 file changed, 2 deletions(-)
Quoted 7 lines

Applied to master, thanks.

However, I believe we should do the same for the number of inodes:

ifneq ($(strip $(BR2_TARGET_ROOTFS_EXT2_INODES)),0) EXT2_OPTS += -i $(BR2_TARGET_ROOTFS_EXT2_INODES) endif

Yep, was going to work on that next...

Regards,
Yann E. MORIN.

Quoted 5 lines

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
Signature · 6 lines
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'