x11vnc: make x11vnc select libvncserver
PATCH 1/1 x11vnc: make x11vnc select libvncserver
x11vnc needs libvncserver, so select it explicitely.
In case of missing libvncserver, we see build failures like this:
http://autobuild.buildroot.net/results/34f/34f8045e772b96293cc7d25bd61ac0aa5842824f/
--- package/x11vnc/Config.in | 1 + 1 file changed, 1 insertion(+)
package/x11vnc/Config.in +1 -0
@@ -5,6 +5,7 @@ config BR2_PACKAGE_X11VNC select BR2_PACKAGE_XLIB_LIBXT select BR2_PACKAGE_XLIB_LIBXEXT select BR2_PACKAGE_XLIB_LIBXTST + select BR2_PACKAGE_LIBVNCSERVER help VNC server for X11 display
Signature · 1 line
2.11.0
PATCH 1/1 x11vnc: make x11vnc select libvncserver
Hi Martin,
Quoted 16 lines · Martin Kepplinger
x11vnc needs libvncserver, so select it explicitely.
In case of missing libvncserver, we see build failures like this:
http://autobuild.buildroot.net/results/34f/34f8045e772b96293cc7d25bd61ac0aa5842824f/
Signed-off-by Martin Kepplinger <[email protected]>--- package/x11vnc/Config.in | 1 + 1 file changed, 1 insertion(+)package/x11vnc/Config.in +0
-0
package/x11vnc/Config.in config BR2_PACKAGE_X11VNC · line 8
Quoted 4 lines
package/x11vnc/Config.in +1
-0@@ -5,6 +5,7 @@ config BR2_PACKAGE_X11VNC select BR2_PACKAGE_XLIB_LIBXT select BR2_PACKAGE_XLIB_LIBXEXT select BR2_PACKAGE_XLIB_LIBXTST + select BR2_PACKAGE_LIBVNCSERVER
Since this is a build time dependency, you need to add it to X11VNC_DEPENDENCIES to make sure libvncserver builds before x11vnc.
You also need to propagate the additional BR2_PACKAGE_LIBVNCSERVER dependency, !BR2_nios2.
baruch
Signature · 3 lines
http://baruch.siach.name/blog/ ~. .~ Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
- baruch at tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -PATCH v2 1/1 x11vnc: make x11vnc select libvncserver
x11vnc needs libvncserver, so select it explicitely.
In case of missing libvncserver, we see build failures like this:
http://autobuild.buildroot.net/results/34f/34f8045e772b96293cc7d25bd61ac0aa5842824f/
---
Thanks a lot for your help! I think that's what you meant, right?
revision history
----------------
v2: add libvncserver to build dependencies and !BR2_nios2 to depends
v1: initial patch. add select BR2_PACKAGE_LIBVNCSERVER
package/x11vnc/Config.in | 2 ++ package/x11vnc/x11vnc.mk | 2 ++ 2 files changed, 4 insertions(+)
package/x11vnc/Config.in +2 -0
@@ -2,9 +2,11 @@ config BR2_PACKAGE_X11VNC bool "x11vnc" depends on BR2_PACKAGE_XORG7 depends on BR2_USE_MMU # fork() + depends on !BR2_nios2 # from libvncserver select BR2_PACKAGE_XLIB_LIBXT select BR2_PACKAGE_XLIB_LIBXEXT select BR2_PACKAGE_XLIB_LIBXTST + select BR2_PACKAGE_LIBVNCSERVER help VNC server for X11 display
package/x11vnc/x11vnc.mk +2 -0
@@ -16,6 +16,8 @@ X11VNC_LICENSE_FILES = COPYING # Source coming from github, no configure included X11VNC_AUTORECONF = YES +X11VNC_DEPENDENCIES += libvncserver + ifeq ($(BR2_PACKAGE_AVAHI_DAEMON)$(BR2_PACKAGE_DBUS),yy) X11VNC_DEPENDENCIES += avahi dbus else
Signature · 1 line
2.11.0
PATCH v2 1/1 x11vnc: make x11vnc select libvncserver
Hello,
package/x11vnc/Config.in config BR2_PACKAGE_X11VNC · line 5
Quoted 9 lines · Martin Kepplinger
package/x11vnc/Config.in +1
-0@@ -2,9 +2,11 @@ config BR2_PACKAGE_X11VNC bool "x11vnc" depends on BR2_PACKAGE_XORG7 depends on BR2_USE_MMU # fork() + depends on !BR2_nios2 # from libvncserver
The comment is normally just "# libvncserver"
package/x11vnc/Config.in config BR2_PACKAGE_X11VNC · line 9
Quoted 4 lines
package/x11vnc/Config.in +1
-0select BR2_PACKAGE_XLIB_LIBXT select BR2_PACKAGE_XLIB_LIBXEXT select BR2_PACKAGE_XLIB_LIBXTST + select BR2_PACKAGE_LIBVNCSERVER
We try to keep things sorted alphabetically, so this select should have been before the other ones.
package/x11vnc/x11vnc.mk X11VNC_LICENSE_FILES = COPYING · line 19
Quoted 9 lines
package/x11vnc/x11vnc.mk +1
-0@@ -16,6 +16,8 @@ X11VNC_LICENSE_FILES = COPYING # Source coming from github, no configure included X11VNC_AUTORECONF = YES +X11VNC_DEPENDENCIES += libvncserver
No need for a new X11VNC_DEPENDENCIES assignment here, there was already one a few lines above.
I've fixed those minor issues and applied your patch. Thanks a lot!
Thomas
Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com