bluez5_utils: fix build of gatttool

Since BlueZ 5.44 gatttool is hidden behind the --enable-deprecated configure option.

Also, update the help text with the new status of gatttool.

Fixes:
http://autobuild.buildroot.net/results/ddb/ddb975c9e1475fee1da63cb21240d8d59b161076/
http://autobuild.buildroot.net/results/19a/19adc0aa5a7e48119ef4ba25ba0403867f74f678/
http://autobuild.buildroot.net/results/9bd/9bd8e13ddffdd0631ddca30ec40cc4664729b0cb/

---
 package/bluez5_utils/Config.in       | 5 ++---
 package/bluez5_utils/bluez5_utils.mk | 1 +
 2 files changed, 3 insertions(+), 3 deletions(-)

index 3611c6971a6d..43771c026438 100644
@@ -54,10 +54,9 @@ config BR2_PACKAGE_BLUEZ5_UTILS_GATTTOOL
 	help
 	  Generic Attribute Profile (GATT) support. This provides
 	  profile discovery and description services for Bluetooth Low
-	  Energy. This will install the gatttool utility.
+	  Energy. This will build and install the gatttool utility.
 
-	  It is always built with BlueZ 5.x, but upstream choose not
-	  to install it by default.
+	  The gatttool is deprecated.
 
 config BR2_PACKAGE_BLUEZ5_UTILS_EXPERIMENTAL
 	bool "build experimental plugins"

index aaefcb6ace9b..e5482455d283 100644
@@ -51,6 +51,7 @@ define BLUEZ5_UTILS_INSTALL_GATTTOOL
 	$(INSTALL) -D -m 0755 $(@D)/attrib/gatttool $(TARGET_DIR)/usr/bin/gatttool
 endef
 BLUEZ5_UTILS_POST_INSTALL_TARGET_HOOKS += BLUEZ5_UTILS_INSTALL_GATTTOOL
+BLUEZ5_UTILS_CONF_OPTS += --enable-deprecated
 endif
 
 # enable test

2.11.0

Hello,

We have lots of patches pending on bluez5_utils, to solve this issue and others. It's not clear what is the overall plan, as all the patches have been sent separately (i.e not in a series).

See
https://patchwork.ozlabs.org/project/buildroot/list/?submitter=&state=&q=bluez&archive=&delegate=.

Essentially, your patch is the third one to solve the gattool problem.

Best regards,

Thomas

Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

Hi Thomas,

This patch is essentially equivalent to that of Bernd[1], expect that is also updates the help text.

I think Andy's suggestion[2] is better than both, but it needs some more work to address Peter's comments, and maybe split into separate tools and plugins patches. I also think that we should group all deprecated tools together, and replace the BR2_PACKAGE_BLUEZ5_UTILS_GATTTOOL option with BR2_PACKAGE_BLUEZ5_UTILS_DEPRECATED.

I don't think we should remove gatttool installation as Sam suggests[3]. E.g. the hciattach tool is also deprecated upstream, but it is unfortunately still required for many real world Bluetooth installations.

I'll take over Andy's patch as time permits.

[1] https://patchwork.ozlabs.org/patch/736377/

[2] https://patchwork.ozlabs.org/patch/741645/

[3] https://patchwork.ozlabs.org/patch/748801/

baruch

     http://baruch.siach.name/blog/                  ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch at tkos.co.il - tel: +972.52.368.4656, http://www.tkos.co.il -