Skip to contentSkip to conversation

package/kodi: re-install prompt for optical drives

PATCH New Yann E. MORIN 3 participants 3 messages Apr 17, 2017 – May 1, 2017

lore
Share & tools
lore

Yann E. MORIN

author
#0 lore raw

PATCH 1/1 package/kodi: re-install prompt for optical drives

In 81c438aa (package/kodi: Rework audio encoder support), the prompt for the optical drive support was dropped, on the assumption that such support was only needed when an audio encoder was enabled.

However, support for optical drives is also required when, surprisingly, one wants to read a DVD (and probably a BD as well, but this was not tested by lack of hardware).

Re-instate the prompt, so one can enable optical drive support even when no audio encoder enabled.

Signed-off-by "Yann E. MORIN" <[email protected]>
Cc Bernd Kuhls <[email protected]>
Cc Maxime Hadjinlian <[email protected]>
---
 package/kodi/Config.in | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
package/kodi/Config.in +3 -1
index f2a3e2e032..b993ac94a5 100644
@@ -253,7 +253,9 @@ config BR2_PACKAGE_KODI_UPNP
 	  Enable UPnP support
 
 config BR2_PACKAGE_KODI_OPTICALDRIVE
-	bool
+	bool "optical drives"
+	help
+	  Add support for optical drives, to read e.g. DVDs...
 
 menu "Audio decoder addons"
 	source "package/kodi-audiodecoder-modplug/Config.in"
Signature · 1 line
2.11.0
#1 lore raw

PATCH 1/1 package/kodi: re-install prompt for optical drives

Am Mon, 17 Apr 2017 16:06:41 +0200 schrieb Yann E. MORIN:

Quoted 3 lines

In 81c438aa (package/kodi: Rework audio encoder support), the prompt for the optical drive support was dropped, on the assumption that such support was only needed when an audio encoder was enabled.

Acked-by Bernd Kuhls <[email protected]>
Applied
#2 lore raw

PATCH 1/1 package/kodi: re-install prompt for optical drives

In reply to Yann E. MORIN

Hello,

Quoted 11 lines · Yann E. MORIN

In 81c438aa (package/kodi: Rework audio encoder support), the prompt for the optical drive support was dropped, on the assumption that such support was only needed when an audio encoder was enabled.

However, support for optical drives is also required when, surprisingly, one wants to read a DVD (and probably a BD as well, but this was not tested by lack of hardware).

Re-instate the prompt, so one can enable optical drive support even when no audio encoder enabled.

Quoted 6 lines
Signed-off-by "Yann E. MORIN" <[email protected]>
Cc Bernd Kuhls <[email protected]>
Cc Maxime Hadjinlian <[email protected]>
---
 package/kodi/Config.in | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

Applied to master, thanks.

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com