mpir: fix build failure
PATCH v5 1/1 mpir: fix build failure
---
Changes between v4 and v5:
- right env variable
Changes between v3 and v4:
- small formatting change
Changes between v2 and v3:
- fixed build for mips
Changes between v1 and v2:
- removed unneeded depend on
- fixed build for powerpc
--- package/mpir/mpir.mk | 13 +++++++++++++ 1 file changed, 13 insertions(+)
package/mpir/mpir.mk +13 -0
@@ -12,4 +12,17 @@ MPIR_LICENSE_FILES = COPYING.LIB MPIR_INSTALL_STAGING = YES MPIR_DEPENDENCIES = gmp host-yasm +ifeq ($(BR2_MIPS_NABI32),y) +MPIR_CONF_OPTS += ABI=n32 +endif + +ifeq ($(BR2_MIPS_NABI64),y) +MPIR_CONF_OPTS += ABI=n64 +endif + +ifeq ($(BR2_powerpc_CLASSIC),y) +MPIR_CONF_OPTS += ABI=mode64 +MPIR_CONF_ENV += MPN_PATH=generic +endif + $(eval $(autotools-package))
Signature · 1 line
2.7.4
PATCH v5 1/1 mpir: fix build failure
Hello,
Quoted 1 line · Semyon Kolganov
Signed-off-by Semyon Kolganov <[email protected]>
When you're fixing build failures from the autobuilders, the commit log should provide references to the autobuilder failures being fixed.
package/mpir/mpir.mk MPIR_LICENSE_FILES = COPYING.LIB · line 21
Quoted 3 lines
package/mpir/mpir.mk +3
-0+ifeq ($(BR2_MIPS_NABI64),y) +MPIR_CONF_OPTS += ABI=n64 +endif
You did not even test this, because it fails to build:
configure: error: ABI=n64 is not among the following valid choices: 64 n32 o32
So I've fixed that to ABI=64
package/mpir/mpir.mk MPIR_LICENSE_FILES = COPYING.LIB · line 26
Quoted 4 lines
package/mpir/mpir.mk +4
-0+ifeq ($(BR2_powerpc_CLASSIC),y) +MPIR_CONF_OPTS += ABI=mode64 +MPIR_CONF_ENV += MPN_PATH=generic +endif
This looks bogus. mode64 seems to refer to a 64-bit ABI, while BR2_powerpc_CLASSIC is not necessarily 64 bit.
So, I've applied after changing ABI=n64 to ABI=64, dropping the PowerPC stuff and adding a reference to the autobuilder failure being fixes.
That being said, there are still several other mpir related build failures that have not been fixed:
* On ARM, we fail with the old Crosstool-NG toolchains, but apparently not with other ARM toolchains. Both the ARMv5 and ARMv7 Crosstool-NG toolchains are failing to build MPIR:
http://autobuild.buildroot.net/results/fd0/fd032f7dbd4cace84bb31e8017cb6139ef3c1072/build-end.log
http://autobuild.buildroot.net/results/c36/c360581c2925529f18635aac32c2865899f5e0f5/build-end.log
* On MIPS64r6
http://autobuild.buildroot.net/results/c45/c45dd59f10693b0d9a86dac4733c6c3dde4554f1/build-end.log
* On PowerPC64
http://autobuild.buildroot.net/results/be1/be1478836b2e7b580174641f48de92c9b02512a7/build-end.log
Could you have a look and fix those remaining issues?
Thanks!
Thomas
Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com
PATCH v5 1/1 mpir: fix build failure
Hello,
Quoted 9 lines · Thomas Petazzoni
* On ARM, we fail with the old Crosstool-NG toolchains, but apparently not with other ARM toolchains. Both the ARMv5 and ARMv7 Crosstool-NG toolchains are failing to build MPIR:
http://autobuild.buildroot.net/results/fd0/fd032f7dbd4cace84bb31e8017cb6139ef3c1072/build-end.log http://autobuild.buildroot.net/results/c36/c360581c2925529f18635aac32c2865899f5e0f5/build-end.log* On MIPS64r6
Quoted 7 lines
http://autobuild.buildroot.net/results/c45/c45dd59f10693b0d9a86dac4733c6c3dde4554f1/build-end.log* On PowerPC64
http://autobuild.buildroot.net/results/be1/be1478836b2e7b580174641f48de92c9b02512a7/build-end.logCould you have a look and fix those remaining issues?
And by the way: please use the test-pkg script in support/scripts/test-pkg to test that MPIR builds correctly on all platforms.
Thanks,
Thomas
Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com
PATCH v5 1/1 mpir: fix build failure
In reply to Thomas PetazzoniHello,
Of course, I'll fixed it, as son as possible.
--
Semyon
-----------
Semyon Kolganov ???????????, 01 ??? 2017?., 12:21 +03:00 ?? Thomas Petazzoni thomas.petazzoni at free-electrons.com :
Quoted 45 lines
Hello,
Quoted 1 line · Semyon Kolganov
Signed-off-by Semyon Kolganov < [email protected] >When you're fixing build failures from the autobuilders, the commit log should provide references to the autobuilder failures being fixed.
package/mpir/mpir.mk MPIR_LICENSE_FILES = COPYING.LIB · line 21
Quoted 3 lines
package/mpir/mpir.mk +3
-0+ifeq ($(BR2_MIPS_NABI64),y) +MPIR_CONF_OPTS += ABI=n64 +endifYou did not even test this, because it fails to build:
configure: error: ABI=n64 is not among the following valid choices: 64 n32 o32
So I've fixed that to ABI=64
package/mpir/mpir.mk MPIR_LICENSE_FILES = COPYING.LIB · line 26
Quoted 4 lines
package/mpir/mpir.mk +4
-0+ifeq ($(BR2_powerpc_CLASSIC),y) +MPIR_CONF_OPTS += ABI=mode64 +MPIR_CONF_ENV += MPN_PATH=generic +endifThis looks bogus. mode64 seems to refer to a 64-bit ABI, while
BR2_powerpc_CLASSICis not necessarily 64 bit.So, I've applied after changing ABI=n64 to ABI=64, dropping the PowerPC stuff and adding a reference to the autobuilder failure being fixes.
That being said, there are still several other mpir related build failures that have not been fixed:
?* On ARM, we fail with the old Crosstool-NG toolchains, but apparently ???not with other ARM toolchains. Both the ARMv5 and ARMv7 Crosstool-NG ???toolchains are failing to build MPIR:
??? http://autobuild.buildroot.net/results/fd0/fd032f7dbd4cace84bb31e8017cb6139ef3c1072/build-end.log
??? http://autobuild.buildroot.net/results/c36/c360581c2925529f18635aac32c2865899f5e0f5/build-end.log?* On MIPS64r6
??? http://autobuild.buildroot.net/results/c45/c45dd59f10693b0d9a86dac4733c6c3dde4554f1/build-end.log
?* On PowerPC64
Quoted 11 lines
??? http://autobuild.buildroot.net/results/be1/be1478836b2e7b580174641f48de92c9b02512a7/build-end.log
Could you have a look and fix those remaining issues?
Thanks!
Thomas
Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20170501/87298ad8/attachment.html>