Skip to contentSkip to conversation

platform/x86: Make SILEAD_DMI depend on TOUCHSCREEN_SILEAD

PATCH In review Darren Hart (VMware) 3 participants 4 messages Apr 28, 2017 – May 3, 2017 x86 platform drivers

lore
Share & tools
lore

Darren Hart (VMware)

author
#0 lore raw

PATCH 1/1 platform/x86: Make SILEAD_DMI depend on TOUCHSCREEN_SILEAD

SILEAD_DMI provides platform specific data for the TOUCHSCREEN_SILEAD driver. Make this explicitly clear in the Kconfig depends.

Signed-off-by Darren Hart (VMware) <[email protected]>
Cc Hans de Goede <[email protected]>
Cc Andy Shevchenko <[email protected]>
Cc Jean Delvare <[email protected]>
Cc Dmitry Torokhov <[email protected]>
---
 drivers/platform/x86/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/platform/x86/Kconfig +1 -1
index 9e5b2c2..5690664 100644
@@ -1101,7 +1101,7 @@ config INTEL_TURBO_MAX_3
 
 config SILEAD_DMI
 	bool "Tablets with Silead touchscreens"
-	depends on ACPI && DMI && I2C=y && INPUT
+	depends on ACPI && DMI && I2C=y && INPUT && TOUCHSCREEN_SILEAD
 	---help---
 	  Certain ACPI based tablets with Silead touchscreens do not have
 	  enough data in ACPI tables for the touchscreen driver to handle
Signature · 6 lines
2.9.3


-- 
Darren Hart
VMware Open Source Technology Center
Reviewed-by on v1 1/1
#1 lore raw
Quoted 17 lines · Darren Hart (VMware)

SILEAD_DMI provides platform specific data for the TOUCHSCREEN_SILEAD driver. Make this explicitly clear in the Kconfig depends.

Signed-off-by Darren Hart (VMware) <[email protected]>
Cc Hans de Goede <[email protected]>
Cc Andy Shevchenko <[email protected]>
Cc Jean Delvare <[email protected]>
Cc Dmitry Torokhov <[email protected]>
---
 drivers/platform/x86/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/platform/x86/Kconfig +0 -0
index 9e5b2c2..5690664 100644

drivers/platform/x86/Kconfig config INTEL_TURBO_MAX_3 · line 1104

Quoted 5 lines
drivers/platform/x86/Kconfig +1 -1
@@ -1101,7 +1101,7 @@ config INTEL_TURBO_MAX_3
 
 config SILEAD_DMI
 	bool "Tablets with Silead touchscreens"
-	depends on ACPI && DMI && I2C=y && INPUT
+	depends on ACPI && DMI && I2C=y && INPUT && TOUCHSCREEN_SILEAD

Bikeshed: TOUCHSCREEN_SILEAD already depends on INPUT, so you can drop INPUT dependency.

Otherwise

Reviewed-by Dmitry Torokhov <[email protected]>
Signature · 1 line
Dmitry
author
#2 lore raw
Quoted 19 lines · Dmitry Torokhov
Quoted 18 lines · Darren Hart (VMware)

SILEAD_DMI provides platform specific data for the TOUCHSCREEN_SILEAD driver. Make this explicitly clear in the Kconfig depends.

Signed-off-by Darren Hart (VMware) <[email protected]>
Cc Hans de Goede <[email protected]>
Cc Andy Shevchenko <[email protected]>
Cc Jean Delvare <[email protected]>
Cc Dmitry Torokhov <[email protected]>
---
 drivers/platform/x86/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/platform/x86/Kconfig +0 -0
index 9e5b2c2..5690664 100644
@@ -1101,7 +1101,7 @@ config INTEL_TURBO_MAX_3
Quoted 8 lines

drivers/platform/x86/Kconfig config INTEL_TURBO_MAX_3 · line 1104

Quoted 4 lines
drivers/platform/x86/Kconfig +1 -1
 config SILEAD_DMI
 	bool "Tablets with Silead touchscreens"
-	depends on ACPI && DMI && I2C=y && INPUT
+	depends on ACPI && DMI && I2C=y && INPUT && TOUCHSCREEN_SILEAD

Bikeshed: TOUCHSCREEN_SILEAD already depends on INPUT, so you can drop INPUT dependency.

Done, thanks.

Quoted 7 lines

Otherwise

Reviewed-by Dmitry Torokhov <[email protected]>
Signature · 1 line
Dmitry
Signature · 2 lines
Darren Hart
VMware Open Source Technology Center
Reviewed-by on v1 1/1
#3 lore raw
In reply to Darren Hart (VMware)
Quoted 17 lines · Darren Hart (VMware)

SILEAD_DMI provides platform specific data for the TOUCHSCREEN_SILEAD driver. Make this explicitly clear in the Kconfig depends.

Signed-off-by Darren Hart (VMware) <[email protected]>
Cc Hans de Goede <[email protected]>
Cc Andy Shevchenko <[email protected]>
Cc Jean Delvare <[email protected]>
Cc Dmitry Torokhov <[email protected]>
---
 drivers/platform/x86/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/platform/x86/Kconfig +0 -0
index 9e5b2c2..5690664 100644

drivers/platform/x86/Kconfig config INTEL_TURBO_MAX_3 · line 1107

Quoted 8 lines
drivers/platform/x86/Kconfig +1 -1
@@ -1101,7 +1101,7 @@ config INTEL_TURBO_MAX_3
 
 config SILEAD_DMI
 	bool "Tablets with Silead touchscreens"
-	depends on ACPI && DMI && I2C=y && INPUT
+	depends on ACPI && DMI && I2C=y && INPUT && TOUCHSCREEN_SILEAD
 	---help---
 	  Certain ACPI based tablets with Silead touchscreens do not have
 	  enough data in ACPI tables for the touchscreen driver to handle
Reviewed-by Jean Delvare <[email protected]>

Thanks Darren,

Signature · 2 lines
Jean Delvare
SUSE L3 Support