Skip to contentSkip to conversation

config.mak.uname: set NO_REGEX=NeedsStartEnd on AIX

PATCH In review Ævar Arnfjörð Bjarmason 3 participants 4 messages May 3, 2017

lore
Share & tools
lore

Ævar Arnfjörð Bjarmason

author
#0 lore raw

PATCH 1/1 config.mak.uname: set NO_REGEX=NeedsStartEnd on AIX

Set the NO_REGEX=NeedsStartEnd Makefile flag by default on AIX.

Since commit 2f8952250a ("regex: add regexec_buf() that can work on a non NUL-terminated string", 2016-09-21) git has errored out at compile-time if the regular expression library doesn't support REG_STARTEND.

While looking through Google search results for the use of NO_REGEX I found a Chef recipe that set this on AIX[1], looking through the documentation for the latest version of AIX (7.2, released October 2015) shows that its regexec() doesn't have REG_STARTEND.

1. https://github.com/chef/omnibus-software/commit/e247e36761#diff-3df898345d670979b74acc0bf71d8c47
2. https://www.ibm.com/support/knowledgecenter/ssw_aix_72/com.ibm.aix.basetrf2/regexec.htm

Signed-off-by Ævar Arnfjörð Bjarmason <[email protected]>
---
 config.mak.uname | 1 +
 1 file changed, 1 insertion(+)
config.mak.uname +1 -0
index 399fe19271..192629f143 100644
@@ -237,6 +237,7 @@ ifeq ($(uname_S),AIX)
 	NO_MKDTEMP = YesPlease
 	NO_STRLCPY = YesPlease
 	NO_NSEC = YesPlease
+	NO_REGEX = NeedsStartEnd
 	FREAD_READS_DIRECTORIES = UnfortunatelyYes
 	INTERNAL_QSORT = UnfortunatelyYes
 	NEEDS_LIBICONV = YesPlease
Signature · 1 line
2.11.0
Reviewed-by on v1 1/1
#1 lore raw
Quoted 12 lines · Ævar Arnfjörð Bjarmason

Set the NO_REGEX=NeedsStartEnd Makefile flag by default on AIX.

Since commit 2f8952250a ("regex: add regexec_buf() that can work on a non NUL-terminated string", 2016-09-21) git has errored out at compile-time if the regular expression library doesn't support REG_STARTEND.

While looking through Google search results for the use of NO_REGEX I found a Chef recipe that set this on AIX[1], looking through the documentation for the latest version of AIX (7.2, released October 2015) shows that its regexec() doesn't have REG_STARTEND.

Quoted 7 lines

1. https://github.com/chef/omnibus-software/commit/e247e36761#diff-3df898345d670979b74acc0bf71d8c47
2. https://www.ibm.com/support/knowledgecenter/ssw_aix_72/com.ibm.aix.basetrf2/regexec.htm

Signed-off-by Ævar Arnfjörð Bjarmason <[email protected]>
---
 config.mak.uname | 1 +
 1 file changed, 1 insertion(+)

Thanks.

Reviewed-by Jonathan Nieder <[email protected]>

Is there e.g. a build farm where we can check for this kind of thing more systematically on supported platforms?

#2 lore raw
Quoted 3 lines · Jonathan Nieder

Is there e.g. a build farm where we can check for this kind of thing more systematically on supported platforms?

There is the OpenSuse build farm that provides builds for all kinds of linux distributions, though we'd rather be looking for *all* operating systems, not just various flavors of linux.

After some research, I found
https://gcc.gnu.org/wiki/CompileFarm
https://launchpad.net/builders
https://buildd.debian.org/

The gcc build farm would include AIX, maybe we could talk to them to have more CI support on more platforms?

Also you're a DD, maybe we could hook up git testing on debian to test for different hardware platforms?

Thanks,
Stefan

#3 lore raw

Hi,

Quoted 9 lines · Stefan Beller
Quoted 2 lines · Jonathan Nieder

Is there e.g. a build farm where we can check for this kind of thing more systematically on supported platforms?

There is the OpenSuse build farm that provides builds for all kinds of linux distributions, though we'd rather be looking for *all* operating systems, not just various flavors of linux.

Quoted 7 lines

After some research, I found
https://gcc.gnu.org/wiki/CompileFarm
https://launchpad.net/builders
https://buildd.debian.org/

The gcc build farm would include AIX, maybe we could talk to them to have more CI support on more platforms?

Thanks for the pointers.

Quoted 2 lines

Also you're a DD, maybe we could hook up git testing on debian to test for different hardware platforms?

https://buildd.debian.org/status/package.php?p=git&suite=experimental
shows test suite results for Debian's various platforms running "next".

Hope that helps,
Jonathan