net: core: remove unnecessary code

PATCH New Gustavo A. R. Silva 1 participant 1 message May 3, 2017

Subsystems (2)

Networking Network drivers

lore

Share & tools

lore

Gustavo A. R. Silva

author

2017-05-03 17:17 UTC #0 lore raw

PATCH 1/1 net: core: remove unnecessary code

The name of an array used by itself will always return the array's address. So this test will always evaluate as true.

Addresses-Coverity-ID: 115325

Signed-off-by Gustavo A. R. Silva <[email protected]>

---
 net/core/netpoll.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

net/core/netpoll.c +4 -4

index 9424673..27ce3b1 100644
@@ -657,13 +657,13 @@ int netpoll_setup(struct netpoll *np)
 {
 	struct net_device *ndev = NULL;
 	struct in_device *in_dev;
+	struct net *net;
 	int err;
 
 	rtnl_lock();
-	if (np->dev_name) {
-		struct net *net = current->nsproxy->net_ns;
-		ndev = __dev_get_by_name(net, np->dev_name);
-	}
+	net = current->nsproxy->net_ns;
+	ndev = __dev_get_by_name(net, np->dev_name);
+
 	if (!ndev) {
 		np_err(np, "%s doesn't exist, aborting\n", np->dev_name);
 		err = -ENODEV;

Signature · 1 line

2.5.0