hwmon: (it87) Remove useless test during device detection
Subsystems (2)
PATCH 1/1 hwmon: (it87) Remove useless test during device detection
There is no reason to treat the IT8705F differently during device detection. If a single IT8705F chip indeed answers to both Super-IO addresses, we have code in place to detect the duplicate device address and skip the second one.
--- drivers/hwmon/it87.c | 7 ------- 1 file changed, 7 deletions(-)
drivers/hwmon/it87.c +0 -7
@@ -3224,13 +3224,6 @@ static int __init sm_it87_init(void) goto exit_dev_unregister; found = true; - -/* -* IT8705F may respond on both SIO addresses. -* Stop probing after finding one. -*/ -if (sio_data.type == it87) -break ; }if (!found) {
Signature · 2 lines
Jean Delvare SUSE L3 Support
Quoted 5 lines · Jean Delvare
There is no reason to treat the IT8705F differently during device detection. If a single IT8705F chip indeed answers to both Super-IO addresses, we have code in place to detect the duplicate device address and skip the second one.
(...)
Bah, scratch this. I can't even convince myself that this is a good idea. Sure, the rest of the code is enough to deal with the situation, but why keep looking for something when we already know we will find and discard a duplicate...
Sorry for the noise,
Signature · 2 lines
Jean Delvare SUSE L3 Support