drm/i915/guc: Dump the GuC stage descriptor pool in debugfs
Subsystems (2)
PATCH 1/1 drm/i915/guc: Dump the GuC stage descriptor pool in debugfs
We are missing pieces of information that could be useful for GuC debugging.
--- drivers/gpu/drm/i915/i915_debugfs.c | 61 +++++++++++++++++++++++++++++++++++++ 1 file changed, 61 insertions(+)
drivers/gpu/drm/i915/i915_debugfs.c +61 -0
@@ -2540,6 +2540,66 @@ static int i915_guc_info(struct seq_file *m, void *data)return 0 ; } +static int i915_guc_stage_pool (struct seq_file *m,void *data) +{ +struct drm_i915_private *dev_priv =node_to_i915 (m->private); +const struct intel_guc *guc = &dev_priv->guc; +struct guc_stage_desc *desc = guc->stage_desc_pool_vaddr; +struct i915_guc_client *client = guc->execbuf_client; +unsigned int tmp; +int index; + +if (!client) { +seq_printf (m,"GuC submission %s\n" , +HAS_GUC (dev_priv) ? +"disabled" : +"not supported" ); +return 0 ; + } + +for (index =0 ; index <GUC_MAX_STAGE_DESCRIPTORS ; index++, desc++) { +struct intel_engine_cs *engine; + +if (!(desc->attribute &GUC_STAGE_DESC_ATTR_ACTIVE )) +continue ; + +seq_printf (m,"GuC stage descriptor %u:\n" , index); +seq_printf (m,"\tIndex: %u\n" , desc->stage_id); +seq_printf (m,"\tAttribute: 0x%x\n" , desc->attribute); +seq_printf (m,"\tPriority: %d\n" , desc->priority); +seq_printf (m,"\tDoorbell id: %d\n" , desc->db_id); +seq_printf (m,"\tEngines used: 0x%x\n" , + desc->engines_used); +seq_printf (m,"\tDoorbell trigger phy: 0x%llx, cpu: 0x%llx, uK: 0x%x\n" , + desc->db_trigger_phy, + desc->db_trigger_cpu, + desc->db_trigger_uk); +seq_printf (m,"\tProcess descriptor: 0x%x\n" , + desc->process_desc); +seq_printf (m,"\tWorkqueue adddress: 0x%x, size: 0x%x\n" , + desc->wq_addr, desc->wq_size); +seq_putc (m,'\n' ); + +for_each_engine_masked (engine, dev_priv, client->engines, tmp) { +uint32_t guc_engine_id = engine->guc_id; +struct guc_execlist_context *lrc = + &desc->lrc[guc_engine_id]; + +seq_printf (m,"\t%s LRC:\n" , engine->name); +seq_printf (m,"\t\tContext desc: 0x%x\n" , + lrc->context_desc); +seq_printf (m,"\t\tContext id: 0x%x\n" , lrc->context_id); +seq_printf (m,"\t\tLRCA: 0x%x\n" , lrc->ring_lrca); +seq_printf (m,"\t\tRing begin: 0x%x\n" , lrc->ring_begin); +seq_printf (m,"\t\tRing end: 0x%x\n" , lrc->ring_end); +seq_putc (m,'\n' ); + + } + } + +return 0 ; +} +static int i915_guc_log_dump (struct seq_file *m,void *data) {struct drm_i915_private *dev_priv =node_to_i915 (m->private);
@@ -4774,6 +4834,7 @@ static int i915_hpd_storm_ctl_open(struct inode *inode, struct file *file) {"i915_guc_info", i915_guc_info, 0}, {"i915_guc_load_status", i915_guc_load_status_info, 0}, {"i915_guc_log_dump", i915_guc_log_dump, 0}, + {"i915_guc_stage_pool", i915_guc_stage_pool, 0}, {"i915_huc_load_status", i915_huc_load_status_info, 0}, {"i915_frequency_info", i915_frequency_info, 0}, {"i915_hangcheck_info", i915_hangcheck_info, 0},
Signature · 6 lines
1.9.1 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI✓ Fi.CI.BAT: success for drm/i915/guc: Dump the GuC stage descriptor pool in debugfs
== Series Details ==
== Series Details ==
Series: drm/i915/guc: Dump the GuC stage descriptor pool in debugfs
URL : https://patchwork.freedesktop.org/series/24051/
State : success
== Summary ==
Series 24051v1 drm/i915/guc: Dump the GuC stage descriptor pool in debugfs
https://patchwork.freedesktop.org/api/1.0/series/24051/revisions/1/mbox/
Test gem_exec_flush:
Subgroup basic-batch-kernel-default-uc:
fail -> PASS (fi-snb-2600) fdo#100007fdo#100007 https://bugs.freedesktop.org/show_bug.cgi?id=100007
fi-bdw-5557u total:278 pass:267 dwarn:0 dfail:0 fail:0 skip:11 time:438s fi-bdw-gvtdvm total:278 pass:256 dwarn:8 dfail:0 fail:0 skip:14 time:431s fi-bsw-n3050 total:278 pass:242 dwarn:0 dfail:0 fail:0 skip:36 time:578s fi-bxt-j4205 total:278 pass:259 dwarn:0 dfail:0 fail:0 skip:19 time:505s fi-bxt-t5700 total:278 pass:258 dwarn:0 dfail:0 fail:0 skip:20 time:555s fi-byt-j1900 total:278 pass:254 dwarn:0 dfail:0 fail:0 skip:24 time:486s fi-byt-n2820 total:278 pass:250 dwarn:0 dfail:0 fail:0 skip:28 time:479s fi-hsw-4770 total:278 pass:262 dwarn:0 dfail:0 fail:0 skip:16 time:408s fi-hsw-4770r total:278 pass:262 dwarn:0 dfail:0 fail:0 skip:16 time:402s fi-ilk-650 total:278 pass:228 dwarn:0 dfail:0 fail:0 skip:50 time:422s fi-ivb-3520m total:278 pass:260 dwarn:0 dfail:0 fail:0 skip:18 time:489s fi-ivb-3770 total:278 pass:260 dwarn:0 dfail:0 fail:0 skip:18 time:481s fi-kbl-7500u total:278 pass:260 dwarn:0 dfail:0 fail:0 skip:18 time:451s fi-kbl-7560u total:278 pass:267 dwarn:1 dfail:0 fail:0 skip:10 time:568s fi-skl-6700hq total:278 pass:261 dwarn:0 dfail:0 fail:0 skip:17 time:558s fi-skl-6700k total:278 pass:256 dwarn:4 dfail:0 fail:0 skip:18 time:455s fi-skl-6770hq total:278 pass:268 dwarn:0 dfail:0 fail:0 skip:10 time:506s fi-skl-gvtdvm total:278 pass:265 dwarn:0 dfail:0 fail:0 skip:13 time:426s fi-snb-2520m total:278 pass:250 dwarn:0 dfail:0 fail:0 skip:28 time:542s fi-snb-2600 total:278 pass:249 dwarn:0 dfail:0 fail:0 skip:29 time:405s
fi-skl-6260u failed to collect. IGT log at Patchwork_4634/fi-skl-6260u/igt.log
fb550f86433515f36a0de161631541ec114581e3 drm-tip: 2017y-05m-05d-18h-33m-52s UTC integration manifest 413cbcc drm/i915/guc: Dump the GuC stage descriptor pool in debugfs
== Logs ==
For more details see: https://intel-gfx-ci.01.org/CI/Patchwork_4634/
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Quoted 24 lines · Oscar Mateo
We are missing pieces of information that could be useful for GuC debugging.
Cc Daniele Ceraolo Spurio <[email protected]>Cc Joonas Lahtinen <[email protected]>Signed-off-by Oscar Mateo <[email protected]>---
drivers/gpu/drm/i915/i915_debugfs.c | 61 +++++++++++++++++++++++++++++++++++++1 file changed, 61 insertions(+)drivers/gpu/drm/i915/i915_debugfs.c +0
-0@@ -2540,6 +2540,66 @@ static int i915_guc_info(struct seq_file *m, void *data) > return 0; }drivers/gpu/drm/i915/i915_debugfs.c +6
-0+static int i915_guc_stage_pool (struct seq_file *m,void *data) +{ +struct drm_i915_private *dev_priv =node_to_i915 (m->private); +const struct intel_guc *guc = &dev_priv->guc; +struct guc_stage_desc *desc = guc->stage_desc_pool_vaddr; +struct i915_guc_client *client = guc->execbuf_client;
drivers/gpu/drm/i915/i915_debugfs.c static int i915_guc_info(struct seq_file *m, void *data) · line 2558
Quoted 10 lines
drivers/gpu/drm/i915/i915_debugfs.c +10
-0+unsigned int tmp; +int index; + +if (!client) { +seq_printf (m,"GuC submission %s\n" , + HAS_GUC(dev_priv) ? + "disabled" : + "not supported"); +return 0 ; + }
De-dupe above fragment into a separate static function;
if (!check_guc(dev_priv)) return 0;
It could be applied to the other GuC functions, too.
Then this is;
Regards, Joonas
Signature · 7 lines
Joonas Lahtinen Open Source Technology Center Intel Corporation _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx