Skip to contentSkip to conversation

mpir: fix ARM, PowerPC and mips builds failure

PATCH New Semyon Kolganov 2 participants 3 messages May 7, 2017 1 message not in the archive

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): mpir: fix ARM, PowerPC64 and MIPS build failure

#1 lore raw

PATCH 1/1 mpir: fix ARM, PowerPC and mips builds failure

Semyon Kolganov (1):
mpir: fix ARM, PowerPC and mips builds failure

 package/mpir/mpir.mk | 3 +++
 1 file changed, 3 insertions(+)
Signature · 1 line
2.7.4
#2 lore raw

PATCH 1/1 mpir: fix ARM, PowerPC and mips builds failure

* ARM

     http://autobuild.buildroot.net/results/fd0/fd032f7dbd4cace84bb31e8017cb6139ef3c1072
     http://autobuild.buildroot.net/results/c36/c360581c2925529f18635aac32c2865899f5e0f5

* MIPS

     http://autobuild.buildroot.net/results/c45/c45dd59f10693b0d9a86dac4733c6c3dde4554f1

* PowerPC64

      http://autobuild.buildroot.net/results/be1/be1478836b2e7b580174641f48de92c9b02512a7
---
 package/mpir/mpir.mk | 3 +++
 1 file changed, 3 insertions(+)
package/mpir/mpir.mk +3 -0
index b7f3829..420d065 100644
@@ -12,6 +12,9 @@ MPIR_LICENSE_FILES = COPYING.LIB
 MPIR_INSTALL_STAGING = YES
 MPIR_DEPENDENCIES = gmp host-yasm
 
+# Prefer generic build
+MPIR_CONF_ENV += MPN_PATH=generic
+
 ifeq ($(BR2_MIPS_NABI32),y)
 MPIR_CONF_OPTS += ABI=n32
 endif
Signature · 1 line
2.7.4
#3 lore raw

PATCH 1/1 mpir: fix ARM, PowerPC and mips builds failure

Hello,

package/mpir/mpir.mk MPIR_LICENSE_FILES = COPYING.LIB · line 16

Quoted 2 lines · Semyon Kolganov
package/mpir/mpir.mk +2 -0
+# Prefer generic build
+MPIR_CONF_ENV += MPN_PATH=generic

I think this is really wrong, because it will use in all cases the non-optimized generic code, instead of the more optimized assembly code available for a number of architectures:

$ ls mpn/
alpha  arm  asm-defs.m4  cpp-ccas  generic  ia64  m4-ccas  Makeasm.am  Makefile.am  Makefile.in  mips32  mips64  powerpc32  powerpc64  README  sparc32  sparc64  x86  x86_64  x86_64w  x86w

Best regards,

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com