Skip to contentSkip to conversation

package/espeak: add comment to ignore 'unmet dependencies'

PATCH New Yann E. MORIN 2 participants 4 messages May 7, 2017 – May 11, 2017

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 package/espeak: add comment to ignore 'unmet dependencies'

On master 86b4eeccc4, espeak can generate spurious 'unmet dependencies' messages:

    $ make KCONFIG_SEED=0x7A85DEE0 randconfig
    warning: (BR2_PACKAGE_ESPEAK_AUDIO_BACKEND_ALSA) selects
    BR2_PACKAGE_PORTAUDIO_CXX which has unmet directdependencies
    (BR2_PACKAGE_PORTAUDIO && BR2_INSTALL_LIBSTDCPP)

However, the dpendency chain *is* correct. There is something that causes the kconfig parser to get really confused...

Add a comment statng the issue is spurious, so noone tries to fix it.

---
 package/espeak/Config.in | 3 +++
 1 file changed, 3 insertions(+)
package/espeak/Config.in +3 -0
index aed627af92..6a8f1d4098 100644
@@ -27,6 +27,9 @@ config BR2_PACKAGE_ESPEAK_AUDIO_BACKEND_NONE
 
 config BR2_PACKAGE_ESPEAK_AUDIO_BACKEND_ALSA
 	bool "alsa via portaudio"
+	# Selecting portaudio generates spurious "unmet dependencies"
+	# warnings. Unless you are changing the dependencies of espeak
+	# or portaudio, just ignore those spurious warnings.
 	select BR2_PACKAGE_PORTAUDIO
 	select BR2_PACKAGE_PORTAUDIO_CXX
 
Signature · 1 line
2.11.0
#1 lore raw

PATCH 1/1 package/espeak: add comment to ignore 'unmet dependencies'

Hello,

Quoted 8 lines · Yann E. MORIN

On master 86b4eeccc4, espeak can generate spurious 'unmet dependencies' messages:

    $ make KCONFIG_SEED=0x7A85DEE0 randconfig
    warning: (BR2_PACKAGE_ESPEAK_AUDIO_BACKEND_ALSA) selects
    BR2_PACKAGE_PORTAUDIO_CXX which has unmet directdependencies
    (BR2_PACKAGE_PORTAUDIO && BR2_INSTALL_LIBSTDCPP)
Quoted 4 lines

However, the dpendency chain *is* correct. There is something that causes the kconfig parser to get really confused...

Add a comment statng the issue is spurious, so noone tries to fix it.

Indeed, I don't see anything wrong in this dependency chain.

package/espeak/Config.in config BR2_PACKAGE_ESPEAK_AUDIO_BACKEND_NONE · line 34

Quoted 7 lines

config BR2_PACKAGE_ESPEAK_AUDIO_BACKEND_ALSA

package/espeak/Config.in +3 -0
 	bool "alsa via portaudio"
+	# Selecting portaudio generates spurious "unmet dependencies"
+	# warnings. Unless you are changing the dependencies of espeak
+	# or portaudio, just ignore those spurious warnings.
 	select BR2_PACKAGE_PORTAUDIO
 	select BR2_PACKAGE_PORTAUDIO_CXX

Perhaps we could simply add a "depends on BR2_INSTALL_LIBSTDCPP" here, which most likely would silence the warning?

Thanks,

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
#2 lore raw

PATCH 1/1 package/espeak: add comment to ignore 'unmet dependencies'

Thomas, All,

On 2017-05-08 21:49 +0200, Thomas Petazzoni spake thusly:

Quoted 18 lines

Hello,

Quoted 8 lines · Yann E. MORIN

On master 86b4eeccc4, espeak can generate spurious 'unmet dependencies' messages:

    $ make KCONFIG_SEED=0x7A85DEE0 randconfig
    warning: (BR2_PACKAGE_ESPEAK_AUDIO_BACKEND_ALSA) selects
    BR2_PACKAGE_PORTAUDIO_CXX which has unmet directdependencies
    (BR2_PACKAGE_PORTAUDIO && BR2_INSTALL_LIBSTDCPP)
Quoted 4 lines

However, the dpendency chain *is* correct. There is something that causes the kconfig parser to get really confused...

Add a comment statng the issue is spurious, so noone tries to fix it.

Indeed, I don't see anything wrong in this dependency chain.

Quoted 10 lines

package/espeak/Config.in config BR2_PACKAGE_ESPEAK_AUDIO_BACKEND_NONE · line 34

Quoted 7 lines

config BR2_PACKAGE_ESPEAK_AUDIO_BACKEND_ALSA

package/espeak/Config.in +3 -0
 	bool "alsa via portaudio"
+	# Selecting portaudio generates spurious "unmet dependencies"
+	# warnings. Unless you are changing the dependencies of espeak
+	# or portaudio, just ignore those spurious warnings.
 	select BR2_PACKAGE_PORTAUDIO
 	select BR2_PACKAGE_PORTAUDIO_CXX

Perhaps we could simply add a "depends on BR2_INSTALL_LIBSTDCPP" here, which most likely would silence the warning?

Nope, it does not work. The only thing that breaks the dependency chain is that the select on portaudio be changed into a depends. I could well provide a patch to that effect, but that not very user-firendly... :-/

Regards,
Yann E. MORIN.

Signature · 6 lines
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
#3 lore raw

PATCH 1/1 package/espeak: add comment to ignore 'unmet dependencies'

In reply to Yann E. MORIN

Hello,

Quoted 11 lines · Yann E. MORIN

On master 86b4eeccc4, espeak can generate spurious 'unmet dependencies' messages:

    $ make KCONFIG_SEED=0x7A85DEE0 randconfig
    warning: (BR2_PACKAGE_ESPEAK_AUDIO_BACKEND_ALSA) selects
    BR2_PACKAGE_PORTAUDIO_CXX which has unmet directdependencies
    (BR2_PACKAGE_PORTAUDIO && BR2_INSTALL_LIBSTDCPP)

However, the dpendency chain *is* correct. There is something that causes the kconfig parser to get really confused...

Quoted 7 lines

Add a comment statng the issue is spurious, so noone tries to fix it.

---
 package/espeak/Config.in | 3 +++
 1 file changed, 3 insertions(+)

Applied to master, thanks.

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com