IB/netlink: Remove export of ibnl_chk_listeners function

PATCH In review Leon Romanovsky 2 participants 3 messages May 8, 2017 – May 9, 2017 1 message not in the archive InfiniBand

lore

Share & tools

lore

Leon Romanovsky

author

2017-05-08 12:13 UTC #0 lore raw

PATCH 1/1 IB/netlink: Remove export of ibnl_chk_listeners function

The ibnl_chk_listeners() function is called in the code located at the same module, hence no need to be exported.

Remove EXPORT_SYMBOL from it.

Signed-off-by Leon Romanovsky <leonro-VPRAkNaXOzVWk0Htik3J/[email protected]>

---
 drivers/infiniband/core/netlink.c | 1 -
 1 file changed, 1 deletion(-)

drivers/infiniband/core/netlink.c +0 -1

index 10469b0088b5..ebd16885cfce 100644
@@ -55,7 +55,6 @@ int ibnl_chk_listeners(unsigned int group)
 		return -1;
 	return 0;
 }
-EXPORT_SYMBOL(ibnl_chk_listeners);
 
 int ibnl_add_client(int index, int nops,
 		    const struct ibnl_client_cbs cb_table[])

--
2.12.2

--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html

A message that is not in the archive (sent off-list or not yet received): 20170508121343.3213-1-leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org

Yuval Shaia

2017-05-09 05:39 UTC #2 lore raw

Quoted 2 lines · Leon Romanovsky

The ibnl_chk_listeners() function is called in the code located at the same module, hence no need to be exported.

Do you think it's declaration should move from include/rdma/ to local header file also?

Quoted 23 lines

Remove EXPORT_SYMBOL from it.

Signed-off-by Leon Romanovsky <leonro-VPRAkNaXOzVWk0Htik3J/[email protected]>

---
 drivers/infiniband/core/netlink.c | 1 -
 1 file changed, 1 deletion(-)

drivers/infiniband/core/netlink.c +0 -2

index 10469b0088b5..ebd16885cfce 100644
@@ -55,7 +55,6 @@ int ibnl_chk_listeners(unsigned int group)
 		return -1;
 	return 0;
 }
-EXPORT_SYMBOL(ibnl_chk_listeners);
 
 int ibnl_add_client(int index, int nops,
 		    const struct ibnl_client_cbs cb_table[])
--

2.12.2

Quoted 4 lines

--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html

--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html

Leon Romanovsky

author

2017-05-09 06:06 UTC #3 lore raw

Quoted 6 lines · Yuval Shaia

Quoted 2 lines · Leon Romanovsky
The ibnl_chk_listeners() function is called in the code located at the same module, hence no need to be exported.
Do you think it's declaration should move from include/rdma/ to local header file also?

You are right, I'll move it together with ibnl_init(), ibnl_cleanup() functions and will send v1 shortly.

Thanks

Quoted 28 lines

Quoted 28 lines
Remove EXPORT_SYMBOL from it.
Signed-off-by Leon Romanovsky <leonro-VPRAkNaXOzVWk0Htik3J/[email protected]>
---
 drivers/infiniband/core/netlink.c | 1 -
 1 file changed, 1 deletion(-)
drivers/infiniband/core/netlink.c +0 -2
index 10469b0088b5..ebd16885cfce 100644
@@ -55,7 +55,6 @@ int ibnl_chk_listeners(unsigned int group)
 		return -1;
 	return 0;
 }
-EXPORT_SYMBOL(ibnl_chk_listeners);
 
 int ibnl_add_client(int index, int nops,
 		    const struct ibnl_client_cbs cb_table[])
--
2.12.2
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html