Skip to contentSkip to conversation

staging: typec: Make undeclared symbol static

PATCH In review Guru Das Srinagesh 2 participants 2 messages May 9, 2017 Staging

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 staging: typec: Make undeclared symbol static

Fix sparse warning:
drivers/staging/typec/tcpci.c:428:26: warning: symbol 'tcpci_tcpc_config' was not declared. Should it be static?

---
 drivers/staging/typec/tcpci.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/typec/tcpci.c +1 -1
index 5e5be74..df72d8b 100644
@@ -425,7 +425,7 @@ static const struct regmap_config tcpci_regmap_config = {
 	.max_register = 0x7F, /* 0x80 .. 0xFF are vendor defined */
 };
 
-const struct tcpc_config tcpci_tcpc_config = {
+static const struct tcpc_config tcpci_tcpc_config = {
 	.type = TYPEC_PORT_DFP,
 	.default_role = TYPEC_SINK,
 };
Signature · 1 line
2.7.4
#1 lore raw
Quoted 5 lines · Guru Das Srinagesh

Fix sparse warning:
drivers/staging/typec/tcpci.c:428:26: warning: symbol 'tcpci_tcpc_config' was not declared. Should it be static?

Olivier Leveque already sent a similar patch last week.

Thanks,
Guenter

Quoted 20 lines
---
 drivers/staging/typec/tcpci.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/typec/tcpci.c +1 -1
index 5e5be74..df72d8b 100644
@@ -425,7 +425,7 @@ static const struct regmap_config tcpci_regmap_config = {
 	.max_register = 0x7F, /* 0x80 .. 0xFF are vendor defined */
 };
 
-const struct tcpc_config tcpci_tcpc_config = {
+static const struct tcpc_config tcpci_tcpc_config = {
 	.type = TYPEC_PORT_DFP,
 	.default_role = TYPEC_SINK,
 };
Signature · 1 line
2.7.4