Skip to contentSkip to conversation

ARM: dts: imx: add DH2228FV DAC to Gateworks Ventana boards with SPI

PATCH New Tim Harvey 2 participants 4 messages May 3, 2017 – May 10, 2017

Subsystems (2)
Device tree bindings Arm i.MX and Layerscape
lore
Share & tools
lore

Tim Harvey

author
#0 lore raw

PATCH 1/1 ARM: dts: imx: add DH2228FV DAC to Gateworks Ventana boards with SPI

Signed-off-by Tim Harvey <[email protected]>
---
 arch/arm/boot/dts/imx6qdl-gw52xx.dtsi | 6 ++++++
 arch/arm/boot/dts/imx6qdl-gw54xx.dtsi | 6 ++++++
 arch/arm/boot/dts/imx6qdl-gw560x.dtsi | 6 ++++++
 3 files changed, 18 insertions(+)
arch/arm/boot/dts/imx6qdl-gw52xx.dtsi +6 -0
index 91991d6..b5c1a8f 100644
@@ -143,6 +143,12 @@
 	pinctrl-names = "default";
 	pinctrl-0 = <&pinctrl_ecspi3>;
 	status = "okay";
+
+	spidev0: spidev at 0 {
+		compatible = "rohm,dh2228fv";
+		reg = <0>;
+		spi-max-frequency = <60000000>;
+	};
 };
 
 &fec {
arch/arm/boot/dts/imx6qdl-gw54xx.dtsi +6 -0
index 968fda9..9d26511 100644
@@ -154,6 +154,12 @@
 	pinctrl-names = "default";
 	pinctrl-0 = <&pinctrl_ecspi2>;
 	status = "okay";
+
+	spidev0: spidev at 0 {
+		compatible = "rohm,dh2228fv";
+		reg = <0>;
+		spi-max-frequency = <60000000>;
+	};
 };
 
 &fec {
arch/arm/boot/dts/imx6qdl-gw560x.dtsi +6 -0
index d894dde..bfb63e9 100644
@@ -208,6 +208,12 @@
 	pinctrl-names = "default";
 	pinctrl-0 = <&pinctrl_ecspi3>;
 	status = "okay";
+
+	spidev0: spidev at 0 {
+		compatible = "rohm,dh2228fv";
+		reg = <0>;
+		spi-max-frequency = <60000000>;
+	};
 };
 
 &can1 {
Signature · 1 line
2.7.4
#1 lore raw

PATCH 1/1 ARM: dts: imx: add DH2228FV DAC to Gateworks Ventana boards with SPI

Quoted 12 lines · Tim Harvey
Signed-off-by Tim Harvey <[email protected]>
---
 arch/arm/boot/dts/imx6qdl-gw52xx.dtsi | 6 ++++++
 arch/arm/boot/dts/imx6qdl-gw54xx.dtsi | 6 ++++++
 arch/arm/boot/dts/imx6qdl-gw560x.dtsi | 6 ++++++
 3 files changed, 18 insertions(+)
arch/arm/boot/dts/imx6qdl-gw52xx.dtsi +0 -0
index 91991d6..b5c1a8f 100644

arch/arm/boot/dts/imx6qdl-gw52xx.dtsi line 148

Quoted 6 lines
arch/arm/boot/dts/imx6qdl-gw52xx.dtsi +3 -0
@@ -143,6 +143,12 @@
 	pinctrl-names = "default";
 	pinctrl-0 = <&pinctrl_ecspi3>;
 	status = "okay";
+
+	spidev0: spidev at 0 {
+		compatible = "rohm,dh2228fv";

I do not see this is a documented compatible.

Shawn

Quoted 43 lines
arch/arm/boot/dts/imx6qdl-gw52xx.dtsi +3 -0
+		reg = <0>;
+		spi-max-frequency = <60000000>;
+	};
 };
 
 &fec {
arch/arm/boot/dts/imx6qdl-gw54xx.dtsi +6 -0
index 968fda9..9d26511 100644
@@ -154,6 +154,12 @@
 	pinctrl-names = "default";
 	pinctrl-0 = <&pinctrl_ecspi2>;
 	status = "okay";
+
+	spidev0: spidev at 0 {
+		compatible = "rohm,dh2228fv";
+		reg = <0>;
+		spi-max-frequency = <60000000>;
+	};
 };
 
 &fec {
arch/arm/boot/dts/imx6qdl-gw560x.dtsi +6 -0
index d894dde..bfb63e9 100644
@@ -208,6 +208,12 @@
 	pinctrl-names = "default";
 	pinctrl-0 = <&pinctrl_ecspi3>;
 	status = "okay";
+
+	spidev0: spidev at 0 {
+		compatible = "rohm,dh2228fv";
+		reg = <0>;
+		spi-max-frequency = <60000000>;
+	};
 };
 
 &can1 {
Signature · 1 line
2.7.4
author
#2 lore raw

PATCH 1/1 ARM: dts: imx: add DH2228FV DAC to Gateworks Ventana boards with SPI

Quoted 22 lines · Shawn Guo
Quoted 12 lines · Tim Harvey
Signed-off-by Tim Harvey <[email protected]>
---
 arch/arm/boot/dts/imx6qdl-gw52xx.dtsi | 6 ++++++
 arch/arm/boot/dts/imx6qdl-gw54xx.dtsi | 6 ++++++
 arch/arm/boot/dts/imx6qdl-gw560x.dtsi | 6 ++++++
 3 files changed, 18 insertions(+)
arch/arm/boot/dts/imx6qdl-gw52xx.dtsi +0 -0
index 91991d6..b5c1a8f 100644

arch/arm/boot/dts/imx6qdl-gw52xx.dtsi line 148

Quoted 6 lines
arch/arm/boot/dts/imx6qdl-gw52xx.dtsi +3 -0
@@ -143,6 +143,12 @@
      pinctrl-names = "default";
      pinctrl-0 = <&pinctrl_ecspi3>;
      status = "okay";
+
+     spidev0: spidev at 0 {
+             compatible = "rohm,dh2228fv";

I do not see this is a documented compatible.

Quoted 2 lines

Shawn

Shawn,

No, it doesn't seem to be documented in Documentation/devicetree/bindings, but it is in the spidev driver:
https://lxr.missinglinkelectronics.com/linux/drivers/spi/spidev.c#L697

Regards,

Tim

#3 lore raw

PATCH 1/1 ARM: dts: imx: add DH2228FV DAC to Gateworks Ventana boards with SPI

Quoted 23 lines · Tim Harvey
Quoted 22 lines · Shawn Guo
Quoted 12 lines · Tim Harvey
Signed-off-by Tim Harvey <[email protected]>
---
 arch/arm/boot/dts/imx6qdl-gw52xx.dtsi | 6 ++++++
 arch/arm/boot/dts/imx6qdl-gw54xx.dtsi | 6 ++++++
 arch/arm/boot/dts/imx6qdl-gw560x.dtsi | 6 ++++++
 3 files changed, 18 insertions(+)
arch/arm/boot/dts/imx6qdl-gw52xx.dtsi +0 -0
index 91991d6..b5c1a8f 100644

arch/arm/boot/dts/imx6qdl-gw52xx.dtsi line 148

Quoted 6 lines
arch/arm/boot/dts/imx6qdl-gw52xx.dtsi +3 -0
@@ -143,6 +143,12 @@
      pinctrl-names = "default";
      pinctrl-0 = <&pinctrl_ecspi3>;
      status = "okay";
+
+     spidev0: spidev at 0 {
+             compatible = "rohm,dh2228fv";

I do not see this is a documented compatible.

Quoted 8 lines
Quoted 2 lines

Shawn

Shawn,

No, it doesn't seem to be documented in Documentation/devicetree/bindings, but it is in the spidev driver:
https://lxr.missinglinkelectronics.com/linux/drivers/spi/spidev.c#L697

Can you please add a patch documenting the compatible?

Shawn