Skip to contentSkip to conversation

arm64: Add flash node for ls1088a qds and rdb

PATCH Superseded Prabhakar Kushwaha 2 participants 2 messages May 5, 2017 – May 10, 2017

Subsystems (2)
Device tree bindings Arm i.MX and Layerscape

v2 of 3 Superseded Latest is v3 →

lore
Share & tools
lore

Prabhakar Kushwaha

author
#0 lore raw

PATCH v2 1/1 arm64: Add flash node for ls1088a qds and rdb

LS1088AQDS consist of NOR, NAND and FPGA connected over IFC LS1088ARDB consist of NAND and FPGA connected over IFC.

So add flash information in ifc node of device tree.

Signed-off-by Prabhakar Kushwaha <[email protected]>

---
changes for v2: Incorporated Shawn's comments

 arch/arm64/boot/dts/freescale/fsl-ls1088a-qds.dts | 25 +++++++++++++++++++++++
 arch/arm64/boot/dts/freescale/fsl-ls1088a-rdb.dts | 17 +++++++++++++++
 arch/arm64/boot/dts/freescale/fsl-ls1088a.dtsi    |  4 ----
 3 files changed, 42 insertions(+), 4 deletions(-)
arch/arm64/boot/dts/freescale/fsl-ls1088a-qds.dts +25 -0
index 8c3cae5..f536ca9 100644
@@ -110,6 +110,31 @@
 	};
 };
 
+&ifc {
+	status = "okay";
+
+	ranges = <0 0 0x5 0x80000000 0x08000000
+		  2 0 0x5 0x30000000 0x00010000
+		  3 0 0x5 0x20000000 0x00010000>;
+
+	nor at 0,0 {
+		compatible = "cfi-flash";
+		reg = <0x0 0x0 0x8000000>;
+		bank-width = <2>;
+		device-width = <1>;
+	};
+
+	nand at 2,0 {
+		compatible = "fsl,ifc-nand";
+		reg = <0x2 0x0 0x10000>;
+	};
+
+	fpga: board-control at 3,0 {
+		compatible = "fsl,ls1088aqds-fpga", "fsl,fpga-qixis";
+		reg = <0x3 0x0 0x0000100>;
+	};
+};
+
 &duart0 {
 	status = "okay";
 };
arch/arm64/boot/dts/freescale/fsl-ls1088a-rdb.dts +17 -0
index 8a04fbb..3f79610 100644
@@ -94,6 +94,23 @@
 	};
 };
 
+&ifc {
+	status = "okay";
+
+	ranges = <0 0 0x5 0x30000000 0x00010000
+		  2 0 0x5 0x20000000 0x00010000>;
+
+	nand at 0,0 {
+		compatible = "fsl,ifc-nand";
+		reg = <0x0 0x0 0x10000>;
+	};
+
+	fpga: board-control at 2,0 {
+		compatible = "fsl,ls1088ardb-fpga", "fsl,fpga-qixis";
+		reg = <0x2 0x0 0x0000100>;
+	};
+};
+
 &duart0 {
 	status = "okay";
 };
arch/arm64/boot/dts/freescale/fsl-ls1088a.dtsi +0 -4
index 2946fd7..9f6bcb4 100644
@@ -217,10 +217,6 @@
 			#address-cells = <2>;
 			#size-cells = <1>;
 
-			ranges = <0 0 0x5 0x80000000 0x08000000
-				  2 0 0x5 0x30000000 0x00010000
-				  3 0 0x5 0x20000000 0x00010000>;
-			status = "disabled";
 		};
 
 		i2c0: i2c at 2000000 {
Signature · 1 line
2.7.4
#1 lore raw

PATCH v2 1/1 arm64: Add flash node for ls1088a qds and rdb

Quoted 20 lines · Prabhakar Kushwaha

LS1088AQDS consist of NOR, NAND and FPGA connected over IFC LS1088ARDB consist of NAND and FPGA connected over IFC.

So add flash information in ifc node of device tree.

Signed-off-by Prabhakar Kushwaha <[email protected]>

---
changes for v2: Incorporated Shawn's comments

 arch/arm64/boot/dts/freescale/fsl-ls1088a-qds.dts | 25 +++++++++++++++++++++++
 arch/arm64/boot/dts/freescale/fsl-ls1088a-rdb.dts | 17 +++++++++++++++
 arch/arm64/boot/dts/freescale/fsl-ls1088a.dtsi    |  4 ----
 3 files changed, 42 insertions(+), 4 deletions(-)
arch/arm64/boot/dts/freescale/fsl-ls1088a-qds.dts +0 -0
index 8c3cae5..f536ca9 100644

arch/arm64/boot/dts/freescale/fsl-ls1088a-qds.dts line 118

Quoted 9 lines
arch/arm64/boot/dts/freescale/fsl-ls1088a-qds.dts +6 -0
@@ -110,6 +110,31 @@
 	};
 };
 
+&ifc {
+	status = "okay";
+
+	ranges = <0 0 0x5 0x80000000 0x08000000
+		  2 0 0x5 0x30000000 0x00010000
+		  3 0 0x5 0x20000000 0x00010000>;

We usually have 'status' be the last one in property list, and also newline in the middle of property list is generally unneeded.

	ranges = <0 0 0x5 0x80000000 0x08000000
		  2 0 0x5 0x30000000 0x00010000
		  3 0 0x5 0x20000000 0x00010000>;
	status = "okay";
Quoted 27 lines
arch/arm64/boot/dts/freescale/fsl-ls1088a-qds.dts +19 -0
+
+	nor at 0,0 {
+		compatible = "cfi-flash";
+		reg = <0x0 0x0 0x8000000>;
+		bank-width = <2>;
+		device-width = <1>;
+	};
+
+	nand at 2,0 {
+		compatible = "fsl,ifc-nand";
+		reg = <0x2 0x0 0x10000>;
+	};
+
+	fpga: board-control at 3,0 {
+		compatible = "fsl,ls1088aqds-fpga", "fsl,fpga-qixis";
+		reg = <0x3 0x0 0x0000100>;
+	};
+};
+
 &duart0 {
 	status = "okay";
 };
arch/arm64/boot/dts/freescale/fsl-ls1088a-rdb.dts +0 -0
index 8a04fbb..3f79610 100644

arch/arm64/boot/dts/freescale/fsl-ls1088a-rdb.dts line 101

Quoted 8 lines
arch/arm64/boot/dts/freescale/fsl-ls1088a-rdb.dts +5 -0
@@ -94,6 +94,23 @@
 	};
 };
 
+&ifc {
+	status = "okay";
+
+	ranges = <0 0 0x5 0x30000000 0x00010000
+		  2 0 0x5 0x20000000 0x00010000>;

Ditto

Quoted 20 lines
arch/arm64/boot/dts/freescale/fsl-ls1088a-rdb.dts +12 -0
+
+	nand at 0,0 {
+		compatible = "fsl,ifc-nand";
+		reg = <0x0 0x0 0x10000>;
+	};
+
+	fpga: board-control at 2,0 {
+		compatible = "fsl,ls1088ardb-fpga", "fsl,fpga-qixis";
+		reg = <0x2 0x0 0x0000100>;
+	};
+};
+
 &duart0 {
 	status = "okay";
 };
arch/arm64/boot/dts/freescale/fsl-ls1088a.dtsi +0 -0
index 2946fd7..9f6bcb4 100644

arch/arm64/boot/dts/freescale/fsl-ls1088a.dtsi line 223

Quoted 7 lines
arch/arm64/boot/dts/freescale/fsl-ls1088a.dtsi +0 -4
@@ -217,10 +217,6 @@
 			#address-cells = <2>;
 			#size-cells = <1>;
 
-			ranges = <0 0 0x5 0x80000000 0x08000000
-				  2 0 0x5 0x30000000 0x00010000
-				  3 0 0x5 0x20000000 0x00010000>;
-			status = "disabled";

The 'status' line should be kept.

Shawn

Quoted 7 lines
arch/arm64/boot/dts/freescale/fsl-ls1088a.dtsi +0 -0
 		};
 
 		i2c0: i2c at 2000000 {
Signature · 1 line
2.7.4