nvme_fc: correct port role bits
Subsystems (2)
PATCH 1/1 nvme_fc: correct port role bits
From: James Smart <[email protected]>
FC Port roles is a bit mask, not individual values. Correct nvme definitions to unique bits.
--- include/linux/nvme-fc-driver.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
include/linux/nvme-fc-driver.h +2 -2
@@ -27,8 +27,8 @@/* FC Port role bitmask - can merge with FC Port Roles in fc transport */ #define FC_PORT_ROLE_NVME_INITIATOR 0x10 -#define FC_PORT_ROLE_NVME_TARGET 0x11 -#define FC_PORT_ROLE_NVME_DISCOVERY 0x12 +#define FC_PORT_ROLE_NVME_TARGET 0x20 +#define FC_PORT_ROLE_NVME_DISCOVERY 0x40/**
Signature · 1 line
2.11.0
PATCH 1/1 nvme_fc: correct port role bits
Quoted 7 lines · On 05/06/2017 01:13 AM, [email protected] wrote:
From: James Smart <jsmart2021 at gmail.com>
FC Port roles is a bit mask, not individual values. Correct nvme definitions to unique bits.
Signed-off-by James Smart <james.smart at broadcom.com>---
Although it really should be merged into scsi/scsi_transport_fc.h some day.
Signature · 6 lines
Johannes Thumshirn Storage jthumshirn at suse.de +49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 N?rnberg GF: Felix Imend?rffer, Jane Smithard, Graham Norton HRB 21284 (AG N?rnberg) Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850
PATCH 1/1 nvme_fc: correct port role bits
Quoted 6 lines · Johannes Thumshirn
Quoted 5 lines · On 05/06/2017 01:13 AM, [email protected] wrote:
From: James Smart <jsmart2021 at gmail.com>
FC Port roles is a bit mask, not individual values. Correct nvme definitions to unique bits.
Quoted 6 lines
Quoted 2 lines
Signed-off-by James Smart <james.smart at broadcom.com>---
Reviewed-by Johannes Thumshirn <jthumshirn at suse.de>Although it really should be merged into
scsi/scsi_transport_fc.hsome day.
Agreed. Maybe we just need a fc_common.h header or so.
But for now I've applied the patch to nvme-4.12