Skip to contentSkip to conversation

nvme_fc: revise comment on teardown

PATCH New [email protected] 3 participants 3 messages Apr 25, 2017 – May 10, 2017

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 nvme_fc: revise comment on teardown

From: James Smart <[email protected]>

Per the recommendation by Sagi on:
http://lists.infradead.org/pipermail/linux-nvme/2017-April/009261.html

An extra reference was pointed out. There's no issue with the references, but rather a literal interpretation of what the comment is saying.

Reword the comment to avoid confusion.

Signed-off-by James Smart <james.smart at broadcom.com>
---
 drivers/nvme/host/fc.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)
drivers/nvme/host/fc.c +4 -4
index 2690824..e917d91 100644
@@ -2540,10 +2540,10 @@ nvme_fc_delete_ctrl_work(struct work_struct *work)
 
 	/*
 	 * tear down the controller
-	 * This will result in the last reference on the nvme ctrl to
-	 * expire, calling the transport nvme_fc_nvme_ctrl_freed() callback.
-	 * From there, the transport will tear down it's logical queues and
-	 * association.
+	 * After the last reference on the nvme ctrl is removed,
+	 * the transport nvme_fc_nvme_ctrl_freed() callback will be
+	 * invoked. From there, the transport will tear down it's
+	 * logical queues and association.
 	 */
 	nvme_uninit_ctrl(&ctrl->ctrl);
 
Signature · 1 line
2.9.3
#1 lore raw

PATCH 1/1 nvme_fc: revise comment on teardown

Quoted 5 lines · On 04/26/2017 12:35 AM, [email protected] wrote:

From: James Smart <jsmart2021 at gmail.com>

Per the recommendation by Sagi on:
http://lists.infradead.org/pipermail/linux-nvme/2017-April/009261.html

Quoted 8 lines

An extra reference was pointed out. There's no issue with the references, but rather a literal interpretation of what the comment is saying.

Reword the comment to avoid confusion.

Signed-off-by James Smart <james.smart at broadcom.com>

---

Reviewed-by Johannes Thumshirn <jthumshirn at suse.de>
Signature · 6 lines
Johannes Thumshirn                                          Storage
jthumshirn at suse.de                                +49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 N?rnberg
GF: Felix Imend?rffer, Jane Smithard, Graham Norton
HRB 21284 (AG N?rnberg)
Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850