Skip to contentSkip to conversation

qwt: fix build when BR2_STATIC_LIBS=y

PATCH New Gwenhael Goavec-Merou 3 participants 3 messages May 11, 2017 – May 15, 2017

lore
Share & tools
lore

Gwenhael Goavec-Merou

author
#0 lore raw

PATCH 1/1 qwt: fix build when BR2_STATIC_LIBS=y

From: Gwenhael Goavec-Merou <[email protected]>

By default, qwt build a shared library, but when BR2_STATIC_LIBS is set compilation failed with errors like :
__uClibc_main.c:(.text+0x164): undefined reference to __fini_array_end' __uClibc_main.c:(.text+0x168): undefined reference to __fini_array_start' __uClibc_main.c:(.text+0x16c): undefined reference to `__fini_array_start'

This patch disable QwtDll to build a static library when BR2_STATIC_LIBS=y.

fix:
http://autobuild.buildroot.net/results/739/739406bb8073d1861933872a47802954d9767634/

Signed-off-by Gwenhael Goavec-Merou <[email protected]>
---
 package/qwt/qwt.mk | 6 ++++++
 1 file changed, 6 insertions(+)
package/qwt/qwt.mk +6 -0
index d4e6d52..b5bdf51 100644
@@ -41,6 +41,12 @@ else
 QWT_CONFIG += -e 's/^.*QWT_CONFIG.*QwtOpenGL.*$$/\# QWT_CONFIG += QwtOpenGL/'
 endif
 
+ifeq ($(BR2_STATIC_LIBS),y)
+QWT_CONFIG += -e 's/^.*QWT_CONFIG.*QwtDll.*$$/\# QWT_CONFIG += QwtDll/'
+else
+QWT_CONFIG += -e 's/^.*QWT_CONFIG.*QwtDll.*$$/\QWT_CONFIG += QwtDll/'
+endif
+
 define QWT_CONFIGURE_CMDS
 	$(SED) $(QWT_CONFIG) $(@D)/qwtconfig.pri
 	(cd $(@D); $(TARGET_MAKE_ENV) $(QWT_QMAKE))
Signature · 1 line
2.10.2
#1 lore raw

PATCH 1/1 qwt: fix build when BR2_STATIC_LIBS=y

Hello,

package/qwt/qwt.mk else · line 47

Quoted 4 lines · Gwenhael Goavec-Merou
package/qwt/qwt.mk +4 -0
+ifeq ($(BR2_STATIC_LIBS),y)
+QWT_CONFIG += -e 's/^.*QWT_CONFIG.*QwtDll.*$$/\# QWT_CONFIG += QwtDll/'
+else
+QWT_CONFIG += -e 's/^.*QWT_CONFIG.*QwtDll.*$$/\QWT_CONFIG += QwtDll/'

^^ this backslash shouldn't be here

I've fixed that and applied to master. Thanks a lot for working so quickly on a patch!

Best regards,

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
#2 lore raw

PATCH 1/1 qwt: fix build when BR2_STATIC_LIBS=y

In reply to Gwenhael Goavec-Merou
Quoted 9 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Gwenhael" == Gwenhael Goavec-Merou <[email protected]> writes:

From: Gwenhael Goavec-Merou <[email protected]> By default, qwt build a shared library, but when BR2_STATIC_LIBS is set compilation failed with errors like :
__uClibc_main.c:(.text+0x164): undefined reference to __fini_array_end' __uClibc_main.c:(.text+0x168): undefined reference to __fini_array_start' __uClibc_main.c:(.text+0x16c): undefined reference to `__fini_array_start'

Quoted 6 lines

This patch disable QwtDll to build a static library when BR2_STATIC_LIBS=y.

fix:
http://autobuild.buildroot.net/results/739/739406bb8073d1861933872a47802954d9767634/

Signed-off-by Gwenhael Goavec-Merou <[email protected]>

Committed to 2017.02.x, thanks.

Signature · 1 line
Bye, Peter Korsgaard