video: fbdev: add missing USB-descriptor endianness conversions

PATCH New Johan Hovold 1 participant 1 message May 12, 2017

Subsystems (3)

Framebuffer layer Displaylink USB 2.0 framebuffer driver (udlfb) Smsc UFX6000 and UFX7000 USB to vga driver

lore

Share & tools

lore

Johan Hovold

author

2017-05-12 10:17 UTC #0 lore raw

PATCH 1/1 video: fbdev: add missing USB-descriptor endianness conversions

Add the missing endianness conversions when printing the USB device-descriptor idVendor, idProduct and bcdDevice fields during probe.

Signed-off-by Johan Hovold <[email protected]>

---
 drivers/video/fbdev/smscufx.c | 5 +++--
 drivers/video/fbdev/udlfb.c   | 5 +++--
 2 files changed, 6 insertions(+), 4 deletions(-)

drivers/video/fbdev/smscufx.c +3 -2

index ec2e7e353685..449fceaf79d5 100644
@@ -1646,8 +1646,9 @@ static int ufx_usb_probe(struct usb_interface *interface,
 	dev_dbg(dev->gdev, "%s %s - serial #%s\n",
 		usbdev->manufacturer, usbdev->product, usbdev->serial);
 	dev_dbg(dev->gdev, "vid_%04x&pid_%04x&rev_%04x driver's ufx_data struct at %p\n",
-		usbdev->descriptor.idVendor, usbdev->descriptor.idProduct,
-		usbdev->descriptor.bcdDevice, dev);
+		le16_to_cpu(usbdev->descriptor.idVendor),
+		le16_to_cpu(usbdev->descriptor.idProduct),
+		le16_to_cpu(usbdev->descriptor.bcdDevice), dev);
 	dev_dbg(dev->gdev, "console enable=%d\n", console);
 	dev_dbg(dev->gdev, "fb_defio enable=%d\n", fb_defio);

drivers/video/fbdev/udlfb.c +3 -2

index 6a3c353de7c3..a868cbb51a34 100644
@@ -1613,8 +1613,9 @@ static int dlfb_usb_probe(struct usb_interface *interface,
 	pr_info("%s %s - serial #%s\n",
 		usbdev->manufacturer, usbdev->product, usbdev->serial);
 	pr_info("vid_%04x&pid_%04x&rev_%04x driver's dlfb_data struct at %p\n",
-		usbdev->descriptor.idVendor, usbdev->descriptor.idProduct,
-		usbdev->descriptor.bcdDevice, dev);
+		le16_to_cpu(usbdev->descriptor.idVendor),
+		le16_to_cpu(usbdev->descriptor.idProduct),
+		le16_to_cpu(usbdev->descriptor.bcdDevice), dev);
 	pr_info("console enable=%d\n", console);
 	pr_info("fb_defio enable=%d\n", fb_defio);
 	pr_info("shadow enable=%d\n", shadow);

Signature · 1 line

2.13.0