IB/IPoIB: Limit the ipoib_dev_uninit_default scope
PATCH 1/1 IB/IPoIB: Limit the ipoib_dev_uninit_default scope
From: Leon Romanovsky <leonro-VPRAkNaXOzVWk0Htik3J/[email protected]>
ipoib_dev_uninit_default() call is used in ipoib_main.c file only and it generates the following warning from smatch tool:
drivers/infiniband/ulp/ipoib/ipoib_main.c:1593:6: warning: symbol 'ipoib_dev_uninit_default' was not declared. Should it be static?
so let's declare that function as static.
--- drivers/infiniband/ulp/ipoib/ipoib_main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/infiniband/ulp/ipoib/ipoib_main.c +1 -1
@@ -1590,7 +1590,7 @@ static void ipoib_neigh_hash_uninit(struct net_device *dev)wait_for_completion (&priv->ntbl.deleted); } -void ipoib_dev_uninit_default (struct net_device *dev) +static void ipoib_dev_uninit_default (struct net_device *dev) {struct ipoib_dev_priv *priv =ipoib_priv (dev);
--
2.12.2
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
A message that is not in the archive (sent off-list or not yet received): 20170514103206.6777-1-leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org
Yuval Shaia
Reviewed-byQuoted 20 lines · Leon Romanovsky
From: Leon Romanovsky <leonro-VPRAkNaXOzVWk0Htik3J/[email protected]>
ipoib_dev_uninit_default()call is used inipoib_main.cfile only and it generates the following warning from smatch tool:drivers/infiniband/ulp/ipoib/ipoib_main.c:1593:6: warning: symbol 'ipoib_dev_uninit_default' was not declared. Should it be static?so let's declare that function as static.
--- drivers/infiniband/ulp/ipoib/ipoib_main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/infiniband/ulp/ipoib/ipoib_main.c +0
-0
drivers/infiniband/ulp/ipoib/ipoib_main.c static void ipoib_neigh_hash_uninit(struct net_device *dev) · line 1596
Quoted 8 lines
drivers/infiniband/ulp/ipoib/ipoib_main.c +1
-1@@ -1590,7 +1590,7 @@ static void ipoib_neigh_hash_uninit(struct net_device *dev)wait_for_completion (&priv->ntbl.deleted); } -void ipoib_dev_uninit_default (struct net_device *dev) +static void ipoib_dev_uninit_default (struct net_device *dev) {struct ipoib_dev_priv *priv =ipoib_priv (dev);
Quoted 7 lines
--
2.12.2--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
Doug Ledford
AppliedQuoted 9 lines · Leon Romanovsky
ipoib_dev_uninit_default()call is used inipoib_main.cfile only and it generates the following warning from smatch tool:
drivers/infiniband/ulp/ipoib/ipoib_main.c:1593:6: warning:
symbol 'ipoib_dev_uninit_default' was not declared. Should it be static?so let's declare that function as static.
Thanks, applied.
Signature · 9 lines
Doug Ledford <[email protected]> GPG KeyID: B826A3330E572FDD Key fingerprint = AE6B 1BDA 122B 23B4 265B 1274 B826 A333 0E57 2FDD -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html