Skip to content Skip to conversation

gpu: host1x: Forbid RESTART opcode in the firewall

PATCH In review Dmitry Osipenko 2 participants 2 messages May 15, 2017

Subsystems (3)

DRM drivers Tegra architecture support DRM drivers for NVIDIA Tegra

Share & tools

Dmitry Osipenko

author

2017-05-15 12:02 UTC #0 lore raw

PATCH 1/1 gpu: host1x: Forbid RESTART opcode in the firewall

The RESTART opcode terminates the gather and restarts the CDMA fetch from a specified word << 2 relative to the CDMA start address. That shouldn't be allowed to be done by userspace.

Signed-off-by Dmitry Osipenko <[email protected]>

---
 drivers/gpu/host1x/job.c | 1 -
 1 file changed, 1 deletion(-)

drivers/gpu/host1x/job.c +0 -1

index 8f0d43b8f9a6..d648748b3e74 100644
@@ -493,7 +493,6 @@ static int validate(struct host1x_firewall *fw, struct host1x_job_gather *g)
 				goto out;
 			break;
 		case 4:
-		case 5:
 		case 14:
 			break;
 		default:

Signature · 1 line

2.13.0

Erik Faye-Lund

Reviewed-by on v1 1/1

2017-05-15 12:06 UTC #1 lore raw

Quoted 5 lines · Dmitry Osipenko

The RESTART opcode terminates the gather and restarts the CDMA fetch from a specified word << 2 relative to the CDMA start address. That shouldn't be allowed to be done by userspace.
Signed-off-by Dmitry Osipenko <[email protected]>

Outch, yeah.

Reviewed-by Erik Faye-Lund <[email protected]>

_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel