drm/vc4: Mark the device as active when enabling runtime PM.
Subsystems (3)
PATCH 1/1 drm/vc4: Mark the device as active when enabling runtime PM.
Failing to do so meant that we got a resume() callback on first use of the device, so we would leak the bin BO that we allocated during probe.
Signed-off-by Eric Anholt <[email protected]>
Fixes 553c942f8b2c ("drm/vc4: Allow using more than 256MB of CMA memory.")
--- drivers/gpu/drm/vc4/vc4_v3d.c | 1 + 1 file changed, 1 insertion(+)
drivers/gpu/drm/vc4/vc4_v3d.c +1 -0
@@ -403,6 +403,7 @@ static int vc4_v3d_bind(struct device *dev, struct device *master, void *data)return ret; } +pm_runtime_set_active (dev);pm_runtime_use_autosuspend (dev);pm_runtime_set_autosuspend_delay (dev,40 );/* a little over 2 frames. */ pm_runtime_enable (dev);
Signature · 6 lines
2.11.0 _______________________________________________ dri-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/dri-devel
Quoted 6 lines · On Mon, 15 May 2017 10:16:15 -0700 Eric Anholt <[email protected]> wrote:
Failing to do so meant that we got a
resume()callback on first use of the device, so we would leak the bin BO that we allocated during probe.Signed-off-by Eric Anholt <[email protected]>Fixes 553c942f8b2c ("drm/vc4: Allow using more than 256MB of CMA memory.")
Reviewed-by Boris Brezillon <[email protected]>
Quoted 9 lines
--- drivers/gpu/drm/vc4/vc4_v3d.c | 1 + 1 file changed, 1 insertion(+)drivers/gpu/drm/vc4/vc4_v3d.c +0
-0
drivers/gpu/drm/vc4/vc4_v3d.c static int vc4_v3d_bind(struct device *dev, struct device *master, void *data) · line 409
Quoted 7 lines
drivers/gpu/drm/vc4/vc4_v3d.c +1
-0@@ -403,6 +403,7 @@ static int vc4_v3d_bind(struct device *dev, struct device *master, void *data)return ret; } +pm_runtime_set_active (dev);pm_runtime_use_autosuspend (dev);pm_runtime_set_autosuspend_delay (dev,40 );/* a little over 2 frames. */ pm_runtime_enable (dev);
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel