Skip to contentSkip to conversation

mfd: intel_soc_pmic: Select designware i2c-bus driver

PATCH Superseded Hans de Goede 3 participants 8 messages May 15, 2017 – May 30, 2017 Multifunction devices (MFD)

v4 of 5 Superseded Latest is v5 →

lore
Share & tools
lore
#0 lore raw

PATCH v4 1/2 mfd: intel_soc_pmic: Select designware i2c-bus driver

The Crystal Cove PMIC provides an ACPI OPRegion handler, which must be available before other drivers using it are loaded, which is why INTEL_SOC_PMIC is a bool.

Just having the driver is not enough, the driver for the i2c-bus must also be built in, to ensure this, this patch adds a select for it.

This fixes errors like these during boot:

mmc0: SDHCI controller on ACPI [80860F14:00] using ADMA
ACPI Error: No handler for Region [REGS] (ffff93543b0cc3a8) [UserDefinedRegion] (20170119/evregion-166) ACPI Error: Region UserDefinedRegion (ID=143) has no handler (20170119/exfldio-299)
ACPI Error: Method parse/execution failed [\_SB.PCI0.I2C7.PMI5.GET] (Node ffff93543b0cde10), AE_NOT_EXIST (20170119/psparse-543) ACPI Error: Method parse/execution failed [\_SB.PCI0.SHC1._PS0] (Node ffff93543b0b5cd0), AE_NOT_EXIST (20170119/psparse-543) acpi 80860F14:02: Failed to change power state to D0

While at it this patch also changes the human readable name of the Kconfig option to make clear the INTEL_SOC_PMIC option selects support for the Intel Crystal Cove PMIC and documents why this is a bool.

Cc Andy Shevchenko <[email protected]>

---
Note this patch will partially conflicts with (contains the same changes as) a patch in Andy Shevchenko's tree.
---
Changes in v2:
-Fix Kconfig depends and selects to fix warning reported by kbuild test robot -Improve commit msg (add example of ACPI errors this avoids) Changes in v3:
-No changes
Changes in v4:
-Add explanation why this is a bool and why it selects i2c-designwaree
to the help text rather then as comments in the Kconfig

---
 drivers/mfd/Kconfig | 11 +++++++++--
 1 file changed, 9 insertions(+), 2 deletions(-)
drivers/mfd/Kconfig +9 -2
index 1b6a83a4a114..61ebda81e134 100644
@@ -448,17 +448,24 @@ config LPC_SCH
 
 config INTEL_SOC_PMIC
 	bool "Support for Crystal Cove PMIC"
-	depends on GPIOLIB
-	depends on I2C=y
+	depends on HAS_IOMEM
+	select GPIOLIB
+	select I2C
 	select MFD_CORE
 	select REGMAP_I2C
 	select REGMAP_IRQ
+	select COMMON_CLK
+	select I2C_DESIGNWARE_PLATFORM
 	help
 	  Select this option to enable support for Crystal Cove PMIC
 	  on some Intel SoC systems. The PMIC provides ADC, GPIO,
 	  thermal, charger and related power management functions
 	  on these systems.
 
+	  This option is a bool as it provides an ACPI Opregion which must be
+	  available before any devices using it are probed. This option also
+	  causes the designware-i2c driver to be builtin for the same reason.
+
 config INTEL_SOC_PMIC_BXTWC
 	tristate "Support for Intel Broxton Whiskey Cove PMIC"
 	depends on INTEL_PMC_IPC
Signature · 1 line
2.12.2
#1 lore raw

PATCH v4 2/2 mfd: axp20x-i2c: Document that this must be builtin on x86

On x86 the axp288 PMIC provides an ACPI OpRegion handler, which must be available before other drivers using it are loaded, which can only be ensured if the mfd, OpRegionr and i2c-bus drivers are built in.

Since the axp20x mfd code is used on non X86 too we cannot simply change this into a bool, I've tried some Kconfig magic with if x86 but I could not get this working correctly, so this commit just documents that this should be builtin on x86, which fixes errors like these during boot:

mmc0: SDHCI controller on ACPI [80860F14:00] using ADMA
ACPI Error: No handler for Region [REGS] (ffff93543b0cc3a8) [UserDefinedRegion] ACPI Error: Region UserDefinedRegion (ID=143) has no handler (20170119/exfldio-2 ACPI Error: Method parse/execution failed [\_SB.PCI0.I2C7.PMI5.GET] (Node ffff93 ACPI Error: Method parse/execution failed [\_SB.PCI0.SHC1._PS0] (Node ffff93543b acpi 80860F14:02: Failed to change power state to D0

---
Changes in v2:
-Fix Kconfig depends and selects to fix warning reported by kbuild test robot -Improve commit msg (add example of ACPI errors this avoids) Changes in v3:
-Since the axp20x mfd code is used on ARM too where it does not necessarily
need to be builtin settle for simply documenting the need to have this builtin on x86

---
 drivers/mfd/Kconfig | 5 +++++
 1 file changed, 5 insertions(+)
drivers/mfd/Kconfig +5 -0
index 61ebda81e134..cfac1e8a0a20 100644
@@ -160,6 +160,11 @@ config MFD_AXP20X_I2C
 	  components like regulators or the PEK (Power Enable Key) under the
 	  corresponding menus.
 
+	  Note on x86 this provides an ACPI OpRegion, so this must be 'y'
+	  (builtin) and not a module, as the OpRegion must be available as
+	  soon as possible. For the same reason the i2c bus driver options
+	  I2C_DESIGNWARE_PLATFORM and I2C_DESIGNWARE_BAYTRAIL must be 'y' too.
+
 config MFD_AXP20X_RSB
 	tristate "X-Powers AXP series PMICs with RSB"
 	select MFD_AXP20X
Signature · 1 line
2.12.2
#2 lore raw

Re: [PATCH v4 2/2] mfd: axp20x-i2c: Document that this must be builtin on x86

Quoted 9 lines · Hans de Goede

On x86 the axp288 PMIC provides an ACPI OpRegion handler, which must be available before other drivers using it are loaded, which can only be ensured if the mfd, OpRegionr and i2c-bus drivers are built in.

Since the axp20x mfd code is used on non X86 too we cannot simply change this into a bool, I've tried some Kconfig magic with if x86 but I could not get this working correctly, so this commit just documents that this should be builtin on x86, which fixes errors like these during boot:

Quoted 8 lines

mmc0: SDHCI controller on ACPI [80860F14:00] using ADMA
ACPI Error: No handler for Region [REGS] (ffff93543b0cc3a8) [UserDefinedRegion] ACPI Error: Region UserDefinedRegion (ID=143) has no handler (20170119/exfldio-2 ACPI Error: Method parse/execution failed [\_SB.PCI0.I2C7.PMI5.GET] (Node ffff93 ACPI Error: Method parse/execution failed [\_SB.PCI0.SHC1._PS0] (Node ffff93543b acpi 80860F14:02: Failed to change power state to D0

Would be good to get an Ack by the users/maintainers of this driver.

Quoted 17 lines

---
Changes in v2:

(quoted diff) +0 -2
-Fix Kconfig depends and selects to fix warning reported by kbuild test robot
-Improve commit msg (add example of ACPI errors this avoids)

Changes in v3:

(quoted diff) +0 -2
-Since the axp20x mfd code is used on ARM too where it does not necessarily
 need to be builtin settle for simply documenting the need to have this
 builtin on x86
---
 drivers/mfd/Kconfig | 5 +++++
 1 file changed, 5 insertions(+)
drivers/mfd/Kconfig +0 -0
index 61ebda81e134..cfac1e8a0a20 100644

drivers/mfd/Kconfig config MFD_AXP20X_I2C · line 165

Quoted 6 lines
drivers/mfd/Kconfig +3 -0
@@ -160,6 +160,11 @@ config MFD_AXP20X_I2C
 	  components like regulators or the PEK (Power Enable Key) under the
 	  corresponding menus.
 
+	  Note on x86 this provides an ACPI OpRegion, so this must be 'y'
+	  (builtin) and not a module, as the OpRegion must be available as
+	  soon as possible. For the same reason the i2c bus driver options

Nit: s/i2c/I2C/

Quoted 5 lines
drivers/mfd/Kconfig +2 -0
+	  I2C_DESIGNWARE_PLATFORM and I2C_DESIGNWARE_BAYTRAIL must be 'y' too.
+
 config MFD_AXP20X_RSB
 	tristate "X-Powers AXP series PMICs with RSB"
 	select MFD_AXP20X
Signature · 4 lines
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
#3 lore raw

Re: [PATCH v4 2/2] mfd: axp20x-i2c: Document that this must be builtin on x86

Hi,

Quoted 18 lines · Lee Jones
Quoted 16 lines · Hans de Goede

On x86 the axp288 PMIC provides an ACPI OpRegion handler, which must be available before other drivers using it are loaded, which can only be ensured if the mfd, OpRegionr and i2c-bus drivers are built in.

Since the axp20x mfd code is used on non X86 too we cannot simply change this into a bool, I've tried some Kconfig magic with if x86 but I could not get this working correctly, so this commit just documents that this should be builtin on x86, which fixes errors like these during boot:

mmc0: SDHCI controller on ACPI [80860F14:00] using ADMA
ACPI Error: No handler for Region [REGS] (ffff93543b0cc3a8) [UserDefinedRegion] ACPI Error: Region UserDefinedRegion (ID=143) has no handler (20170119/exfldio-2 ACPI Error: Method parse/execution failed [\_SB.PCI0.I2C7.PMI5.GET] (Node ffff93 ACPI Error: Method parse/execution failed [\_SB.PCI0.SHC1._PS0] (Node ffff93543b acpi 80860F14:02: Failed to change power state to D0

Quoted 3 lines
Quoted 1 line

Would be good to get an Ack by the users/maintainers of this driver.

If you look at recent commits to drivers for the mfd-subdevices for the AXP288 (which is the only AXP PMIC found on x86 systems) you will see that I've been the only one touch them / caring about them and in many cases fixing them from being non-functional to actually working.

I do have quite a few people who are using the AXP288 code on Bay and Cherry Trail devices with this PMIC and who have send me thank you's and test success reports.

So I guess I'm the closest thing to a MAINTAINER for the axp288 bits of this driver.

Quoted 20 lines
Quoted 20 lines

---
Changes in v2:

(quoted diff) +0 -2
-Fix Kconfig depends and selects to fix warning reported by kbuild test robot
-Improve commit msg (add example of ACPI errors this avoids)

Changes in v3:

(quoted diff) +0 -2
-Since the axp20x mfd code is used on ARM too where it does not necessarily
  need to be builtin settle for simply documenting the need to have this
  builtin on x86
---
  drivers/mfd/Kconfig | 5 +++++
  1 file changed, 5 insertions(+)
drivers/mfd/Kconfig +0 -0
index 61ebda81e134..cfac1e8a0a20 100644
@@ -160,6 +160,11 @@ config MFD_AXP20X_I2C
  	  components like regulators or the PEK (Power Enable Key) under the
  	  corresponding menus.
 
Quoted 5 lines

drivers/mfd/Kconfig config MFD_AXP20X_I2C · line 165

Quoted 3 lines
drivers/mfd/Kconfig +3 -0
+	  Note on x86 this provides an ACPI OpRegion, so this must be 'y'
+	  (builtin) and not a module, as the OpRegion must be available as
+	  soon as possible. For the same reason the i2c bus driver options

Nit: s/i2c/I2C/

Fixed for v5 (which I will send in a minute).

Regards,

Hans

#4 lore raw

Re: [PATCH v4 2/2] mfd: axp20x-i2c: Document that this must be builtin on x86

Quoted 25 lines · Hans de Goede

Hi,

Quoted 18 lines · Lee Jones
Quoted 16 lines · Hans de Goede

On x86 the axp288 PMIC provides an ACPI OpRegion handler, which must be available before other drivers using it are loaded, which can only be ensured if the mfd, OpRegionr and i2c-bus drivers are built in.

Since the axp20x mfd code is used on non X86 too we cannot simply change this into a bool, I've tried some Kconfig magic with if x86 but I could not get this working correctly, so this commit just documents that this should be builtin on x86, which fixes errors like these during boot:

mmc0: SDHCI controller on ACPI [80860F14:00] using ADMA
ACPI Error: No handler for Region [REGS] (ffff93543b0cc3a8) [UserDefinedRegion] ACPI Error: Region UserDefinedRegion (ID=143) has no handler (20170119/exfldio-2 ACPI Error: Method parse/execution failed [\_SB.PCI0.I2C7.PMI5.GET] (Node ffff93 ACPI Error: Method parse/execution failed [\_SB.PCI0.SHC1._PS0] (Node ffff93543b acpi 80860F14:02: Failed to change power state to D0

Quoted 3 lines
Quoted 1 line

Would be good to get an Ack by the users/maintainers of this driver.

Quoted 8 lines

If you look at recent commits to drivers for the mfd-subdevices for the AXP288 (which is the only AXP PMIC found on x86 systems) you will see that I've been the only one touch them / caring about them and in many cases fixing them from being non-functional to actually working.

I do have quite a few people who are using the AXP288 code on Bay and Cherry Trail devices with this PMIC and who have send me thank you's and test success reports.

Would any of them be prepared to submit a Tested-by?

You can forward them (with permission) if you like.

Quoted 33 lines

So I guess I'm the closest thing to a MAINTAINER for the axp288 bits of this driver.

Quoted 12 lines
Quoted 12 lines

---
Changes in v2:

(quoted diff) +0 -2
-Fix Kconfig depends and selects to fix warning reported by kbuild test robot
-Improve commit msg (add example of ACPI errors this avoids)

Changes in v3:
-Since the axp20x mfd code is used on ARM too where it does not necessarily
need to be builtin settle for simply documenting the need to have this builtin on x86

---
  drivers/mfd/Kconfig | 5 +++++
  1 file changed, 5 insertions(+)
Quoted 12 lines

drivers/mfd/Kconfig config MFD_AXP20X_I2C · line 164

Quoted 10 lines
drivers/mfd/Kconfig +3 -0
index 61ebda81e134..cfac1e8a0a20 100644
@@ -160,6 +160,11 @@ config MFD_AXP20X_I2C
  	  components like regulators or the PEK (Power Enable Key) under the
  	  corresponding menus.
+	  Note on x86 this provides an ACPI OpRegion, so this must be 'y'
+	  (builtin) and not a module, as the OpRegion must be available as
+	  soon as possible. For the same reason the i2c bus driver options

Nit: s/i2c/I2C/

Fixed for v5 (which I will send in a minute).

Regards,

Hans

Signature · 4 lines
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
#5 lore raw
In reply to Hans de Goede
Quoted 16 lines · Hans de Goede

The Crystal Cove PMIC provides an ACPI OPRegion handler, which must be available before other drivers using it are loaded, which is why INTEL_SOC_PMIC is a bool.

Just having the driver is not enough, the driver for the i2c-bus must also be built in, to ensure this, this patch adds a select for it.

This fixes errors like these during boot:

mmc0: SDHCI controller on ACPI [80860F14:00] using ADMA
ACPI Error: No handler for Region [REGS] (ffff93543b0cc3a8) [UserDefinedRegion] (20170119/evregion-166) ACPI Error: Region UserDefinedRegion (ID=143) has no handler (20170119/exfldio-299)
ACPI Error: Method parse/execution failed [\_SB.PCI0.I2C7.PMI5.GET] (Node ffff93543b0cde10), AE_NOT_EXIST (20170119/psparse-543) ACPI Error: Method parse/execution failed [\_SB.PCI0.SHC1._PS0] (Node ffff93543b0b5cd0), AE_NOT_EXIST (20170119/psparse-543) acpi 80860F14:02: Failed to change power state to D0

Quoted 6 lines

While at it this patch also changes the human readable name of the Kconfig option to make clear the INTEL_SOC_PMIC option selects support for the Intel Crystal Cove PMIC and documents why this is a bool.

Cc Andy Shevchenko <[email protected]>

Would be good to get an Ack by the users/maintainers of this driver.

Quoted 3 lines

---
Note this patch will partially conflicts with (contains the same changes as) a patch in Andy Shevchenko's tree.

Has this been sorted now?

Quoted 28 lines

---
Changes in v2:

(quoted diff) +0 -2
-Fix Kconfig depends and selects to fix warning reported by kbuild test robot
-Improve commit msg (add example of ACPI errors this avoids)

Changes in v3:
-No changes
Changes in v4:

(quoted diff) +0 -2
-Add explanation why this is a bool and why it selects i2c-designwaree
 to the help text rather then as comments in the Kconfig
---
 drivers/mfd/Kconfig | 11 +++++++++--
 1 file changed, 9 insertions(+), 2 deletions(-)
drivers/mfd/Kconfig +3 -2
index 1b6a83a4a114..61ebda81e134 100644
@@ -448,17 +448,24 @@ config LPC_SCH
 
 config INTEL_SOC_PMIC
 	bool "Support for Crystal Cove PMIC"
-	depends on GPIOLIB
-	depends on I2C=y
+	depends on HAS_IOMEM
+	select GPIOLIB
+	select I2C
 	select MFD_CORE
 	select REGMAP_I2C

drivers/mfd/Kconfig config LPC_SCH · line 465

Quoted 10 lines
drivers/mfd/Kconfig +3 -0
 	select REGMAP_IRQ
+	select COMMON_CLK
+	select I2C_DESIGNWARE_PLATFORM
 	help
 	  Select this option to enable support for Crystal Cove PMIC
 	  on some Intel SoC systems. The PMIC provides ADC, GPIO,
 	  thermal, charger and related power management functions
 	  on these systems.
 
+	  This option is a bool as it provides an ACPI Opregion which must be

Nit: s/Opregion/OpRegion/

Quoted 6 lines
drivers/mfd/Kconfig +3 -0
+	  available before any devices using it are probed. This option also
+	  causes the designware-i2c driver to be builtin for the same reason.
+
 config INTEL_SOC_PMIC_BXTWC
 	tristate "Support for Intel Broxton Whiskey Cove PMIC"
 	depends on INTEL_PMC_IPC
Signature · 4 lines
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
Reviewed-by
#6 lore raw
Quoted 30 lines · Lee Jones
Quoted 28 lines · Hans de Goede

The Crystal Cove PMIC provides an ACPI OPRegion handler, which must be
available before other drivers using it are loaded, which is why INTEL_SOC_PMIC is a bool.

Just having the driver is not enough, the driver for the i2c-bus must
also be built in, to ensure this, this patch adds a select for it.

This fixes errors like these during boot:

mmc0: SDHCI controller on ACPI [80860F14:00] using ADMA ACPI Error: No handler for Region [REGS] (ffff93543b0cc3a8) [UserDefinedRegion] (20170119/evregion-166)
ACPI Error: Region UserDefinedRegion (ID=143) has no handler (20170119/exfldio-299)
ACPI Error: Method parse/execution failed [\_SB.PCI0.I2C7.PMI5.GET] (Node ffff93543b0cde10), AE_NOT_EXIST (20170119/psparse-543) ACPI Error: Method parse/execution failed [\_SB.PCI0.SHC1._PS0] (Node ffff93543b0b5cd0), AE_NOT_EXIST (20170119/psparse-543) acpi 80860F14:02: Failed to change power state to D0

While at it this patch also changes the human readable name of the Kconfig
option to make clear the INTEL_SOC_PMIC option selects support for the
Intel Crystal Cove PMIC and documents why this is a bool.

Quoted 4 lines
Quoted 2 lines
Cc Andy Shevchenko <[email protected]>

Would be good to get an Ack by the users/maintainers of this driver.

I'm not sure you will get (active) one.

Quoted 1 line

From my prospective, FWIW:

Quoted 9 lines
Quoted 5 lines

---
Note this patch will partially conflicts with (contains the same changes as)
a patch in Andy Shevchenko's tree.

Has this been sorted now?

From code it looks like (renaming is already done ---vvv).

Quoted 2 lines
Quoted 2 lines

 config INTEL_SOC_PMIC
  bool "Support for Crystal Cove PMIC"

Signature · 2 lines
Andy Shevchenko <[email protected]>
Intel Finland Oy
#7 lore raw
In reply to Lee Jones

Hi,

Quoted 25 lines · Lee Jones
Quoted 16 lines · Hans de Goede

The Crystal Cove PMIC provides an ACPI OPRegion handler, which must be available before other drivers using it are loaded, which is why INTEL_SOC_PMIC is a bool.

Just having the driver is not enough, the driver for the i2c-bus must also be built in, to ensure this, this patch adds a select for it.

This fixes errors like these during boot:

mmc0: SDHCI controller on ACPI [80860F14:00] using ADMA
ACPI Error: No handler for Region [REGS] (ffff93543b0cc3a8) [UserDefinedRegion] (20170119/evregion-166) ACPI Error: Region UserDefinedRegion (ID=143) has no handler (20170119/exfldio-299)
ACPI Error: Method parse/execution failed [\_SB.PCI0.I2C7.PMI5.GET] (Node ffff93543b0cde10), AE_NOT_EXIST (20170119/psparse-543) ACPI Error: Method parse/execution failed [\_SB.PCI0.SHC1._PS0] (Node ffff93543b0b5cd0), AE_NOT_EXIST (20170119/psparse-543) acpi 80860F14:02: Failed to change power state to D0

Quoted 6 lines

While at it this patch also changes the human readable name of the Kconfig option to make clear the INTEL_SOC_PMIC option selects support for the Intel Crystal Cove PMIC and documents why this is a bool.

Cc Andy Shevchenko <[email protected]>
Quoted 7 lines

Would be good to get an Ack by the users/maintainers of this driver.

Quoted 3 lines

---
Note this patch will partially conflicts with (contains the same changes as) a patch in Andy Shevchenko's tree.

Has this been sorted now?

Yes, sorry I should have dropped this bit.

Quoted 38 lines
Quoted 38 lines

---
Changes in v2:

(quoted diff) +0 -2
-Fix Kconfig depends and selects to fix warning reported by kbuild test robot
-Improve commit msg (add example of ACPI errors this avoids)

Changes in v3:
-No changes
Changes in v4:

(quoted diff) +0 -2
-Add explanation why this is a bool and why it selects i2c-designwaree
  to the help text rather then as comments in the Kconfig
---
  drivers/mfd/Kconfig | 11 +++++++++--
  1 file changed, 9 insertions(+), 2 deletions(-)
drivers/mfd/Kconfig +5 -2
index 1b6a83a4a114..61ebda81e134 100644
@@ -448,17 +448,24 @@ config LPC_SCH
 
  config INTEL_SOC_PMIC
  	bool "Support for Crystal Cove PMIC"
-	depends on GPIOLIB
-	depends on I2C=y
+	depends on HAS_IOMEM
+	select GPIOLIB
+	select I2C
  	select MFD_CORE
  	select REGMAP_I2C
  	select REGMAP_IRQ
+	select COMMON_CLK
+	select I2C_DESIGNWARE_PLATFORM
  	help
  	  Select this option to enable support for Crystal Cove PMIC
  	  on some Intel SoC systems. The PMIC provides ADC, GPIO,
  	  thermal, charger and related power management functions
  	  on these systems.
 
Quoted 3 lines

drivers/mfd/Kconfig config LPC_SCH · line 465

Quoted 1 line
drivers/mfd/Kconfig +1 -0
+	  This option is a bool as it provides an ACPI Opregion which must be

Nit: s/Opregion/OpRegion/

Fixed for v5 (which I will send in a minute).

Regards,

Hans