Skip to contentSkip to conversation

char: ipmi: remove unnecessary code

PATCH In review Gustavo A. R. Silva 2 participants 3 messages May 15, 2017 – May 17, 2017 IPMI

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 char: ipmi: remove unnecessary code

The array field name in struct i2c_adapter is a fixed size array so it can never be NULL.

Addresses-Coverity-ID: 1397986

---
 drivers/char/ipmi/ipmi_ssif.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/char/ipmi/ipmi_ssif.c +1 -1
index cca6e5b..df4fea7 100644
@@ -1415,7 +1415,7 @@ static int find_slave_address(struct i2c_client *client, int slave_addr)
 	list_for_each_entry(info, &ssif_infos, link) {
 		if (info->binfo.addr != client->addr)
 			continue;
-		if (info->adapter_name && client->adapter->name &&
+		if (info->adapter_name &&
 		    strcmp_nospace(info->adapter_name,
 				   client->adapter->name))
 			continue;
Signature · 1 line
2.5.0
#1 lore raw
Quoted 2 lines · Gustavo A. R. Silva

The array field name in struct i2c_adapter is a fixed size array so it can never be NULL.

This was already caught by Colin Ian King, a patch is already queued for this.

Thanks,

-corey

Quoted 19 lines

Addresses-Coverity-ID: 1397986

---
  drivers/char/ipmi/ipmi_ssif.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
drivers/char/ipmi/ipmi_ssif.c +1 -1
index cca6e5b..df4fea7 100644
@@ -1415,7 +1415,7 @@ static int find_slave_address(struct i2c_client *client, int slave_addr)
  	list_for_each_entry(info, &ssif_infos, link) {
  		if (info->binfo.addr != client->addr)
  			continue;
-		if (info->adapter_name && client->adapter->name &&
+		if (info->adapter_name &&
  		    strcmp_nospace(info->adapter_name,
  				   client->adapter->name))
  			continue;
#2 lore raw

Hi Corey,

Quoting Corey Minyard <[email protected]>:

Quoted 6 lines · Gustavo A. R. Silva
Quoted 2 lines

The array field name in struct i2c_adapter is a fixed size array so it can never be NULL.

This was already caught by Colin Ian King, a patch is already queued for this.

Great, it's good to know.

Thanks
--
Gustavo A. R. Silva